[Openvpn-devel,1/1] openvpn-[client|server].service: Remove syslog.target

Message ID 20240304163313.2326923-1-frank@lichtenheld.com
State Accepted
Headers show
Series [Openvpn-devel,1/1] openvpn-[client|server].service: Remove syslog.target | expand

Commit Message

Frank Lichtenheld March 4, 2024, 4:33 p.m. UTC
From: Martin Rys <martin@rys.pw>

Change-Id: If825e5b1ebc6eecc9e5398f0d8274927b53e5b83
Signed-off-by: Martin Rys <martin@rys.pw>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
---
 distro/systemd/openvpn-client@.service.in | 2 +-
 distro/systemd/openvpn-server@.service.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Gert Doering March 6, 2024, 9:41 a.m. UTC | #1
I have no idea and I do not want to know details about systemd, but
the explanation "this target has not existed for a long time" makes
sense, plus it has an ACK from someone who does understand Linux ;-)

Your patch has been applied to the master and release/2.6 branch.

commit 15b74036a9b180e862ed4cb23f1e351c08706527 (master)
commit 04e682653993212b1b7f9432791e325d92c470b6 (release/2.6)
Author: Martin Rys
Date:   Mon Mar 4 17:33:13 2024 +0100

     openvpn-[client|server].service: Remove syslog.target

     Signed-off-by: Martin Rys <martin@rys.pw>
     Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Message-Id: <20240304163313.2326923-1-frank@lichtenheld.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28318.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/distro/systemd/openvpn-client@.service.in b/distro/systemd/openvpn-client@.service.in
index 159fb4dc..8e18629b 100644
--- a/distro/systemd/openvpn-client@.service.in
+++ b/distro/systemd/openvpn-client@.service.in
@@ -1,6 +1,6 @@ 
 [Unit]
 Description=OpenVPN tunnel for %I
-After=syslog.target network-online.target
+After=network-online.target
 Wants=network-online.target
 Documentation=man:openvpn(8)
 Documentation=https://community.openvpn.net/openvpn/wiki/Openvpn24ManPage
diff --git a/distro/systemd/openvpn-server@.service.in b/distro/systemd/openvpn-server@.service.in
index 6e8e7d94..8752440f 100644
--- a/distro/systemd/openvpn-server@.service.in
+++ b/distro/systemd/openvpn-server@.service.in
@@ -1,6 +1,6 @@ 
 [Unit]
 Description=OpenVPN service for %I
-After=syslog.target network-online.target
+After=network-online.target
 Wants=network-online.target
 Documentation=man:openvpn(8)
 Documentation=https://community.openvpn.net/openvpn/wiki/Openvpn24ManPage