From patchwork Tue Jun 18 12:01:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 3735 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:a68e:b0:57d:b2cb:6cf with SMTP id hn14csp2106044mab; Tue, 18 Jun 2024 05:02:29 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXex0oOIzCdh9MDFSdc7WBLvF8YdJfjnWZ8noXngroSBxfN6vfhs9aeWPbaamGxfkL8ji1aaEX5rnifZ48VpioP/BAyt+0= X-Google-Smtp-Source: AGHT+IFqeAg9ysAnE981ha07ieEjAN8dekbxoV2L4Dj0UdzNq9bFwzjMtrhpsV+7FLPE7fzOMndm X-Received: by 2002:a17:902:d511:b0:1f3:10e8:1e0 with SMTP id d9443c01a7336-1f8627f38bbmr143240875ad.2.1718712149039; Tue, 18 Jun 2024 05:02:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718712149; cv=none; d=google.com; s=arc-20160816; b=Hprt4vmwAQG3ooKD8ZnPo0ToIf/dNGn2OqfUT5Tz04Mduyd5W7derdaC4IapBtNHZR kKOO6RXKYaK56mpwHJTRPxTaC8dnAhoggcBfGo3fXBNppxBRmQWWoKJaRm1AMvfw9y8n 5sHIcl1R5ptD1O4NiY0j7j5JGfODy9zWBp6zBcbyblp+wOrBDWP7RK7jfu06mVNTRoer 2ciPrzjNPhNoWY2g3ySrX2MG4e7H3H2e85pb4PTL7c/xM06WYMF1LQhYCs9oDocd68UY g6LaqmAX1knpYhd61buw/wDU8Ecf5nvgzaNinnLrhrwhoz6tp67SMB598LLWMr05yURw XsKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature; bh=S1IqcPKj3ZkB9GaBMmoxIQpY1sKWhf2ObAx0Hj3Mx7A=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=vrD+Z1rM7dAKgayABSL7lp3kuuokZaB+fYi1ch/4ytBdM3aeQF3gX8bRgZRWBewk6g 7AteNpMBKHXgiNtLUGlIPU59pJw/EA5DhDa8ZoOKLwRpYTk1009Lkokl4veN0WbUH0oN ozqzQ5BJG59ZLwC6N0jtOc2t86WJbgREP2q1BJYf4+RWXV3TVs1OMvExeebTszth2Qjg lrWQ/QbLXKPqhIhBTkflaTnrlprzN/EkANnq3J0Jnyw+UJQ1IRmIHCDLQeAvSm17Fld0 1rpUweKP14nbq1odD30geO9C6Ty1hlZk7nGih6j3yReNpPgq9GaIfABQKP4ETTNwlLwl cqng==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UrjUOQt4; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=crTBZ+YJ; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id d9443c01a7336-1f855f2e9d0si104723155ad.633.2024.06.18.05.02.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Jun 2024 05:02:29 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UrjUOQt4; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=crTBZ+YJ; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sJXXQ-0005Go-7D; Tue, 18 Jun 2024 12:02:13 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sJXXO-0005Gi-02 for openvpn-devel@lists.sourceforge.net; Tue, 18 Jun 2024 12:02:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=veMud78U0RU9OrLy1MpVxu/iXnWf1h+BEGkZOSxjUE0=; b=UrjUOQt4LhMbIaU/mv84OV8wtQ E+50oI/D2BOipUOvh8QeIrzZtWFRLf66ewaUfwDUh9Me5kLZwQzZKRtfqBvMOyLq4vK/ywtioYzWB 7DB6gVCl65Ic0fyGhzVIc1O2tPC9Q31BJ05gX8iHI3h/CMzI6yNjD8A5sycKRAvZdyw4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=veMud78U0RU9OrLy1MpVxu/iXnWf1h+BEGkZOSxjUE0=; b=crTBZ+YJKU5GX5rX1F/JXV02G2 amyKiqUuXYEQ44VXLsM4BqV/LW4e++ivySXqWTV6Nmz0PNgsUU1oH7Sgnqrk2CW7gTs58XdV+/ghn mRsn8SeiogM5BojlFKHXixdI3nQBrYR04M4BnQE2w423h9uTMXPskPWZJDxn0xjUqOg0=; Received: from dhcp-174.greenie.muc.de ([193.149.48.174] helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1sJXXO-00065D-93 for openvpn-devel@lists.sourceforge.net; Tue, 18 Jun 2024 12:02:11 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 45IC1vUR004846 for ; Tue, 18 Jun 2024 14:01:57 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 45IC1vpQ004845 for openvpn-devel@lists.sourceforge.net; Tue, 18 Jun 2024 14:01:57 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 18 Jun 2024 14:01:56 +0200 Message-ID: <20240618120156.4836-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.44.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: -5.0 (-----) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld This option is very old (from SVN days) and has been used by Access Server for many years. I don't think it makes sense to claim that it is "experimental" at this point. Content analysis details: (-5.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [193.149.48.174 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1sJXXO-00065D-93 Subject: [Openvpn-devel] [PATCH v1] Remove "experimental" denotation for --fast-io X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1802200310688723703?= X-GMAIL-MSGID: =?utf-8?q?1802200310688723703?= From: Frank Lichtenheld This option is very old (from SVN days) and has been used by Access Server for many years. I don't think it makes sense to claim that it is "experimental" at this point. Change-Id: I913bb70c5e527e78e7cdb43110e23a8944f35a22 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/664 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe diff --git a/doc/man-sections/generic-options.rst b/doc/man-sections/generic-options.rst index f8a0f48..eb9cf28 100644 --- a/doc/man-sections/generic-options.rst +++ b/doc/man-sections/generic-options.rst @@ -215,7 +215,7 @@ are supported by OpenSSL. --fast-io - (Experimental) Optimize TUN/TAP/UDP I/O writes by avoiding a call to + Optimize TUN/TAP/UDP I/O writes by avoiding a call to poll/epoll/select prior to the write operation. The purpose of such a call would normally be to block until the device or socket is ready to accept the write. Such blocking is unnecessary on some platforms which diff --git a/src/openvpn/options.c b/src/openvpn/options.c index abcde89..f2c7536 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -268,7 +268,7 @@ #if ENABLE_IP_PKTINFO "--multihome : Configure a multi-homed UDP server.\n" #endif - "--fast-io : (experimental) Optimize TUN/TAP/UDP writes.\n" + "--fast-io : Optimize TUN/TAP/UDP writes.\n" "--remap-usr1 s : On SIGUSR1 signals, remap signal (s='SIGHUP' or 'SIGTERM').\n" "--persist-tun : Keep tun/tap device open across SIGUSR1 or --ping-restart.\n" "--persist-remote-ip : Keep remote IP address across SIGUSR1 or --ping-restart.\n"