From patchwork Mon Jul 8 21:08:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?0JjQu9GM0Y8g0KjQuNC/0LjRhtC40L0=?= X-Patchwork-Id: 3757 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:298e:b0:59e:d24b:d55c with SMTP id f14csp2081925max; Mon, 8 Jul 2024 14:10:19 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUu59E4dFIPNZ7kL6ie+uu9XcYAo/2byzKTlq7PlIfMVhaVVKudkTGtK6PX1Zj8eGOxVBHsWXi3XL1+cW8eHrBt6QxzAZU= X-Google-Smtp-Source: AGHT+IHoRhFSr4Bz/Abry6p4e7UPf8gMmNK92Tc4QMEs/AGJ0zHr06f6Ipe0qOZtNKrXeISjmvW7 X-Received: by 2002:a05:6e02:1353:b0:378:cf86:357b with SMTP id e9e14a558f8ab-38a5910a911mr6582515ab.3.1720473019315; Mon, 08 Jul 2024 14:10:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720473019; cv=none; d=google.com; s=arc-20160816; b=d8LxcgGcb+3MdJhUtNCTFGz7pqe+zVY2AdZ7hvtbUKJNNLuC3QNTNZFfpJJy7q3v7E zs+nf7TZIzAh6cB2EUXAGKEG2IaOTfmy9DpUOdEauyd23WLdqkmWDm8UrDKKzPz8xhKz OOqP/RzKM2AY4Z+JezAdtXr+g1ezL5LuTszC0XHITxCySSgOWxQ/ucjIPZKPyUaie60f jUDT8XpxZlgDhamjioLNM/hqULoa2Bkim4dZ658mi35Pwxvv5BzdSN0TX4hwOWAu7Kd3 s3FQULGIZiSPbURRLydRe16kh7q7ufH/YRmKNPUGpbHQuh0l0/2azw1vG7CCjIgZlw6W DFBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=azSYVrAliUxK+AhXakUbOIV1ZcywZPahrY0Jtwzh/OQ=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=0fTBSbNc6ZwJQ1pbDpjeDvHRx3XhGjcuE30SdWTp3f8t/Loo5dX6+7a6hVEohW8rOO cbmveFWwTiiHA6J5A9uIndmhBht+JAhOWo4qZn0kPKQTct2+JgKjiFIyDy4qQLPE8TVv Qf5rC2ZDFV1AncML2auIOtHHH+yDF4/VYaOEkbLgnfPYKIbPcpUOr7dQCBamYN5P5ZCd DEh/IgPW0anE8cBCf6Q076m+tentdh2IIdHtAjI8oYgRty/p109zzYAVAdrpymZUzQBG gHml+Z/K74PwZkAMofESamUMrJI+9aJilRvidJ/2uGLL/MiSrsQysbohEW5X8x4cf5FO o4ng==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=NKTtOjFH; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=eYKAHbEn; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=JWfVWDbS; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 41be03b00d2f7-77d565b47casi549055a12.108.2024.07.08.14.10.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jul 2024 14:10:19 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=NKTtOjFH; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=eYKAHbEn; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=JWfVWDbS; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sQvcB-0002s3-Ft; Mon, 08 Jul 2024 21:09:39 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sQvcA-0002rn-8U for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=j+1/keE/FxJnxWKd8MM2DbwSKTC70up3Gf9Jc+2foJE=; b=NKTtOjFHsHcLKmEzi/N8qgT0tF DogPrpQO0W+Bqyr0oq+kSMkG7g1yfZO6n0dj2dFHAty7ndetmV18e8dhlrvkzAqKxe07B3TSXBQz0 3+1T3pKDePMeJ3DcgOrt5do/t2m6BjELwTnQxmeB81EYHZhcPmgpv4ArU1unw07Y2/i8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=j+1/keE/FxJnxWKd8MM2DbwSKTC70up3Gf9Jc+2foJE=; b=eYKAHbEnn0+IdOr8bRDTlnZ8ks QwHHlf0W4jATWOzPa5MdciERARie7GQe2LekgCobC1IPtL1IIUxTcWSDcVT2wKpDISShQ8NIWY3av iIu/ZHzxVcAWarxrBN6lgtK6zFxVuykllx1suXmQ+Oba94ah0vaSn7l/OGwTncZqaGYQ=; Received: from mail-wr1-f41.google.com ([209.85.221.41]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sQvcA-0000RQ-Lb for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:38 +0000 Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-367a23462e6so2763720f8f.3 for ; Mon, 08 Jul 2024 14:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720472971; x=1721077771; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j+1/keE/FxJnxWKd8MM2DbwSKTC70up3Gf9Jc+2foJE=; b=JWfVWDbSBPT28+2k91kUl7ubJwkfPDJVqEeZ5zEcYq//LCwBxH2OtyRaXmo3X5oar1 n52mNoyxL8edhnqNrJ5hiBLl/I2hd940uzn+8tKfaOIjJebSLpqDURLGTOH9Dzfwl6QO yBx4WDILzJfwWXaYoeXxEg2g93JB++DkKJPPrltkle5Hm7K8AL0uATOF9UV/Gd9rz8pi vRlQFFt3xS5FMzkQjyQoIesRE5kAS51lLdgA71WOpoYNd568l/6N9eEjSogaNmyqfyOK Th1z9F8iMmf++PI98RHd9fajEGLrcisQJqjQRq/0TDe0Asgqi1WhZ9B1uhGI2hWG1wuG 8RcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720472971; x=1721077771; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j+1/keE/FxJnxWKd8MM2DbwSKTC70up3Gf9Jc+2foJE=; b=ARsGEfXEdjcFhzXUtqMWv6G+tRYzt3p8et6cWMzrMfZgm5yobipaTCVVmgp35H3sZr WyC2q+ykff92gaJ7E1iFM0cowdUZ1hnfJfXz+luFHMrhNEtgYVVgelUKQ7QQIZVptGpX QBnVV05Wxs+Y7zuUdO8LFT5W913HdgeRKRkl6hgSzsd5C2XcVFrrMWjAX9MyRLwd+hhk n26yi0L5awfdEycvXnrETu3Qfv3dM5B2fpRcDg/YaKYkHW9OJrufAV7Mj3YxGI7EIeIG s3x6Wk2WSgux96DUtTdV3cJP6HWR4D4LP2INISb4zQmjmkygqJhC7rvEjZT2Rqk3zSKK GGmw== X-Gm-Message-State: AOJu0Yx7JRSCTlBDTs+xMnJCKyEIkOO2LtZqz8IsmKEwvqBbGrKJD0Yi Ug1UxPpcLGYsYRr4BCwN3hT+YflHlUiZG+Fp8tbyaYh7JnSY4eCTtYxY9Q== X-Received: by 2002:a05:6000:1844:b0:366:e9b8:784f with SMTP id ffacd0b85a97d-367cea96425mr628586f8f.32.1720472970714; Mon, 08 Jul 2024 14:09:30 -0700 (PDT) Received: from localhost.localdomain (109-93-166-140.dynamic.isp.telekom.rs. [109.93.166.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cdfa079asm684977f8f.68.2024.07.08.14.09.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 14:09:30 -0700 (PDT) From: Ilia Shipitsin To: openvpn-devel@lists.sourceforge.net Date: Mon, 8 Jul 2024 23:08:18 +0200 Message-ID: <20240708210912.566-2-chipitsine@gmail.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20240708210912.566-1-chipitsine@gmail.com> References: <20240708210912.566-1-chipitsine@gmail.com> MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Signed-off-by: Ilia Shipitsin --- src/openvpn/init.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index a49e5639..59205ba6 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -4967,6 +4967,10 @@ write_pid_file(const char *filename, const [...] Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [209.85.221.41 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.41 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.41 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [chipitsine[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.41 listed in wl.mailspike.net] X-Headers-End: 1sQvcA-0000RQ-Lb Subject: [Openvpn-devel] [PATCH 1/5] src/openvpn/init.c: handle strdup failures X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1804046716722012085?= X-GMAIL-MSGID: =?utf-8?q?1804046716722012085?= Signed-off-by: Ilia Shipitsin Acked-by: Gert Doering --- src/openvpn/init.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index a49e5639..59205ba6 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -4967,6 +4967,10 @@ write_pid_file(const char *filename, const char *chroot_dir) if (!chroot_dir) { saved_pid_file_name = strdup(filename); + if (!saved_pid_file_name) + { + msg( M_FATAL, "Failed allocate memory saved_pid_file_name"); + } } } }