From patchwork Mon Jul 8 21:08:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?0JjQu9GM0Y8g0KjQuNC/0LjRhtC40L0=?= X-Patchwork-Id: 3758 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:298e:b0:59e:d24b:d55c with SMTP id f14csp2081935max; Mon, 8 Jul 2024 14:10:21 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXQb4W9FvQmMxu4St7UndBl1kqAO0kbX46WImkNzqkeayHxFenvolw0WzPWhC+T73peleVHNWEEWyk5nKdM2UrRJyzHy54= X-Google-Smtp-Source: AGHT+IHO6E9aqwKTlrVDZUy0yIElqh6h0DsJs5lXhHC0C2iiMDI3fqXio07dSgSP5kBn6Z2Y4mFd X-Received: by 2002:a05:6e02:1066:b0:382:774e:a820 with SMTP id e9e14a558f8ab-38a54366279mr7689505ab.0.1720473021034; Mon, 08 Jul 2024 14:10:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720473021; cv=none; d=google.com; s=arc-20160816; b=J5gd5/h+JrsDkjSH1xD6rtygCfH2pI1cLYt3RDxu14rXsfjql9R2jZ8/l3WaiiPijo 32GzuxQeeZclKtZCSNK7K3YZC4K10PIYjnz2sfvS1K7/f1C7DoX4erPb/lBFpcW6WOUG jsN6/Xp/8ebTwLbsoqi/1JFPzMiO7EernzEq2aC33xXa7PQGKgxLc20JKeB/lwCMfhXl QmhKxFi9Jsknu/571BPaMmVLuU9fpIipwyoWHGjEDBRYr2pzcHF/VB6dwAlaIsFtJ6oB bS1tfCtLh7xddMv6WqgKxfraFHrTqRFq4aj4ufzKV9U1awrOO5/YzaNHpF0VTnE4EX3I JEwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=WwKg+cnWVLcNxrp7gH2W62E/VBN3AKVkslqepxP6E7I=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=l7IBHtRTCF7N1Pmk4Y+CBjW+A1Kj6b7UzRHp1l9hxmVvtq4S5rsA7roAGrSFh0NV9n vts46WsCQhwSYdJm1jyHaLqSAZe/p7lpMK3XKuxe5yRCaGypJjb9ac+ifX0rCg1VjKVY IfQPU5gIw1prVbmDjQe8w6BBslZrmL725cH8U3k1KOryns6/xW7JIY1mstSvrXhZD/Xk UZBOwrEU+U2CJgGkOk97D9dPO3GcibDURiFt0q/MSPVm9Lfziccn7IphY718+gwoJjKH MB9TvX+PT0mVURlv4QNlJc7AgWfvzDu3tIQJ77ytGr7WLFxgKGLZUe7eT5j3AaTR9Mtm JLxA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Z+EyFJcm; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XT5cMnzQ; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=YC4L9eQa; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 41be03b00d2f7-77d61738960si543234a12.701.2024.07.08.14.10.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jul 2024 14:10:20 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Z+EyFJcm; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XT5cMnzQ; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=YC4L9eQa; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sQvcQ-0005q4-Ex; Mon, 08 Jul 2024 21:09:53 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sQvcP-0005pv-EM for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5him/zntetlosiy/bG8KlkeBqnNS7XyNe76mbqfbUQE=; b=Z+EyFJcmE3cVen9F9wYEnzI/KJ XxTPkib7f3kocqnByY0LYEAx1x2mK+sxk0tBSdvY14uA6CS1BFExVxobu7ZUcJI3TDKp9yHO+RGah 28V2jH/dRH62zXImtEs7bDdFaHc0djig95/D/vuwdqTP2KoIzdftVH1sG7ggVhFOADsQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5him/zntetlosiy/bG8KlkeBqnNS7XyNe76mbqfbUQE=; b=XT5cMnzQ46yZa4IIqlClWnj+QK QpAcB70+m8OaYTxJWVcOHxifBTvzBd4huN4znnS0MMPFDL+DcLkRvqiMUWyKW+sjak7QPBPbTmn+A BR3vU6sm0/eMwqkdWwB5aVLtkbgDqXlx1OvVnitxKhZ2WHgtuunaN8xsW/i3I0y2N4no=; Received: from mail-wr1-f51.google.com ([209.85.221.51]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sQvcO-0000SH-Vx for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:52 +0000 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-35f06861ae6so2871566f8f.2 for ; Mon, 08 Jul 2024 14:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720472972; x=1721077772; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5him/zntetlosiy/bG8KlkeBqnNS7XyNe76mbqfbUQE=; b=YC4L9eQaFdfO4zYUknH3iJALGrLct8KRwfZcH4/FLNQ7oBr2iNOzvOY54OfXK4VkAN 4gwplvz6UlikN8hnZqj9T8LU6jAPOVOwubMPGiW6KijcAfMVe0uFbPmFqmsZKlrV930k 93AfIGUsFoIm75GuqyS20NEIF/5Wh4BqohpI2Jqh0/0RGGMxGIEFe8+FPlBOtJn35aEl 2i/J8cq2DK/bebkNh/5xe/x/hJVvrNdfXGAXT0L4/QneXmfy9awnYA5/O1IuXay+QoEx HwKSlLhHtfANBkcpCOxBG4lWNMDUbixJ6Q4vEh/H7F8jyFwJ/ghQEF7gjRspOItBBL2g RUvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720472972; x=1721077772; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5him/zntetlosiy/bG8KlkeBqnNS7XyNe76mbqfbUQE=; b=WkuoW/N5COfP1yQlcaRNCQLfYuaiLU8wm6Wpx+p7UlhTrvYt5XqiMasraX/9dyU/sA YTA2FB/8alSx2vG1/qpdAj3FZsqKa8fwAS6qsrPKwrvjDeBRahl9JSJADC69RpMGUG4s XeJGteOs4cQM1sIY4nKNST8047oRH6rh/Vg0l3IevGnmruj6fCMF/IBddN9H1ou0+9fS B8mz6uxOUbI+KXctJPP4LCLOIH17gM3yy4t2D/dvzlTb10+ou1NxJKuMN7eZnKMwc+aM Sc6SbsTp9gLbcuZXJyoo8ed9BuU5a21Trhd1tlBEkIDa8TmD7GXhxXvGcDtanYfUdYnu A46g== X-Gm-Message-State: AOJu0YxinjK52gmPpyk+LXvLIsW5Ct7aKqyqRe2c+pd38gQUoNy7iO7i dS6KUxDvUcHK8GL1ov6cLJfpi9aNbsSXJWhqYcNarI5m4vsuTC1E2yHAJA== X-Received: by 2002:a5d:4491:0:b0:367:9754:810c with SMTP id ffacd0b85a97d-367cea965b9mr501377f8f.38.1720472972099; Mon, 08 Jul 2024 14:09:32 -0700 (PDT) Received: from localhost.localdomain (109-93-166-140.dynamic.isp.telekom.rs. [109.93.166.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cdfa079asm684977f8f.68.2024.07.08.14.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 14:09:31 -0700 (PDT) From: Ilia Shipitsin To: openvpn-devel@lists.sourceforge.net Date: Mon, 8 Jul 2024 23:08:19 +0200 Message-ID: <20240708210912.566-3-chipitsine@gmail.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20240708210912.566-1-chipitsine@gmail.com> References: <20240708210912.566-1-chipitsine@gmail.com> MIME-Version: 1.0 X-Spam-Score: -5.2 (-----) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Signed-off-by: Ilia Shipitsin --- sample/sample-plugins/defer/multi-auth.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/sample/sample-plugins/defer/multi-auth.c b/sample/sample-plugins/defer/multi-auth.c index 2c482799..109fa40c 100644 --- a/sample/sample-plugins/defer/multi-auth.c +++ b/sample/sample-plug [...] Content analysis details: (-5.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [chipitsine[at]gmail.com] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [209.85.221.51 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.51 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.51 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.51 listed in wl.mailspike.net] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-Headers-End: 1sQvcO-0000SH-Vx Subject: [Openvpn-devel] [PATCH 2/5] sample/sample-plugins/defer/multi-auth.c: handle strdup errors X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1804046718438547059?= X-GMAIL-MSGID: =?utf-8?q?1804046718438547059?= Signed-off-by: Ilia Shipitsin Acked-by: Frank Lichtenheld --- sample/sample-plugins/defer/multi-auth.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/sample/sample-plugins/defer/multi-auth.c b/sample/sample-plugins/defer/multi-auth.c index 2c482799..109fa40c 100644 --- a/sample/sample-plugins/defer/multi-auth.c +++ b/sample/sample-plugins/defer/multi-auth.c @@ -206,9 +206,24 @@ openvpn_plugin_open_v3(const int v3structver, if ((args->argv[4]) && !args->argv[5]) { context->authid = strdup(args->argv[1]); + if (!context->authid) + { + plog(context, PLOG_ERR, "Out of memory"); + goto error; + } context->test_deferred_auth = atoi_null0(args->argv[2]); context->test_valid_user = strdup(args->argv[3]); + if (!context->test_valid_user) + { + plog(context, PLOG_ERR, "Out of memory"); + goto error; + } context->test_valid_pass = strdup(args->argv[4]); + if (!context->test_valid_pass) + { + plog(context, PLOG_ERR, "Out of memory"); + goto error; + } } else {