diff mbox series

[Openvpn-devel,v1] Add Ubuntu 24.04 runner to Github Actions

Message ID 20240719131141.75324-1-frank@lichtenheld.com
State Accepted
Headers
Series [Openvpn-devel,v1] Add Ubuntu 24.04 runner to Github Actions |

Commit Message

Frank Lichtenheld July 19, 2024, 1:11 p.m. UTC 
  From: Arne Schwabe <arne@rfc2549.org>

Change-Id: I44b9003143fdad90bfff7b2c86d0bb503f9157de
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/676
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <frank@lichtenheld.com>

Comments

Gert Doering July 22, 2024, 5:45 p.m. UTC | #1 
Your patch has been applied to the master branch.

I tried to apply it to release/2.6 as well, but the mbedtls builds 
fail (on 24.04) with error messages like this:

crypto_backend.h:352:6: note: previous declaration of `cipher_ctx_init' with type `void(cipher_ctx_t *, const uint8_t *, const char *, int)' {aka `void(mbedtls_cipher_context_t *, const unsigned char *, const char *, int)'}

so it seems we need some mbedtls compat backport first, or stop building
2.6 + 24.04 + mbedtls.

Details: https://github.com/cron2/openvpn/actions/runs/10041826490/job/27750800767

(looking more closely, 24.04 + ossl 3 fails as well, with
"configure: error: PKCS11 enabled but libpkcs11-helper is missing")

commit 856065b2eb37286c389550593472bf180bc5be9d (master)
Author: Arne Schwabe
Date:   Fri Jul 19 15:11:41 2024 +0200

     Add Ubuntu 24.04 runner to Github Actions

     Signed-off-by: Arne Schwabe <arne@rfc2549.org>
     Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
     Message-Id: <20240719131141.75324-1-frank@lichtenheld.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28942.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index d7c3ecd..6e361d5 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -106,7 +106,7 @@ 
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-20.04, ubuntu-22.04]
+        os: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04]
         sslpkg: [libmbedtls-dev]
         ssllib: [mbedtls]
         libname: [mbed TLS]
@@ -122,6 +122,12 @@ 
             ssllib: openssl
             pkcs11pkg: "libpkcs11-helper1-dev softhsm2 gnutls-bin"
             extraconf: --enable-pkcs11
+          - os: ubuntu-24.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 3.0.13
+            ssllib: openssl
+            pkcs11pkg: "libpkcs11-helper1-dev softhsm2 gnutls-bin"
+            extraconf: --enable-pkcs11
           - os: ubuntu-20.04
             sslpkg: "libssl-dev"
             libname: OpenSSL 1.1.1
@@ -173,7 +179,7 @@ 
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-20.04]
+        os: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04]
         ssllib: [mbedtls, openssl]
 
     name: "clang-asan - ${{matrix.os}} - ${{matrix.ssllib}}"