From patchwork Mon Aug 12 23:21:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selva Nair X-Patchwork-Id: 3784 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:63cf:b0:5a1:d4fc:4ac6 with SMTP id j15csp1433282mag; Mon, 12 Aug 2024 16:23:12 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUUVmMQf4jqV74P/cBeQMQ9r9/EsP4D6SzVt/UeOW0IUf7yvBjmnIAjpbuZlaB3CDu5u/TZWfS2e/E=@openvpn.net X-Google-Smtp-Source: AGHT+IGLWE33a/0RLHe5+idSaPOAx9+/Xuq4djeDsinsTrupwIXlQv5MQn106ebbwZUIH6UFZt75 X-Received: by 2002:a05:6870:5590:b0:26c:641a:871c with SMTP id 586e51a60fabf-26fd1badf53mr314614fac.9.1723504992110; Mon, 12 Aug 2024 16:23:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1723504992; cv=none; d=google.com; s=arc-20160816; b=SI5dcrn+h4wFgKana0CMhC9kuOz78CLufTL41ACRQBH0f1eGNNpQ8CfgQf6Wq3k3gC cLWKRRyCUI9oPQUAB+Y8Wn9Fhc9n/njLtE+bjDbMX7U8cBYgcG/nI+yoseXs9P7SWrqe nH9JXL3RuztBvOzaDNqvaIhq7aDj11tlWnoI/H43vpJZDcyhVb02ZMV+r/Pja3IG5MOT AtlVKjGwYSajoVdZqd1wspBGkH3RGaglwPzUQnAAoKXjumt268aOsQk9Xb7LyfR5zU2N jOQdBwdr6VawXTQe1v5vSWNMzY0x2MFaUF+T/5fhspiU3hj9LyrKhB8mw3tDGsrsAt5m FiWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature; bh=+tE7nsePcmbm2l9rVcvecbxzE/rL9gV6s1Q/lg6tGMc=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=EyV7ruk0bxFAhqy2oF5lZuH2+x+5/Q0WSeaNGscCFtgNTIHBueR6/PpOOYTC0Z4iaf igNcFobYLwsRGkaQCkC2hZ85e6ftYq9Qd3lXZOpbQON+ApJml9zysdBKLQqIQTMPWsyq O31TURaXP7o0WbXt6+OzvZc1VgaNXc3vUtKtqvKBdE0z39vtuN9glDvAMZ5LOz0hXrEm uOpP8ovUi/2W0jQXXA3xEtvJGzL8RM0aN1QNfXVmYj6hymIJADQB3w/lFuYDEAWX7iP/ C2/sAvGy+WW7/GVMsr2nNhubqX25FfZxGYbh93Wmnfka2O2SFU3v1LwPNI4+QW752y8F KkJw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=PpVNaXAN; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=fofv6KKT; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=d3+wsyOK; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 41be03b00d2f7-7c697aecca6si391664a12.847.2024.08.12.16.23.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Aug 2024 16:23:12 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=PpVNaXAN; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=fofv6KKT; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=d3+wsyOK; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sdeMz-0004cH-A7; Mon, 12 Aug 2024 23:22:33 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sdeMx-0004c3-RL for openvpn-devel@lists.sourceforge.net; Mon, 12 Aug 2024 23:22:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pSQvlOUHcIoAlZ1rqZwhlzGlMFDsUiVASBmidLfe+W0=; b=PpVNaXANOQdQvXVUsyroqv8YRj FQ+B3EhUTTsoDtKZH6kr7a2JWQ1tpEYZ6txkJ1ivjGbfycjEJ2aMWaa8ju3jOC8jVli9zHbtZCvDQ zbctQq6rCyhDjByjAbQFQLsyVxQwqzf/yDPYAbLUgGMAWOzsw3rSUE6onVF6ocJSJ3P0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=pSQvlOUHcIoAlZ1rqZwhlzGlMFDsUiVASBmidLfe+W0=; b=f ofv6KKT7QiieTywejjpBICQT3GQTi6wFk6P6I/dgVHrcNGNk6qpxk64P+g8ziqDN9ffX+n9zEkCNN hFxGHkQmwpv4vXeGjSfOZ2GfASD/cua1yLfVWSHhxBETDOXxNIqaW5BY2dCTP34blf08v9AmtyAi+ i/LECW8JXTFGgykE=; Received: from mail-il1-f172.google.com ([209.85.166.172]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sdeMx-0008PT-8g for openvpn-devel@lists.sourceforge.net; Mon, 12 Aug 2024 23:22:31 +0000 Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-39b0826297bso1637105ab.2 for ; Mon, 12 Aug 2024 16:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723504940; x=1724109740; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pSQvlOUHcIoAlZ1rqZwhlzGlMFDsUiVASBmidLfe+W0=; b=d3+wsyOKcUAb1tTaE5HnieI4B1OyYZisyzKoyjIZgrj4vIm0TYrEvitDB6Dxk/2jrK ggAfNlQOK2PKA6oZ+o1PCEM+LJey18ccQCFZB3FgRVcXD0zThCcWgNpPENGoib+7UsLo AvYVZ5QIJ+Pt0iHiQ9Nk1ep4qT+xdmAPWZtA+vIhdCtz63uc1VllD+i4Xcpag2eAAjxj WyxZP4tXmIEuzpM1OpEe6ZS5HnLwxQS98eRjIf3rwVIWORCVS+XhLnYqgsYU1/s3ChbD ydycQw70LogaZnvZrTe8DMvfYA/mn+cTJqGKXlhnFxnUKFPthDT6QC+ZTDQzXi6Hu5Lw HIqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723504940; x=1724109740; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pSQvlOUHcIoAlZ1rqZwhlzGlMFDsUiVASBmidLfe+W0=; b=DQ8Vg6obxmdi2LEK+P9ffEtnC+rhaZyZxv6Wxy0Rjd+X8qZ/MeEoRIuSboq8qCRG3z GAHt7RI3l8KB4IWDVIceD0v4X7+8uOK87ABTRRKwFS3OQEPylDM759reaS4h/w0FGcze +l+rD2E3Kkq/3mAI3Qd38WP9437tZGVd6i+XLQ2As3PBguNLef8KEBQHV/7awgT22UTs KpjsxYzJdvNyUdEUajlRCwqaKSzwa2xMTF+AJFOauWrrfrJBTTpZPCmjjdlzzBQYTeTs hyCLheNV7csIeQmTPMdlOfF6AEmbO3UzG1JyytYk6P9UxQFJBlqBmkmB6mXdlwLCqriP 2OFQ== X-Gm-Message-State: AOJu0YwqF+J/vRbSlvoRKmfKnzGNP8PdkU+JpMT79XZHL+owrz+AMo7A RNRYJpgVhrj0D2zl0MVr9w31BdJmoCzzZEDFrtAlLHIzMAyDUPkqTbdhCg== X-Received: by 2002:a05:6e02:12ef:b0:39a:ef62:4e96 with SMTP id e9e14a558f8ab-39c4a7dd601mr4518265ab.4.1723504940248; Mon, 12 Aug 2024 16:22:20 -0700 (PDT) Received: from uranus.sansel.ca (bras-base-tnhlon4053w-grc-07-70-48-195-99.dsl.bell.ca. [70.48.195.99]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ca76940853sm1885053173.42.2024.08.12.16.22.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Aug 2024 16:22:19 -0700 (PDT) From: selva.nair@gmail.com To: openvpn-devel@lists.sourceforge.net Date: Mon, 12 Aug 2024 19:21:58 -0400 Message-Id: <20240812232158.3776869-1-selva.nair@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Score: -5.2 (-----) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Selva Nair Currently key and cert file fd's are reused after ftruncate() without setting the offset to zero. This causes subsequent data to be written at some finite offset with the hole in the file automaticall [...] Content analysis details: (-5.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [209.85.166.172 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [selva.nair[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.166.172 listed in wl.mailspike.net] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1sdeMx-0008PT-8g Subject: [Openvpn-devel] [PATCH] test_pkcs11.c: set file offset to 0 after ftruncate X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1807225970743822511?= X-GMAIL-MSGID: =?utf-8?q?1807225970743822511?= From: Selva Nair Currently key and cert file fd's are reused after ftruncate() without setting the offset to zero. This causes subsequent data to be written at some finite offset with the hole in the file automatically filled by zeros. Fix it by calling lseek() to set the offset to zero. The test works nevertheless because p11tool seem to generously ignore any junk before the "BEGIN" marker. Change-Id: Ib0fe15a4ba18d89216b0288e6cd6be66ed377bd4 Signed-off-by: Selva Nair Acked-by: Gert Doering --- tests/unit_tests/openvpn/test_pkcs11.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/unit_tests/openvpn/test_pkcs11.c b/tests/unit_tests/openvpn/test_pkcs11.c index 5518fa15..3fe3e460 100644 --- a/tests/unit_tests/openvpn/test_pkcs11.c +++ b/tests/unit_tests/openvpn/test_pkcs11.c @@ -273,6 +273,8 @@ init(void **state) assert_int_equal(ftruncate(cert_fd, 0), 0); assert_int_equal(ftruncate(key_fd, 0), 0); + assert_int_equal(lseek(cert_fd, 0, SEEK_SET), 0); + assert_int_equal(lseek(key_fd, 0, SEEK_SET), 0); num_certs++; }