[Openvpn-devel,v1] GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1

Message ID 20240911144231.32553-1-gert@greenie.muc.de
State Superseded
Headers show
Series [Openvpn-devel,v1] GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1 | expand

Commit Message

Gert Doering Sept. 11, 2024, 2:42 p.m. UTC
From: Frank Lichtenheld <frank@lichtenheld.com>

Requires submodule checkout.

Change-Id: I86ceceb4e1c716b33c6c6ec8853eca0fb4b394f1
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/741
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Arne Schwabe <arne-openvpn@rfc2549.org>

Comments

Gert Doering Sept. 11, 2024, 2:58 p.m. UTC | #1
GHA says "this builds fine", and so we apply it :-)

(And the worries that 3.6.x would break with TLS 1.3 due to missing
key-exporter are alleviated by our mbedtls builds disabling 1.3 anyway,
due to missing key-exporter...)

Your patch has been applied to the master branch.

commit f4d7cec855aea3c453b75fe68a1c151400793661
Author: Frank Lichtenheld
Date:   Wed Sep 11 16:42:31 2024 +0200

     GHA: Update dependency Mbed-TLS/mbedtls to v3.6.1

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
     Message-Id: <20240911144231.32553-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29208.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 6207c95..8f0a7b5 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -404,9 +404,10 @@ 
         uses: actions/checkout@v4
         with:
           path: mbedtls
+          submodules: true
           # versioning=semver-coerced
           repository: Mbed-TLS/mbedtls
-          ref: v3.5.2
+          ref: v3.6.1
       - name: "mbedtls: make no_test"
         run: make -j3 no_test SHARED=1
         working-directory: mbedtls