[Openvpn-devel,v1] GHA: Enable t_server_null tests

Message ID 20240912174910.21058-1-gert@greenie.muc.de
State Accepted
Headers show
Series [Openvpn-devel,v1] GHA: Enable t_server_null tests | expand

Commit Message

Gert Doering Sept. 12, 2024, 5:49 p.m. UTC
From: Frank Lichtenheld <frank@lichtenheld.com>

Change-Id: I86203b8f9a6d3cfc5e56d3ce9452af694fd11011
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/743
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Comments

Gert Doering Sept. 12, 2024, 6:48 p.m. UTC | #1
"GHA says this works".  So let's excercise it a bit more :-)

Your patch has been applied to the master branch.

commit 65985905c5abc69c1ee34c4cab6fdf8b73da7f50
Author: Frank Lichtenheld
Date:   Thu Sep 12 19:49:10 2024 +0200

     GHA: Enable t_server_null tests

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20240912174910.21058-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29231.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 8f0a7b5..361d457 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -172,8 +172,11 @@ 
         run: ./configure --with-crypto-library=${{matrix.ssllib}} ${{matrix.extraconf}} --enable-werror
       - name: make all
         run: make -j3
+      - name: configure checks
+        if: ${{ matrix.extraconf != '--disable-management' }}
+        run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc
       - name: make check
-        run: make check VERBOSE=1
+        run: make -j3 check VERBOSE=1
 
   ubuntu-clang-asan:
     strategy:
@@ -199,8 +202,10 @@ 
         run: CFLAGS="-fsanitize=address,undefined -fno-sanitize-recover=all  -fno-omit-frame-pointer -O2" CC=clang ./configure --with-crypto-library=${{matrix.ssllib}} --enable-werror
       - name: make all
         run: make -j3
+      - name: configure checks
+        run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc
       - name: make check
-        run: make check VERBOSE=1
+        run: make -j3 check VERBOSE=1
 
   macos:
     strategy:
@@ -258,8 +263,10 @@ 
         run: ./configure --enable-werror ${{matrix.configureflags}} ${{matrix.configuressllib}}
       - name: make all
         run: make -j4
+      - name: configure checks
+        run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc
       - name: make check
-        run: make check VERBOSE=1
+        run: make -j4 check VERBOSE=1
 
   msvc:
       strategy:
@@ -369,8 +376,10 @@ 
         run: ./configure --with-crypto-library=openssl ${{matrix.configureflags}} --enable-werror
       - name: make all
         run: make -j3
+      - name: configure checks
+        run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc
       - name: make check
-        run: make check VERBOSE=1
+        run: make -j3 check VERBOSE=1
 
   mbedtls3:
     strategy:
@@ -422,5 +431,7 @@ 
         run: ./configure --with-crypto-library=mbedtls
       - name: make all
         run: make -j3
+      - name: configure checks
+        run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc
       - name: make check
-        run: make check VERBOSE=1
+        run: make -j3 check VERBOSE=1