From patchwork Wed Sep 18 20:45:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 3845 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6794:b0:5b9:581e:f939 with SMTP id c20csp968573mao; Wed, 18 Sep 2024 13:46:22 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUnCv3TSocqxUigQ7te4kOLJs9Tuo090wIVDLkmTpj93yst0sok0an860CdVwEK3HOlHWdVt0xzsJU=@openvpn.net X-Google-Smtp-Source: AGHT+IF8vMwmQ9fI0npztc4UHpooKg9HDdU4+OX9r6nm4iK0TTrd/a6E5nfNbfeBblvKMFUSIqK/ X-Received: by 2002:a05:6602:601b:b0:82c:edd4:f0a6 with SMTP id ca18e2360f4ac-82d1f984d79mr2454455839f.12.1726692382710; Wed, 18 Sep 2024 13:46:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726692382; cv=none; d=google.com; s=arc-20240605; b=O5pidJFKzH7O4BQCRB/fKSg4xxzeUJRfV/qe7MjpG7jvL8+6R8UbZUZ4QRiFJRLVHn mBB5A1LCd/FvDwmYevC/YotIYfeYBiKpl8NhtSB3/3ZXOsi5ul6pZBWmzMmMhVmrfO3F z4U5Y2STVn5j30lJP4heauo3gLbVdqVh+nHxQqnghlNaW8UgyrK9rzcay3fmvMGzOfc2 M9tvxHgOKMqdmAKdt9JvmiMNFu5hgnmxHQ8IyciM5fqQ+YCJjzHLAuEYrCrpcL6UV1Rx eMerXrWJWAKPrwVdVxt1Ul+1GmwV8xMRNiQ6NdNLWwtH30XLBcO3OMit6qobAz8i89dk m6Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature; bh=KZZAPwHkh/We8if4OVTs/YR2Uu+BFFj90qrBiqn5fu0=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=QG48i8qxhoJQKOsMsnouu3JYPE7ccGn6il1MKGrSyU8lxK1p09HtDxs9mLHAvhWDc/ yzbAaS2amh9U7aBg8KSKAV0qiNxZQF8NiDeqLL7LjFlPoyfgRIavTQPOTSwKP1NmnKRD RmhR78VaQSX5I6LPM8QJ1cRDIhYiD2Ewgow8503sd/IoTbX/dN8RfqoavGUYUaVdY59R vDYDOexLFSlGqBFV+X1lUkyIJjWf1WJz4EQCMNnjWlWC3nFT6LOMr4jiwW3WYO/CHE7+ hGTzfY2P/MITmPzKD0T5ZRaQTA/TBj6dbZPR/rxJMfeLlgFEpmstlocYfcnsqbBgtReC kXfA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Tpd3zmdl; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=CW9BYHT1; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id ca18e2360f4ac-82d4932f52csi473982339f.98.2024.09.18.13.46.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Sep 2024 13:46:22 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Tpd3zmdl; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=CW9BYHT1; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sr1Z4-0004IS-9v; Wed, 18 Sep 2024 20:46:19 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sr1Z1-0004IC-Rr for openvpn-devel@lists.sourceforge.net; Wed, 18 Sep 2024 20:46:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iYpNnIOV9v6NpuUNoIU4MxyFmjgoDcJc6W1Vz//hjxg=; b=Tpd3zmdlUDvuQgGrlZexMFDcS4 GfI5ObyLhabA4A52HLdY4ShPkEoSyOmeMihoioeYyhy34emH5b4sLk/gQAHa4eQuEmYcRKdBbIzKn mP2eggm9tbJxDs/lRgwAPqcF8OpMNurc4sbr66g8jNjVIuIExKyN2AHpK/M569RkO4Yg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iYpNnIOV9v6NpuUNoIU4MxyFmjgoDcJc6W1Vz//hjxg=; b=CW9BYHT1hxiWYzTOfa6qI1cd7h 3tIQQVPBYgywZNpInRqa8DQmiaHQ84F8Pgh7Z/WT0yyIc8Q3IRnUCe0QN/hEOepEHoPuzqFuh4Qfc L/nOyf7IrrSldQNtE24O/9I4rWFgJwtSn1CgLBFcbWbTfuJL0lrlOY7gPTGiaX4Jqf5A=; Received: from dhcp-174.greenie.muc.de ([193.149.48.174] helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1sr1Yp-0000wu-Qs for openvpn-devel@lists.sourceforge.net; Wed, 18 Sep 2024 20:46:07 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 48IKjps1002540 for ; Wed, 18 Sep 2024 22:45:51 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 48IKjpeF002539 for openvpn-devel@lists.sourceforge.net; Wed, 18 Sep 2024 22:45:51 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 18 Sep 2024 22:45:50 +0200 Message-ID: <20240918204551.2530-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.44.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: -0.0 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld - Increase required version to 2.60 since that is documented minimum version for AC_USE_SYSTEM_EXTENSIONS - Remove obsolete macros AC_C_CONST and AC_C_VOLATILE. They are noops on every compiler we sup [...] Content analysis details: (-0.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record X-Headers-End: 1sr1Yp-0000wu-Qs Subject: [Openvpn-devel] [PATCH v3] configure: Review use of standard AC macros X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1810568191373677514?= X-GMAIL-MSGID: =?utf-8?q?1810568191373677514?= From: Frank Lichtenheld - Increase required version to 2.60 since that is documented minimum version for AC_USE_SYSTEM_EXTENSIONS - Remove obsolete macros AC_C_CONST and AC_C_VOLATILE. They are noops on every compiler we support. - Add explicit call to AC_PROG_CC. We get this implictly as dependency of other macros, but it is nicer to have it explicitely as well. - A few typo and whitespace fixes. Change-Id: I7927a572611b7c1dc0b522fd6cdf05fd222a852d Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/674 This mail reflects revision 3 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/configure.ac b/configure.ac index 9ce826c..18538c5 100644 --- a/configure.ac +++ b/configure.ac @@ -23,7 +23,7 @@ dnl Process this file with autoconf to produce a configure script. -AC_PREREQ(2.59) +AC_PREREQ(2.60) m4_include(version.m4) AC_INIT([PRODUCT_NAME], [PRODUCT_VERSION], [PRODUCT_BUGREPORT], [PRODUCT_TARNAME]) @@ -387,6 +387,7 @@ pkg_config_found="(${PKG_CONFIG})" fi +AC_PROG_CC AC_PROG_CPP AC_PROG_INSTALL AC_PROG_LN_S @@ -443,9 +444,7 @@ ] ) -AC_C_CONST AC_C_INLINE -AC_C_VOLATILE AC_TYPE_OFF_T AC_TYPE_PID_T AC_TYPE_SIZE_T @@ -981,7 +980,7 @@ [AC_MSG_ERROR([OpenSSL check for AES-256-GCM support failed])] ) - # All supported OpenSSL version (>= 1.1.0) + # All supported OpenSSL versions (>= 1.1.0) # have this feature have_export_keying_material="yes" @@ -1081,9 +1080,8 @@ elif test "${with_crypto_library}" = "wolfssl"; then AC_ARG_VAR([WOLFSSL_CFLAGS], [C compiler flags for wolfssl. The include directory should - contain the regular wolfSSL header files but also the - wolfSSL OpenSSL header files. Ex: -I/usr/local/include - -I/usr/local/include/wolfssl]) + contain the regular wolfSSL header files but also the wolfSSL OpenSSL header files. + Ex: -I/usr/local/include -I/usr/local/include/wolfssl]) AC_ARG_VAR([WOLFSSL_LIBS], [linker flags for wolfssl]) saved_CFLAGS="${CFLAGS}" @@ -1274,7 +1272,7 @@ [PKG_CHECK_MODULES([libsystemd], [libsystemd-daemon])] ) - PKG_CHECK_EXISTS( [libsystemd > 216], + PKG_CHECK_EXISTS([libsystemd > 216], [AC_DEFINE([SYSTEMD_NEWER_THAN_216], [1], [systemd is newer than v216])] )