From patchwork Mon Dec 9 19:49:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 3980 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:1d8b:b0:5dc:2311:f747 with SMTP id hp11csp2855465mab; Mon, 9 Dec 2024 11:50:25 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXtVTLwH18lkZy0avXEADD1c12Iq4RsxVP1Beo7f8FLeOUbF3RpujOf8j4WmEiUaHZcLbXU0jPcOCg=@openvpn.net X-Google-Smtp-Source: AGHT+IGt+NIxHMZK7YSe2VRHrq/GzWsVrjBFkQV/ogSh8c+e0SbmAPu2dbq95RReouZQoSuRX2hu X-Received: by 2002:a05:6870:d108:b0:29e:4a6c:4010 with SMTP id 586e51a60fabf-29fee507367mr1220401fac.6.1733773825149; Mon, 09 Dec 2024 11:50:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1733773825; cv=none; d=google.com; s=arc-20240605; b=WmY/akjRb8DZsGbk7anCr1ka5hA0z3/aEHMCdw5L3u1kF8xZI5E+JOkLWdUmNYsvy+ 6y2rN2/JJX7RYu+HUTsYxptZROyscMQJHx1j/HessqgzjatAShilxYhmYRa1U3qRhsmD Ss72GKN4tZvM1Z0NcGOEGG7L/H5kZCeiNUxG1t/xt79gmdE76UjrGXF+Kcem/6w8jtWb yM/foDGVwF0CnFV7b59v/m+q3EslOeF9/W2ER19VF1nVbHrTj725feXK2ai31QzXr0Ju gg0YDZ5GAsQNSC8OBEKLFmdjbkGpSsPl/+KL5mYc/YOy09iPa8t4GZuxLEwqRay/hspe LVMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature; bh=DcL7omymZ8+NiLzzZN+9h42DhNMPoudVOkldIiGr/Pw=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=eWdeJDlDtWLuzsJRcCG/xMjCBPtECcbAs8wmNO5bZmjwAZTtg9L+ulafvKzIAH3gzI TJjUsvQ6EGC2zXdCHijxYBmf3QNdBxkR60IDrE23NbuZBHs05q19g+rrRxQ1PbwqXHPu /uaMRQjs83zmqPQIrZDwTPilTjLwB48mCZ+D9BJE/03UlFiE/fNOJtR25nZY2x8uWYaL CjUbtTwRVn0IaU7NBgu/Jo7FFwBC78zUAtrEhTHzPRuU5neGv9Ej9GiYgbbkVnVpawxE RzF8g10ICmVQwgz1dGFoFcwLJclOuKBpE4fNWWWDj2fdzG9uxjxkHQ8uTonzX5ZkHYvV 6x7w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Rm63BuQo; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=kHSRubxg; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 006d021491bc7-5f2cc4e82ccsi14038eaf.71.2024.12.09.11.50.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Dec 2024 11:50:24 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Rm63BuQo; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=kHSRubxg; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tKjlq-0005y5-15; Mon, 09 Dec 2024 19:50:18 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tKjlk-0005xb-LK for openvpn-devel@lists.sourceforge.net; Mon, 09 Dec 2024 19:50:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ltGB88/JOL5gi91lXU83G9nMycz0MYZPCQGM4aAAgrw=; b=Rm63BuQo+baoxL8TkNxtxxLhQ/ iyBXcrp7ZCODN5rRvKmf5o965CczeIa/iZSNVJyx1VEZF1w7qCHFhjgz1RzfTW5GMYD8hRhyPw9ha NSnh4Gs/v+Iw1Odjk7XKwOv2KK/CRAqbBqUPcrj9faoSDufa2rImg1DsnpXQrc1/277Y=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ltGB88/JOL5gi91lXU83G9nMycz0MYZPCQGM4aAAgrw=; b=kHSRubxgnerduvSEY3axAaFJZP MlmMJPabo/Pzdzz2dqNK956U8c7vEtW8DmXdvG+WN7TOwb6m58eRx70ZY2kkqC1obncxbNmLiu3bf 0uauMjx2xX6sftJI4aEFiusW6EzGBwSbk2VGhi9S1nEslXVxqlMTQNfV2FY1mHJO66D0=; Received: from dhcp-174.greenie.muc.de ([193.149.48.174] helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1tKjli-0007Qm-K2 for openvpn-devel@lists.sourceforge.net; Mon, 09 Dec 2024 19:50:12 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 4B9Jnwn7000368 for ; Mon, 9 Dec 2024 20:49:58 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 4B9Jnw6S000367 for openvpn-devel@lists.sourceforge.net; Mon, 9 Dec 2024 20:49:58 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 9 Dec 2024 20:49:57 +0100 Message-ID: <20241209194957.358-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Not really important but prevents running the NTLM t_client tests with ASAN enabled. Change-Id: If472398d4ff8323de485f084a07160b365dfc501 Signed-off-by: Frank Lichtenheld Acked-by: Lev Stipakov --- Content analysis details: (0.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record X-Headers-End: 1tKjli-0007Qm-K2 Subject: [Openvpn-devel] [PATCH v1] Fix memory leak in ntlm_support X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1817993622453126643?= X-GMAIL-MSGID: =?utf-8?q?1817993622453126643?= From: Frank Lichtenheld Not really important but prevents running the NTLM t_client tests with ASAN enabled. Change-Id: If472398d4ff8323de485f084a07160b365dfc501 Signed-off-by: Frank Lichtenheld Acked-by: Lev Stipakov --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/826 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Lev Stipakov diff --git a/tests/ntlm_support.c b/tests/ntlm_support.c index ccf8962..18d555a 100644 --- a/tests/ntlm_support.c +++ b/tests/ntlm_support.c @@ -33,11 +33,11 @@ int main(void) { -#if defined(ENABLE_CRYPTO_OPENSSL) - crypto_load_provider("legacy"); - crypto_load_provider("default"); -#endif #ifdef NTLM +#if defined(ENABLE_CRYPTO_OPENSSL) + provider_t *legacy = crypto_load_provider("legacy"); + provider_t *def = crypto_load_provider("default"); +#endif if (!md_valid("MD4")) { msg(M_FATAL, "MD4 not supported"); @@ -46,6 +46,10 @@ { msg(M_FATAL, "MD5 not supported"); } +#if defined(ENABLE_CRYPTO_OPENSSL) + crypto_unload_provider("legacy", legacy); + crypto_unload_provider("default", def); +#endif #else /* ifdef NTLM */ msg(M_FATAL, "NTLM support not compiled in"); #endif