From patchwork Sat Jan 25 10:08:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4080 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:c127:b0:5e7:b9eb:58e8 with SMTP id jm39csp1310023mab; Sat, 25 Jan 2025 02:08:56 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCW9Pa0feu8hih5UGMEz1TjfZammhoasS2m9EPy+H4O9arTjqEJu/EVu95vAKlxFn96kw+qLZS0BTSE=@openvpn.net X-Google-Smtp-Source: AGHT+IHwbxxrRfEa0I2jrJtQCr3JPvluuS014ggWFkKsobZmocyvNR6XXwtuBaQqgpN/gaUQ9f21 X-Received: by 2002:a05:6830:658d:b0:718:7c3:f86a with SMTP id 46e09a7af769-7249da59b55mr19474261a34.6.1737799736158; Sat, 25 Jan 2025 02:08:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1737799736; cv=none; d=google.com; s=arc-20240605; b=EBhIJbjtcn6UNI+ivvWd+WYbxG863wCSaJA30y3fXksoY9EY0jia8Y9mQFvMukl2i2 Ev1wdNbkdUiL9zpNptMu/6YwjtitQBAM3uz0wdnK17hSK0EmN/lAaqHK043Sal6yZ2fZ N7UCA6dfxrxIEf8L4s77J4L2SDY6Dp+xapTDdvbgoMbWEPu6yYVH6/59vlZLrsevApDo y/bEZI9c1Hd5MD225FcEvuzA/xbzrcOGTMWWCzcbTZOHK6XZ8Mh1ZS4JvIjtrHGui8T1 YnFcxToL1DJyztc6ffwOJtwOfDf8EJuCJ98KFNqrBRb1MyYfozH0fYAYIXLi+uzY02ko c72A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature; bh=6L5BNv338LxIHmwqAi33I1bWZYvyxyDMOaZW5rFeWr0=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=k7EFw6z9zhW2se8xkKp8lIDnU55cTTP0WGUZ43neNScpcHnMR1aKcjXRT2c60MUdH3 BnushU+cwU16r3G6EmXKg8BdF5dXZtf5VJBQ82doV+Uc5c/YyWeicd02iUHwaPKaT5q4 /7LlKkifZPHkPs73teNwu1DICfpPmrxQtKX5AGqiyQDKcno0J10tDxXxNhbdSxvblH28 tzoqJRxdRY3HyUPg3QAGlmIrqBdXAPmredzNaxjQqOWGmxbndh7CgdRuCrgEklhiKdwl 7Ust31mOYdjnBU9XwZdVzAYuEwXUmGmbvd1heg0JTUwmx3Tq57MBuxMurq5+JZDwFi0k p/lA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Lp+B8MwY; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=It+FjdcF; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-724ecda4829si3301035a34.36.2025.01.25.02.08.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 25 Jan 2025 02:08:56 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Lp+B8MwY; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=It+FjdcF; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tbd5w-0008QO-RR; Sat, 25 Jan 2025 10:08:52 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tbd5v-0008QH-43 for openvpn-devel@lists.sourceforge.net; Sat, 25 Jan 2025 10:08:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iOCL5MqBg4V9jMDT9xPqVhBdvtrjGhZYo3IUBffiwMM=; b=Lp+B8MwYBlaJMjgJNWgCdykZ/U GagAeQ4E1njHaICmRdq5xQbhcvAbquJ589ZyGy0d/l+WFZyk+y0AyKZiETgFS9YVWYF6/fGBvXAyQ /B+tkyF2KeZfpx6WXfDRKQjRFBrUDM7OKqV3CKbu0ZzJ8mm/CTyu3yVyLmy5IdV8Q0/0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iOCL5MqBg4V9jMDT9xPqVhBdvtrjGhZYo3IUBffiwMM=; b=It+FjdcFVJydA7hwJ53gwRIbkg AAh4vEJj8h0ieKGVNCaHTpaYAaWz2Agv5MBrKVDKTt8yngE7LT8UX6HUznr7dRq0lvsQkQ841KIY8 /Bora7YsT+Noit/f5vjpDN9ItzwoAtgzG5siBDF8mfd3pw4HIrNiaLdbmHCha1KhUF1A=; Received: from dhcp-174.greenie.muc.de ([193.149.48.174] helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1tbd5u-0004lc-5y for openvpn-devel@lists.sourceforge.net; Sat, 25 Jan 2025 10:08:51 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 50PA8cp9020816 for ; Sat, 25 Jan 2025 11:08:38 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 50PA8cqv020815 for openvpn-devel@lists.sourceforge.net; Sat, 25 Jan 2025 11:08:38 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sat, 25 Jan 2025 11:08:38 +0100 Message-ID: <20250125100838.20796-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: -0.0 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld GCC wants us to be more explicit here. Change-Id: Iaaf80c688ddff79ac9472d7237003713637c140b Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- Content analysis details: (-0.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in sa-trusted.bondedsender.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in bl.score.senderscore.com] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1tbd5u-0004lc-5y Subject: [Openvpn-devel] [PATCH v2] tls_crypt_v2_write_client_key_file: Fix missing-field-initializers compiler warning X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1822215095816537824?= X-GMAIL-MSGID: =?utf-8?q?1822215095816537824?= From: Frank Lichtenheld GCC wants us to be more explicit here. Change-Id: Iaaf80c688ddff79ac9472d7237003713637c140b Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/867 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/tls_crypt.c b/src/openvpn/tls_crypt.c index 24df930..4c421aa 100644 --- a/src/openvpn/tls_crypt.c +++ b/src/openvpn/tls_crypt.c @@ -691,7 +691,7 @@ struct buffer client_key_pem = { 0 }; struct buffer dst = alloc_buf_gc(TLS_CRYPT_V2_CLIENT_KEY_LEN + TLS_CRYPT_V2_MAX_WKC_LEN, &gc); - struct key2 client_key = { 2 }; + struct key2 client_key = { .n = 2 }; if (!rand_bytes((void *)client_key.keys, sizeof(client_key.keys))) {