From patchwork Mon Jan 27 23:54:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shubham Mittal X-Patchwork-Id: 4088 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6a49:b0:5e7:b9eb:58e8 with SMTP id v9csp144518mat; Mon, 27 Jan 2025 16:10:38 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWYxkTYVfaYWjG8juMoT7pr7CPXA9wn3DczrbkhXERgaifwZagWyo0J8Mmug3U/QGpoN2QC5JkSmec=@openvpn.net X-Google-Smtp-Source: AGHT+IGXIIUD7Kq4GiovWyGb08Vszu54p7B82Gv0KuZY2KQ8UKrZSUjt487ngsUXEpgTZIMU5nYl X-Received: by 2002:a05:6820:2508:b0:5f7:d455:16c4 with SMTP id 006d021491bc7-5fa388995e4mr17823423eaf.8.1738023038705; Mon, 27 Jan 2025 16:10:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1738023038; cv=none; d=google.com; s=arc-20240605; b=W9+fV4l/E7kzYop6unzN8QppuJyo+kKjYlvrmUKKJhE6fXMYZGC5jORcstiQnAKrCC R3wwSEF/M/hgQH/uLAFcBqSDhhJNVliLEfu3NCyQPinIa6ciTKoWphdkZJmFWgPPhK73 PDqaxonmoD+e6zKKMEXBSUa0KhJYk0Ykjtge3RX0YMSL0AbHcoGR64IlD7FxKT3cXNIF v1DGq9A9JzXHRTBXC9Dgp51kKMGbN1WxGb/c1J4iQCYzt06zm+M8P4FSj6WEx+/6XeiY 3uf5Stia+zRdN8xsIYqvKRd+jfUaVNkInhct30JOrYHsaa0J81POIRhT115OhOe+xWur BQ1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:reply-to:from:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:dkim-signature :dkim-signature:dkim-signature; bh=dczYI0OAP8NtGB8FTcXPnh75jeVgyOM7Wuo6NS13FyA=; fh=M0IgS9BLcbDnxRvvrgNqqeQSdb7j85MQs+k/Km/mzfQ=; b=SpGFBRNW9ZZ88l1+dJZKfRnptgPMY84zzIo9gJ93DjMUXYvmzK8869yHeoO3vccLOv eKBcDzZo26F6+Kfl15Rma6HziesnXvzt6xBNmBOE3JqnAQaCVAHqYVwF3Z6kjGJEaucO vFJ83NvDu3LY4PP5rmy3Ggg82jlj0zp3QOZZB+6aZgs9MPL3V00e7t7msvZqh1lbkt8r Yt7IqL2Cb+Nrf4xCbh54JBoGQeBlr5PuUpTsZKw5DZeU4r6tV9wzCuItdbjwjKmJagVU zmfoUIY71utpT8PeXd8E1ujDIpWa41AqKda5YsuWANgovLX5XBfaK76iS8tSqtOEmsL+ ppeg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=RvFJErCp; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=aa6HOfDv; dkim=neutral (body hash did not verify) header.i=@amazon.com header.s=amazon201209 header.b=Pr1ZSvRm; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 006d021491bc7-5fa8b5445d4si6849364eaf.30.2025.01.27.16.10.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jan 2025 16:10:38 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=RvFJErCp; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=aa6HOfDv; dkim=neutral (body hash did not verify) header.i=@amazon.com header.s=amazon201209 header.b=Pr1ZSvRm; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tcZBX-0006Az-Ny; Tue, 28 Jan 2025 00:10:32 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tcZBW-0006As-PA for openvpn-devel@lists.sourceforge.net; Tue, 28 Jan 2025 00:10:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Date:Subject:CC:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KhyLNMsLvL/I9/h7F/j9yNpeW4fu1HoPuCITNbhn+JU=; b=RvFJErCp32WkGwN6aj14aWv8yV S00i0r/ySjcb+TV0fXu/6SeHKYcEx8giqHfwczrx8NDdYdR5K5SKYEXN9k7i3W1WYo9Jnh+bX/yo9 FT+/uiY+WXoz0Q5NhiKj5R6G7w20ehEoaHVnpcWmTaIoCJ5/4qroXSske2dtFRFYqM4A=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date: Subject:CC:To:From:Sender:Reply-To:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=KhyLNMsLvL/I9/h7F/j9yNpeW4fu1HoPuCITNbhn+JU=; b=a a6HOfDvGRpyAOK5uUuXe1VPUUwUtI3n9iUwY921SH/fiD6qQGcR4oDGUjfsSLh/qI3hJR3r6tN3tg HSvqm0krAkQLD2plfQLI2iQtXnUwxUjHcp/0rQAmdy8nOAqN0vDn5nGZsQ0RpPcn0k1i3OOE2SPqk ejTrWWC1tTY0F1aE=; Received: from smtp-fw-80009.amazon.com ([99.78.197.220]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1tcZBV-0008Jk-Mo for openvpn-devel@lists.sourceforge.net; Tue, 28 Jan 2025 00:10:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1738023029; x=1769559029; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=KhyLNMsLvL/I9/h7F/j9yNpeW4fu1HoPuCITNbhn+JU=; b=Pr1ZSvRmw57VkrjRGfNZgfii4kFpG5Q3K587dVMUkyKlsTtyxwW7fGuX K6rTXyDW0vCqKMT3+FnWtmAuWRWhWAKpcKKwIZvE0viOUgvV+tvAa5BJv 0D7wQPKP//ujphhAfVjRut6BGNtsfPvijCQ/uUzHAcdYL98poGuBsZCrD 4=; X-IronPort-AV: E=Sophos;i="6.13,239,1732579200"; d="scan'208";a="167467696" Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev) ([10.25.36.210]) by smtp-border-fw-80009.pdx80.corp.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2025 23:54:30 +0000 Received: from EX19MTAUWC002.ant.amazon.com [10.0.38.20:28217] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.39.194:2525] with esmtp (Farcaster) id 91c5040b-578c-416a-a6cf-0d66322be24c; Mon, 27 Jan 2025 23:54:29 +0000 (UTC) X-Farcaster-Flow-ID: 91c5040b-578c-416a-a6cf-0d66322be24c Received: from EX19D019UWA001.ant.amazon.com (10.13.139.95) by EX19MTAUWC002.ant.amazon.com (10.250.64.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.39; Mon, 27 Jan 2025 23:54:29 +0000 Received: from EX19MTAUEB001.ant.amazon.com (10.252.135.35) by EX19D019UWA001.ant.amazon.com (10.13.139.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.39; Mon, 27 Jan 2025 23:54:29 +0000 Received: from email-imr-corp-prod-iad-all-1b-85daddd1.us-east-1.amazon.com (10.43.8.2) by mail-relay.amazon.com (10.252.135.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.39 via Frontend Transport; Mon, 27 Jan 2025 23:54:29 +0000 Received: from 7cf34dea8443.amazon.com (unknown [10.187.170.20]) by email-imr-corp-prod-iad-all-1b-85daddd1.us-east-1.amazon.com (Postfix) with ESMTP id B1990404DF; Mon, 27 Jan 2025 23:54:28 +0000 (UTC) To: Date: Mon, 27 Jan 2025 15:54:13 -0800 Message-ID: <20250127235413.1925-1-smittals@amazon.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 X-Spam-Score: -3.8 (---) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: URL: https://github.com/OpenVPN/openvpn/pull/673 Acked-by: Arne Schwabe Signed-off-by: Shubham Mittal --- .github/workflows/build.yaml | 61 +++++++++++++++++++ [...] Content analysis details: (-3.8 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [99.78.197.220 listed in sa-accredit.habeas.com] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [99.78.197.220 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [99.78.197.220 listed in bl.score.senderscore.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines -1.3 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-Headers-End: 1tcZBV-0008Jk-Mo Subject: [Openvpn-devel] [PATCH] Adding AWS-LC to the OpenVPN CI X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Shubham Mittal via Openvpn-devel From: Shubham Mittal Reply-To: Shubham Mittal Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1822449245671597858?= X-GMAIL-MSGID: =?utf-8?q?1822449245671597858?= URL: https://github.com/OpenVPN/openvpn/pull/673 Acked-by: Arne Schwabe Signed-off-by: Shubham Mittal --- .github/workflows/build.yaml | 61 ++++++++++++++++++++++++++++++++++++ 1 file changed, 61 insertions(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 90d52023..96edee32 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -424,3 +424,64 @@ jobs: run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc - name: make check run: make -j3 check VERBOSE=1 + + aws-lc: + strategy: + fail-fast: false + matrix: + os: [ubuntu-24.04] + ssllib: [ awslc ] + build: [ normal, asan ] + include: + - build: asan + cflags: "-fsanitize=address -fno-sanitize-recover=all -fno-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame-pointer -g -O1" + ldflags: -fsanitize=address -fno-sanitize-recover=all + cc: clang + cxx: clang++ + - build: normal + cflags: "-O2 -g" + ldflags: "" + cc: gcc + cxx: c++ + + name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{matrix.ssllib}}" + runs-on: ${{matrix.os}} + env: + CFLAGS: ${{ matrix.cflags }} + LDFLAGS: ${{ matrix.ldflags }} + CC: ${{matrix.cc}} + CXX: ${{matrix.cxx}} + UBSAN_OPTIONS: print_stacktrace=1 + AWS_LC_INSTALL: ${{ github.workspace }}/aws-lc/aws-lc-install + + steps: + - name: Install dependencies + run: sudo apt update && sudo apt install -y cmake gcc ninja-build golang make liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils python3-jinja2 python3-jsonschema libtool automake autoconf pkg-config libcap-ng-dev libnl-genl-3-dev + - name: "AWS-LC: checkout" + uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 + with: + path: aws-lc + repository: aws/aws-lc + ref: v1.42.0 + - name: "AWS-LC: build" + run: | + mkdir build + cd build + cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX="${{ env.AWS_LC_INSTALL }}" -DBUILD_SHARED_LIBS=1 ../ + ninja install + working-directory: aws-lc + - name: Checkout OpenVPN + uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 + - name: autoconf + run: autoreconf -fvi + - name: configure with AWS-LC + run: | + OPENSSL_CFLAGS="-I/${{ env.AWS_LC_INSTALL }}/include" \ + OPENSSL_LIBS="-L/${{ env.AWS_LC_INSTALL }}/lib -lssl -lcrypto" \ + ./configure --with-crypto-library=openssl + - name: make all + run: make -j3 + - name: configure checks + run: echo 'RUN_SUDO="sudo -E"' >tests/t_server_null.rc + - name: make check + run: LD_LIBRARY_PATH="${{ env.AWS_LC_INSTALL }}/lib" make -j3 check VERBOSE=1 \ No newline at end of file