From patchwork Wed Feb 5 17:02:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4122 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:7882:b0:5e7:b9eb:58e8 with SMTP id d2csp965189max; Wed, 5 Feb 2025 09:02:51 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXHR9IU948+ZMY5UDjdnEdfUUdcPaePWRJTnHTdw7j4aMuqRR/bzhUHGWm3R4d3ZHHtr1Ni9tx1Qn0=@openvpn.net X-Google-Smtp-Source: AGHT+IFX11Wyw7Vy235w0vbk1vR1NMqt1l5ndWH+mxJxNR6gMhbGlTuvjU9+k63QYnPzQqMSGgU/ X-Received: by 2002:a05:6871:7c0d:b0:29e:2ce2:94d with SMTP id 586e51a60fabf-2b804f4e141mr2399271fac.14.1738774971019; Wed, 05 Feb 2025 09:02:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1738774971; cv=none; d=google.com; s=arc-20240605; b=ew3ED31QAzmQoYEETsKqEWw735sbP9YyOuTC1A5v6PQfcrSgrtUKQmf6d+LKqWoXhM nIiTnxl5SKwFVQSK940JsV4vcNhkUNGCt4cif+Dx8AKXS2giW3HAm8jjZ1IphZuafs6v bzY0xOdFh1+iQgnCBIKkQUhTFnuzlOW/0sWrk5/MgNwaa46ZIa+AgC4mNbythqIEqV+t TPosYCipjTEte/L2Hh7oyxEmWKaC+ECAA6ZyRtwByai4FYHdBzwEVifJF12vPegyZjfz dcsC3GcOgAfmwQvxPPUOiy/XkIyQZltgo8hpSehgb0SfNXOZ2N+Jit0p04DanMvM0T62 c8bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature; bh=KYXKTc7E8+RcLheb35tgreJSVgJcSC7uSMJh1x9VpL8=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=b27QFIauy0ffmynz4rwRxxOaOGi6GdWX7eUyzVdI6k/rDe+EH4/ORXYKPffbC8vj3V CGf0tAbbqA8NkBb89jXRmtS9XcGOH+aBoY5HCrlEFHvotla75Hj1Z9NWwQE10/aVcfs8 wBsVhhAdqOa5SMkYNOY+h5bmH5oy9g2AhoN6eqLR3Q1Vy0y78kjDlIJa6QuAmjEPNQBK QCOoFMlTJWPXys0Fi/KryGe2Si3NCZ5kuKsAVidmQmMonq8Enq17G7H7C9HHG2DAvzjW +0T0jLdhRV6GF/pyVoVPTDEJwi/Mn2DYUhoh9mtbvY0EYl4dW02pYfk8ya6pLXyQkUcX FsMg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=YR7RZEyM; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=BTXnaWOX; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-2b43026f1b7si3388415fac.36.2025.02.05.09.02.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Feb 2025 09:02:50 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=YR7RZEyM; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=BTXnaWOX; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tfinW-0000WX-IH; Wed, 05 Feb 2025 17:02:47 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tfinU-0000WO-QI for openvpn-devel@lists.sourceforge.net; Wed, 05 Feb 2025 17:02:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qj7Dbkjrecmok7sXEehv3GfwUzMWUQJBe4AavW03RCg=; b=YR7RZEyMJepbo6ZfqZomfZg2SL iBWx6pvPVU8YOOw3EPoWLxyULPjeRlnabm5VfwmcFhIx3c/bIDD2GYFzi6aXisE7aVXR49YbXwMkj ufDCnzUo7sxZNAPNIY1R+B3MTN8IeqsqNqxJt5JuQ36m31/HkjMtxAl7xrE8x4iiaw94=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qj7Dbkjrecmok7sXEehv3GfwUzMWUQJBe4AavW03RCg=; b=BTXnaWOX/BYMVxbfExnI3CVXPj /olEQ+Tdbw4obtgTzusk5J8Z1aa8FSb1Wu5UyzagDI0Vz8gbwJq5jm1K9PSfB37Xk9f9iVy0IRnFr VAORCbQziYOkMa2e1Q55meI7V5u+zseAz9VdJTwf5x0Ia6NOfPloarZ19m5EGS1vTWYE=; Received: from dhcp-174.greenie.muc.de ([193.149.48.174] helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1tfinU-0008To-H8 for openvpn-devel@lists.sourceforge.net; Wed, 05 Feb 2025 17:02:45 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 515H2XWn003483 for ; Wed, 5 Feb 2025 18:02:33 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 515H2Xeo003482 for openvpn-devel@lists.sourceforge.net; Wed, 5 Feb 2025 18:02:33 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 5 Feb 2025 18:02:32 +0100 Message-ID: <20250205170232.3473-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: mingw complains about "old-style function definition" and since we use explicit (void) everyhwere else... Change-Id: I59e34058d6e0611208767fbcf39d1b91784ebcf9 Signed-off-by: Gert Doering Acked-by: Frank Lichtenheld --- Content analysis details: (0.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in bl.score.senderscore.com] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1tfinU-0008To-H8 Subject: [Openvpn-devel] [PATCH v1] add missing (void) to win32 function declarations X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1823237704103460641?= X-GMAIL-MSGID: =?utf-8?q?1823237704103460641?= mingw complains about "old-style function definition" and since we use explicit (void) everyhwere else... Change-Id: I59e34058d6e0611208767fbcf39d1b91784ebcf9 Signed-off-by: Gert Doering Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/886 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/dco_win.c b/src/openvpn/dco_win.c index 46b2d03..62d7109 100644 --- a/src/openvpn/dco_win.c +++ b/src/openvpn/dco_win.c @@ -502,7 +502,7 @@ } const char * -dco_get_supported_ciphers() +dco_get_supported_ciphers(void) { /* * this API can be called either from user mode or kernel mode, diff --git a/src/openvpn/error.c b/src/openvpn/error.c index ec65d5e..d5bb802 100644 --- a/src/openvpn/error.c +++ b/src/openvpn/error.c @@ -505,7 +505,7 @@ static int orig_stderr; int -get_orig_stderr() +get_orig_stderr(void) { return orig_stderr ? orig_stderr : _fileno(stderr); }