[Openvpn-devel,v1] Fix typo in positive_atoi

Message ID 20250212123652.18183-1-gert@greenie.muc.de
State Accepted
Headers show
Series [Openvpn-devel,v1] Fix typo in positive_atoi | expand

Commit Message

Gert Doering Feb. 12, 2025, 12:36 p.m. UTC
From: Arne Schwabe <arne@rfc2549.org>

This is a code path that only affects Android

Change-Id: I3f05318fb6f8d9e32d07532a4f0c6ccf8fb757ce
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/889
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Comments

Gert Doering Feb. 12, 2025, 1:01 p.m. UTC | #1
Trivial typo... we should have caught that on merging the original
patch... but... new buildbot coming, I hear :-)

Your patch has been applied to the master branch.

commit f3268ee5c7a1beeea01aeed579c7ee11ceca9b03
Author: Arne Schwabe
Date:   Wed Feb 12 13:36:52 2025 +0100

     Fix typo in positive_atoi

     Signed-off-by: Arne Schwabe <arne@rfc2549.org>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20250212123652.18183-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30832.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index 218d8a6..3ae44db 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -8316,7 +8316,7 @@ 
 #if defined(TARGET_ANDROID)
         else if (streq(p[1], "PROXY_HTTP") && p[3] && !p[4])
         {
-            o->http_proxy_port = positiove_atoi(p[3], msglevel);
+            o->http_proxy_port = positive_atoi(p[3], msglevel);
             o->http_proxy = p[2];
         }
 #endif