From patchwork Wed Feb 12 12:36:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4128 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:948d:b0:5e7:b9eb:58e8 with SMTP id g13csp912409mal; Wed, 12 Feb 2025 04:37:12 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCU6mHxh8nJGPfx7kqOQnkr/yVKo3PfFqXV1GBIx4kqG/G+NyjDHGgnpM1lmmoSdGqUSMhLIoCXyGF0=@openvpn.net X-Google-Smtp-Source: AGHT+IEFNv5fOfbSPH6BDEZTTDJjSPki5ewOEpCupnP2L2mh9YWINfyArDrqvXb7jZKs4wFHO6ld X-Received: by 2002:a05:6830:25c1:b0:71d:4b0b:62c2 with SMTP id 46e09a7af769-726f1d4930emr1827376a34.17.1739363831875; Wed, 12 Feb 2025 04:37:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1739363831; cv=none; d=google.com; s=arc-20240605; b=RlYAS6ggW3/spaKMWOQ+xBvmEEf/36uKd+0aDNayZCnZNOmToH5L167I9QTHppK5nB zMvT6spCQa2WYYdr53JfSykGiS47VKAT8CA4dm1zNe2cIgQMZjO+tX7PI/GpBrVndGn4 WcKnbSDet6D95005eLfGrXxzAdeL+jbSeDRqf+j5cTtjjDeNaiv4D7cbv1fYXVqT8z6n UHAc9TZedPSuTe1z2pq0kRmOOXFNQEAezgoL0G3GTQU6J4eHpYo6ah17XfuT7e3VOA43 k5sz/3zliNCR18EIVcmZw5iQj45pfmuN1eSuqorJQv5ijq2ePNSJF9rNVJBBCIWfdn1s F3cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature; bh=aNp5CL1qEydvGlNjBtNQvwivFBpwaQdIMAS0rSgJkFo=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=S8cLfQMYmAeXZAbBQzq5S+YEdH4IyYj7+UJfGocS/OS5eL8+ksaFPlbp3xkDx734i0 iUvu21VIK4lpl0R524Q74hhV2maXIzlMZPnfEqXdDqek2rCzmMvCQo0HcTqYz6elqeLE Tc1F4MVxhfk/A7wcUav5tqZxH4qe28zj/Y5F/FTtCAzW2aDKi1XnRCCqN3b8ZKXM6k/u HCEW3zsGct8W25GvBMzikFiOq2yGfW0zMfbBxtkIxp+H6doXpoKC/hpyLZmK/chvFCDN UBBhkQXovGC2l4E+5FJB0Hi0dM/ohWegaxEtPf/rwf62APeqIer2qAjnj1xuE8A3L6xx j1SQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=h9o6ACw+; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=mKc5IjmF; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-726af91c9d8si13964220a34.80.2025.02.12.04.37.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Feb 2025 04:37:11 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=h9o6ACw+; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=mKc5IjmF; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tiBzI-0004kI-68; Wed, 12 Feb 2025 12:37:08 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tiBzG-0004kC-Ts for openvpn-devel@lists.sourceforge.net; Wed, 12 Feb 2025 12:37:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UXUxbyFZjHj9LSr60Y/3joA8xuJzGSGXj1vzWmVHNIM=; b=h9o6ACw+HBsctv30qWdZWemm45 y8vdrZls1JzptePOo6fS79icXeHKSJKwO3cTmMERA3/YsXA4SHupIAR1JrZ9exbGPm5E1CQfDPlnm ZzryL+Gho1b8lrJ5Kbpm1ig7jLwzfwo4hCvyJuJxzDjqaLnaZzYYiwIdtn5Ddvm395E8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UXUxbyFZjHj9LSr60Y/3joA8xuJzGSGXj1vzWmVHNIM=; b=mKc5IjmFRqf2quQhGQMy7n27+P Ke4ptD7yliv8R69htglg2XvU6FT2laGWQwsGzbB5S11hWgs6EtGoSHDsg6iCFQrBlghmU9xpeWH1X Q0At3ba88ilLAqHCB6w6n+jMfLJogJVXR+fb3EQj2eUToZLvEu+PeikzUZS2pt7+Ain8=; Received: from dhcp-174.greenie.muc.de ([193.149.48.174] helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1tiBzF-0006zj-D2 for openvpn-devel@lists.sourceforge.net; Wed, 12 Feb 2025 12:37:07 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 51CCarfS018196 for ; Wed, 12 Feb 2025 13:36:53 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 51CCarVN018193 for openvpn-devel@lists.sourceforge.net; Wed, 12 Feb 2025 13:36:53 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 12 Feb 2025 13:36:52 +0100 Message-ID: <20250212123652.18183-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe This is a code path that only affects Android Change-Id: I3f05318fb6f8d9e32d07532a4f0c6ccf8fb757ce Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- Content analysis details: (0.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in sa-accredit.habeas.com] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1tiBzF-0006zj-D2 Subject: [Openvpn-devel] [PATCH v1] Fix typo in positive_atoi X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1823855169701480340?= X-GMAIL-MSGID: =?utf-8?q?1823855169701480340?= From: Arne Schwabe This is a code path that only affects Android Change-Id: I3f05318fb6f8d9e32d07532a4f0c6ccf8fb757ce Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/889 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 218d8a6..3ae44db 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -8316,7 +8316,7 @@ #if defined(TARGET_ANDROID) else if (streq(p[1], "PROXY_HTTP") && p[3] && !p[4]) { - o->http_proxy_port = positiove_atoi(p[3], msglevel); + o->http_proxy_port = positive_atoi(p[3], msglevel); o->http_proxy = p[2]; } #endif