Message ID | 20250214125619.19935-1-gert@greenie.muc.de |
---|---|
State | Superseded |
Headers | show
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net> Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:9b51:b0:5e7:b9eb:58e8 with SMTP id b17csp175101max; Fri, 14 Feb 2025 04:57:07 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWuHFCC+pESETUM+wfqg//c7905aAQzYbGak6tVRwXI9ZhgPIFm3qsAgzTDP7xP3XC8M9GycQPTStU=@openvpn.net X-Google-Smtp-Source: AGHT+IGQM3vt2i4bVjIKdKlrkUr1jFjk3ujm/uhRiTZBHPiasH1H8qP2Ot9NUN0F78KjF0O39AQC X-Received: by 2002:a05:6e02:1c8e:b0:3d0:23ac:b29f with SMTP id e9e14a558f8ab-3d17bdfa66fmr101744575ab.1.1739537827199; Fri, 14 Feb 2025 04:57:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1739537827; cv=none; d=google.com; s=arc-20240605; b=O/P6AwS0JeCCLXYegzJWD9gksPuLCIpuW4RXYzxUD7sMcwnHrLQzwKR7nkp4UOJEFL tCDssLukD3kJLYmW+gi+fqtVV5166TxsQ6RzwT6gFq908x0cDNPSGQ7AT3CV+OETyvpF PLF5CAJEgJFRpWHFGbXYn3DuSRciri54F+dOdxvmVIyWmTvTX4IZIqrowGqD5lLz2G7H scZ2h/7sUjDqNgFbwktSpIJPBbIWy9q/pwo0zdFs6A5hPXke7Ju+D8snfE//la6tmaXi JANkWKZKGonHBh3/L8GeXv7uKUKEJVoCYNf3INwkwfOuzJSpZd4ga7J/Honr5VGkCCJa X79Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature; bh=rUQ7TczRg+fmFFo8T7La3q8cnOU29ho2YPr6Q4y/bgc=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=PDeOkbnWhkvOBAEy0RfHynMLzpy8tClG8TlU4ForgUYnbesWN05jPV46w+Oi8rXc1Q HzDXzIybdsoEDsk6nEDDYMC//NoisBxi1lPRVwebGYDLvxLXXkjIAtkbaAzQ5dpgb4Yb ZQSPMeACn99h7oreGOB9y5Stia1YkPSlHezUDzyKBfDbUzEbQTqst44P2Y+lojkXdLxB i49OlGtMUGc+oqZEu9PBNfxCesmsv4ODUuVpwUMJbhx7we42uFnJRl+wXUvfAnA0UfRm uKuxmMelijPNbJtOXEd0XncU0iLx16KiHRg9mugQ2yfN8Xds07u2qlUpMtirjYi+9LT9 4NFg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ANTT5tO8; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="Fr/CEbGc"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id e9e14a558f8ab-3d18f9ca7e5si21275315ab.27.2025.02.14.04.57.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Feb 2025 04:57:07 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ANTT5tO8; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="Fr/CEbGc"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from <openvpn-devel-bounces@lists.sourceforge.net>) id 1tivFg-0007ly-Q4; Fri, 14 Feb 2025 12:57:04 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from <gert@blue.greenie.muc.de>) id 1tivFf-0007lL-BE for openvpn-devel@lists.sourceforge.net; Fri, 14 Feb 2025 12:57:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FbBaFiao2foFEph7fk//p3zj5RnEBgIuB4I8YdtxS40=; b=ANTT5tO8CTC4/dUail77qSaqDU qnoP7msv23Y43Ws4OoJoqWfZ3XIkMf+Te0L6wXog3mj6++TV+FL+plgDhQ515lvTMVyu2OjrIhAMH TcrIGqJmp/7CbumYZcgDglFUb9xrvepY1FTHNsZvRt2vJrGIlP27x2sXNWVONmJAXCOg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FbBaFiao2foFEph7fk//p3zj5RnEBgIuB4I8YdtxS40=; b=Fr/CEbGc/ZN6wPUEwmmAcEAh8j JG67O1QliXSSacFAIyRNYBBiMLypaNufr4VxyQ6eZ4CQLjbHNaC6SNQpAEJxDxs00ebnCaEM7XClY P02JIMWaedhanrdlFzZ9yhEq0ocn8/WNu3xiUM7WBzyfBzSTObpGzL3T1tZ28oAdFwBQ=; Received: from dhcp-174.greenie.muc.de ([193.149.48.174] helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1tivF9-0006gc-IZ for openvpn-devel@lists.sourceforge.net; Fri, 14 Feb 2025 12:56:32 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 51ECuKoG020001 for <openvpn-devel@lists.sourceforge.net>; Fri, 14 Feb 2025 13:56:20 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 51ECuKru020000 for openvpn-devel@lists.sourceforge.net; Fri, 14 Feb 2025 13:56:20 +0100 From: Gert Doering <gert@greenie.muc.de> To: openvpn-devel@lists.sourceforge.net Date: Fri, 14 Feb 2025 13:56:19 +0100 Message-ID: <20250214125619.19935-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.45.2 In-Reply-To: <gerrit.1739527719000.I02afe6817433ca21aae76671c35151ec6a066933@gerrit.openvpn.net> References: <gerrit.1739527719000.I02afe6817433ca21aae76671c35151ec6a066933@gerrit.openvpn.net> MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Marco Baffo <marco@mandelbit.com> Change-Id: I02afe6817433ca21aae76671c35151ec6a066933 Signed-off-by: Marco Baffo <marco@mandelbit.com> Acked-by: Gert Doering <gert@greenie.muc.de> --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Content analysis details: (0.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in sa-accredit.habeas.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record X-Headers-End: 1tivF9-0006gc-IZ Subject: [Openvpn-devel] [PATCH v2] get_default_gateway(): Make sure the get_default_gateway() function never receives IPV4_INVALID_ADDR as a destination. X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: <openvpn-devel.lists.sourceforge.net> List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>, <mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe> List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel> List-Post: <mailto:openvpn-devel@lists.sourceforge.net> List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help> List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>, <mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1824037616793103508?= X-GMAIL-MSGID: =?utf-8?q?1824037616793103508?= |
Series |
[Openvpn-devel,v2] get_default_gateway(): Make sure the get_default_gateway() function never receives IPV4_INVALID_ADDR as a destination.
|
expand
|
diff --git a/src/openvpn/route.c b/src/openvpn/route.c index d895e1c..bc41492 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -655,7 +655,7 @@ rl->spec.flags |= RTSA_DEFAULT_METRIC; } - get_default_gateway(&rl->rgi, remote_host, ctx); + get_default_gateway(&rl->rgi, remote_host != IPV4_INVALID_ADDR ? remote_host : INADDR_ANY, ctx); if (rl->rgi.flags & RGI_ADDR_DEFINED) { setenv_route_addr(es, "net_gateway", rl->rgi.gateway.addr, -1);