[Openvpn-devel,v2] get_default_gateway(): Make sure the get_default_gateway() function never receives IPV4_INVALID_ADDR as a destination.

Message ID 20250214125619.19935-1-gert@greenie.muc.de
State Superseded
Headers show
Series [Openvpn-devel,v2] get_default_gateway(): Make sure the get_default_gateway() function never receives IPV4_INVALID_ADDR as a destination. | expand

Commit Message

Gert Doering Feb. 14, 2025, 12:56 p.m. UTC
From: Marco Baffo <marco@mandelbit.com>

Change-Id: I02afe6817433ca21aae76671c35151ec6a066933
Signed-off-by: Marco Baffo <marco@mandelbit.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/898
This mail reflects revision 2 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Patch

diff --git a/src/openvpn/route.c b/src/openvpn/route.c
index d895e1c..bc41492 100644
--- a/src/openvpn/route.c
+++ b/src/openvpn/route.c
@@ -655,7 +655,7 @@ 
         rl->spec.flags |= RTSA_DEFAULT_METRIC;
     }
 
-    get_default_gateway(&rl->rgi, remote_host, ctx);
+    get_default_gateway(&rl->rgi, remote_host != IPV4_INVALID_ADDR ? remote_host : INADDR_ANY, ctx);
     if (rl->rgi.flags & RGI_ADDR_DEFINED)
     {
         setenv_route_addr(es, "net_gateway", rl->rgi.gateway.addr, -1);