From patchwork Wed Feb 19 10:59:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4150 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:9b51:b0:5e7:b9eb:58e8 with SMTP id b17csp2871526max; Wed, 19 Feb 2025 02:59:54 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCV1BVk35scFY8sySl0kE/lIX21KnICX07VWkoset3dbUfkZTGRhBb490BXODkoSicG26mNDXrkq1ZI=@openvpn.net X-Google-Smtp-Source: AGHT+IGj5T3GSnC0nVAJiIUDZ47RaMnHCOk6AeCJsUNXbFVaQxnCuHtP00hzRCaQoZrwRFmcIWn+ X-Received: by 2002:a05:6808:1a08:b0:3eb:3b69:8ff4 with SMTP id 5614622812f47-3f40f1eb965mr2116063b6e.15.1739962793836; Wed, 19 Feb 2025 02:59:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1739962793; cv=none; d=google.com; s=arc-20240605; b=S3sWJk4LvDwH/fX61lrzE6Or4/qbBJILoUhyC9XhzPUZ2ydFlzNB3MD2gDoM+hAFQ4 /UjYWS1tLoIYhy2BMF2Xl7zdQuWaSjXD6bmvqfkZbEOALdCMIuC14978IxmfEoFrJ3cQ mlvJy4jyWYrpsKkqBqpqvRxClxbyDChxm+hyI8KxD4B+03I/ap9JzeWDl7Ii+TCJX5ia ZmIW3os8IK1fIEKJkpkYPxEFaC+psIs/+hwKQd4oxIyr1MdqAP4RoDtZhci+42QIAyyR BfuVxK+UxBoVvteXZTUrG7qjHNvl03KkLCjQXdmO/PfmabFbPrD9K3Qk9ADX93C0vxKt sRgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature; bh=GggSfaafmhZDwZtrnK09f/hy42NsVobsUpos8I4VfKo=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=MByVrInBAyGiAQLt3qvdogS1UXNKmgUUV0ZEL3L0tC5vB2WDpM2zV59VVUfGkRcYan LkPZiiYbtuaGJCuJGObFPxsF6mP5h7yQe52JUFQhnm8DKUnVa2SlH3W44X3lbBV0Z+yw uaRwKi1tOUR3ckWKqy61N+eNdGLvaB+/OqjFfQ8LOGn0goFo9+SEDd5eVg5nPdrfL0K0 7vkZ/nYfc7wOfOy+zUJJ8BC3lol7VPX9taIrdM4pRePEIwISFxmXzZ4QKngSpJfTL/jI NWgep0FLzV5HCLqj5c3tUI9niDZOGrDY+gvT7fcSrGJt3fPgbXro4ntk+eN+Q+xC9364 0qpg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=nP4CWF3N; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=dKHneGC7; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-3f41265a1fasi748010b6e.277.2025.02.19.02.59.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Feb 2025 02:59:53 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=nP4CWF3N; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=dKHneGC7; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tkhnw-0007bM-3Z; Wed, 19 Feb 2025 10:59:48 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tkhns-0007bC-Ag for openvpn-devel@lists.sourceforge.net; Wed, 19 Feb 2025 10:59:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=73AzxkhTd/NqQSiM2TkUowRqNSs1JQB5qYqrRgwLjtA=; b=nP4CWF3NIT4/Z9GBA9o3BRX3dF 1PaFjAJvehBjZpzEybP6qEdIQPBZGnVkEmKfVlWv+27a/oLAc4H1q76OLwheI8S+xYJQbhs8IXljk DLgG8BsDZj5e1Kn/g5O9Rg7ZXz1mHSvdYnO3Dc5F99A9MMw+kLmnDUwC9gaNrgH7ywoU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=73AzxkhTd/NqQSiM2TkUowRqNSs1JQB5qYqrRgwLjtA=; b=dKHneGC7SVjmsnuOZaUwxz4hHb qAH/SSwwe5Wfm0O8flLsulmozhN0PjsJNrGpyvS/uZMuH8W0rYIVB2vuE5ofHczay0Fr2jne2iKj6 JaQqq6FpUvb8VCiVsyVupD61yESUxVajYhoDpeNPrNsg0VuA5URFFCsnTDfdYvyfU8tg=; Received: from dhcp-174.greenie.muc.de ([193.149.48.174] helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1tkhnq-00085p-Ms for openvpn-devel@lists.sourceforge.net; Wed, 19 Feb 2025 10:59:44 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 51JAxUON029570 for ; Wed, 19 Feb 2025 11:59:30 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 51JAxUhc029569 for openvpn-devel@lists.sourceforge.net; Wed, 19 Feb 2025 11:59:30 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 19 Feb 2025 11:59:30 +0100 Message-ID: <20250219105930.29508-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Change-Id: I1a9738ad73c79661a8beb4d9881eba0b4d3aea53 Signed-off-by: Gert Doering Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Content analysis details: (0.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record X-Headers-End: 1tkhnq-00085p-Ms Subject: [Openvpn-devel] [PATCH v1] add more (void) to windows specific function prototypes and declarations X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1824483226593639428?= X-GMAIL-MSGID: =?utf-8?q?1824483226593639428?= Change-Id: I1a9738ad73c79661a8beb4d9881eba0b4d3aea53 Signed-off-by: Gert Doering Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/899 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/win32.c b/src/openvpn/win32.c index 86556a8..edac71e 100644 --- a/src/openvpn/win32.c +++ b/src/openvpn/win32.c @@ -103,7 +103,7 @@ * Set OpenSSL environment variables to a safe directory */ static void -set_openssl_env_vars(); +set_openssl_env_vars(void); void init_win32(void) @@ -1518,7 +1518,7 @@ } static void -set_openssl_env_vars() +set_openssl_env_vars(void) { const WCHAR *ssl_fallback_dir = L"C:\\Windows\\System32"; diff --git a/src/openvpnserv/common.c b/src/openvpnserv/common.c index a88a724..74bec6e 100644 --- a/src/openvpnserv/common.c +++ b/src/openvpnserv/common.c @@ -181,7 +181,7 @@ LPCTSTR -GetLastErrorText() +GetLastErrorText(void) { DWORD error; static TCHAR buf[256]; diff --git a/src/openvpnserv/service.c b/src/openvpnserv/service.c index 054fc5f..84fd11a 100644 --- a/src/openvpnserv/service.c +++ b/src/openvpnserv/service.c @@ -54,7 +54,7 @@ } static int -CmdInstallServices() +CmdInstallServices(void) { SC_HANDLE service; SC_HANDLE svc_ctl_mgr; @@ -146,7 +146,7 @@ static int -CmdRemoveServices() +CmdRemoveServices(void) { SC_HANDLE service; SC_HANDLE svc_ctl_mgr; diff --git a/src/openvpnserv/service.h b/src/openvpnserv/service.h index da20433..c5f587b 100644 --- a/src/openvpnserv/service.h +++ b/src/openvpnserv/service.h @@ -86,7 +86,7 @@ BOOL ReportStatusToSCMgr(SERVICE_STATUS_HANDLE service, SERVICE_STATUS *status); -LPCTSTR GetLastErrorText(); +LPCTSTR GetLastErrorText(void); DWORD MsgToEventLog(DWORD flags, LPCTSTR lpszMsg, ...);