Message ID | 20250227032522.3734947-1-dqfext@gmail.com |
---|---|
State | New |
Headers | show
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net> Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:a117:b0:5e7:b9eb:58e8 with SMTP id cp23csp1210026mab; Wed, 26 Feb 2025 19:25:38 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUw0lMoNjzMhpfPnwSIOfM6X6vtWw6iqTcwvwsJm4srgqbgINp3VGRheKaYNFvkUwVCy/ES+fbQB6g=@openvpn.net X-Google-Smtp-Source: AGHT+IEfJOQR+ry1p9DZf4O4LxIprJ5sT77raz4po2siMGRpJVl/Om9V/oRoeT7F3NMdqf5Nxbq9 X-Received: by 2002:a05:6e02:13ac:b0:3cf:c773:6992 with SMTP id e9e14a558f8ab-3d2cae87c65mr263804295ab.12.1740626738329; Wed, 26 Feb 2025 19:25:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1740626738; cv=none; d=google.com; s=arc-20240605; b=I/cz/s2G0zRY1+hu/9WAkH4Yw2Ds6CQ8rF2pdz9pxS7XA1mP34n50ZUAMmKYUjwTUt PbyGfM5xn49zGbGpdqkK/Zh1BfGmNsBo4LzwH4L9EAYVVzDbhDIGmjXV83jjT/Y3JAiO H61YG3XmyxJgZsvlazwJmEbPxLZOgrcZml+4Y0gdYWyG6YxbrWfHL3516dFIxIGI5HM8 3CTCfOkQaR2MaMlEtu8zGVkTCOp/+i+D5MAqcOiKuatEVbSiuW2I2cyRTp3CsaBIsca8 7lsR1/bsJEZGAnYv65IN9lvoRf99cVw2H5p+S2WGKSxSYJyNkOQ1YCwbosFzLfts8AI8 7ucw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature; bh=NpNXaqHR+G0YsluvE4lS/maM4bogrtC3oPPWD1boQOU=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=i5g36FYR7sOedbiXLW08LywrOeJIKPCr+fRhlBfX00lcSahXMWETV4uDNyb5AsXMbp jUz7gveXiOa2KlUDlXUakPL1JNsKHbiE11tZO+x7waF7zIK0uuMAr2e8voWHuN3ptwNX F0eepld4/8XQqZvh9HUFJpAZIV3gGvNvCnHuLfL1Mqf9V4ozCrIpjSOCIDBouP1KoWJa LqODb3vNct4H+wi/Bzx3Kweq9OrhCnafuGEOdXEyOMRAas9nPgkJk+TRejGaLme9o0PG mCL4FeLuHgObRsBQN2C9IRiK69iFYVvK8C9rNvcgPNPdWNzH8gOvS9VCfOj28tQxHrjm UkCQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=XbTdBk1o; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=TEjPaGFA; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=ho5GfVsU; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 8926c6da1cb9f-4f061fac9a4si457656173.118.2025.02.26.19.25.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Feb 2025 19:25:38 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=XbTdBk1o; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=TEjPaGFA; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=ho5GfVsU; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from <openvpn-devel-bounces@lists.sourceforge.net>) id 1tnUWj-0002wt-9d; Thu, 27 Feb 2025 03:25:34 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from <dqfext@gmail.com>) id 1tnUWh-0002wc-Pk for openvpn-devel@lists.sourceforge.net; Thu, 27 Feb 2025 03:25:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=K4T6ifnhn0zJl6wpvF0eFQAM47eDijcwylYs1t9qdhw=; b=XbTdBk1oga/m3SP7dBgKGSeNOA ipD0JtozclNy089tHiQvhWdDMWjxcWHP9tQZY99D/ZCU83WFjazdx93DA3gMZYgCvIw1P2ct3G1c+ 6X37V+lw9p1U8RmEC7fM2nQ02bJjjohDTqLiS/ES89OEIqFzSGMQ0vmdOi0+PIWTZQxQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=K4T6ifnhn0zJl6wpvF0eFQAM47eDijcwylYs1t9qdhw=; b=T EjPaGFAe9lep3Oz8VY1WfNbSPLlyqrdMVxj/TiV0I7tJhk9hB0lE+lgs4hpnlHC+lpcLMy8qy1O6Y OzHt12R+Zwi8lTRfAoNltfIT6rUPmlURie/BmbkEqSz+aaIR0/OyPuipOuVUiWLdyGE7YbujsdLBl 5puuhr+JGEnHP1uY=; Received: from mail-pl1-f180.google.com ([209.85.214.180]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tnUWh-0005Og-VS for openvpn-devel@lists.sourceforge.net; Thu, 27 Feb 2025 03:25:32 +0000 Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-22355618fd9so1268705ad.3 for <openvpn-devel@lists.sourceforge.net>; Wed, 26 Feb 2025 19:25:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740626726; x=1741231526; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=K4T6ifnhn0zJl6wpvF0eFQAM47eDijcwylYs1t9qdhw=; b=ho5GfVsU6Pp8c8GRVBZy34WjumHJfsKX7wlt+kKypkoQ01eSm5Ff8/rahWCX5S2O7H pkyGVXn2JEc0Nu5SHkZ6j2KhpontYWstp9M+kcrMMR+DcWAtjZmlYQLHUmOTJxev8Gg2 Om2FejK9pkW6oJH1f1+AdsFJ7NpGMfRL2ha4LRRhgL7t1lPLwmgsTcELlYntRNPM6rUP /Go81PYP5qwicaV4WahpV1grBQ86e0rOcnVFQyAVwSs4Vb0vbcx8ihyHoV87FTWrgO4o nL+8Sx0yoRoZdbZj6R7nkjbiR2JCqpmVJBRnHY0gc5PvAy77b1YFOtXCRbuDF02RKSbd b+MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740626726; x=1741231526; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K4T6ifnhn0zJl6wpvF0eFQAM47eDijcwylYs1t9qdhw=; b=mo+xNA2ys4PsI8tGx4KCHKC7E2eWzcmTwlKQDpdDUO93ySoCackelcrfI6RFIsHhT/ OUFshcE63laDI/Db6xfGFuJTMoaIUpRmq4jIN2HTMOkuBZAX09RdrG1K7MQnb1nhboPJ Ca2sW7H3jFZGHNiGIzc7iF2HGd/4HNlxVLDrNdBRNGXYgW8noPE04LErhPAdumrn11Ab BpIX07KoFbHpcqi4jmeccJDM3JS3I8Zfye3gDwqT440GTQCCy7woQZNg83SzzB7/92Hw nsWl+Dz8OnSpRB3r1mtLS+cHFiP18xH+Iipa0GYSjcEqHEIshjYNei/MuSY0EUHnJs6l U4xA== X-Gm-Message-State: AOJu0YzYaA0yNKZqrzwNL9+k6bMNsDXAA0iCGK2UYwlVYtef6Ozy/P05 16Wg+A3ChZWF0eNTavCX56wzkQs+28M/7n/vu++9YNl+FSztmRUBlQ9kB7e98CA= X-Gm-Gg: ASbGnct9mFu6qPYkgC0ffCfCBZEBFdxUkxpyBYJ2iwmr4L3lEQ9Ca4uJP6Ah2eajsP1 IiZmwnsw1Ge/vS0yYkkbivBtCiOfnhYIduq8/GoiS3N0jEF5JBcWtCaY5nXWYtyx9l4nsrmpwwp kbUruCegmvpsk15OtIGh2pDwcUSo2pHJC4itNNb/8NCEMO2Xfw70qxfQsNENBLM/dD1DAwLsEX9 cmUpLsuaEIN/6QvWUcajXnYQ248kaxlQzVxJAyJamIGKTpnYgoWZJY/MR7a29u0sfYa3A+8gPYK GuBs9h7DIt13nTXIr/o= X-Received: by 2002:a05:6a00:2ea9:b0:730:949d:2d32 with SMTP id d2e1a72fcca58-73426cac1b1mr36217345b3a.6.1740626726135; Wed, 26 Feb 2025 19:25:26 -0800 (PST) Received: from gmail.com ([116.237.135.88]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7349fe47eb6sm401477b3a.42.2025.02.26.19.25.25 for <openvpn-devel@lists.sourceforge.net> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 19:25:25 -0800 (PST) From: Qingfang Deng <dqfext@gmail.com> To: openvpn-devel@lists.sourceforge.net Date: Thu, 27 Feb 2025 11:25:22 +0800 Message-ID: <20250227032522.3734947-1-dqfext@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: When multihome option is enabled, OpenVPN passes ipi_addr to DCO, which is always 0.0.0.0. It should use ipi_spec_dst instead. Signed-off-by: Qingfang Deng --- src/openvpn/dco.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.214.180 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [dqfext[at]gmail.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.214.180 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.214.180 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.214.180 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Headers-End: 1tnUWh-0005Og-VS Subject: [Openvpn-devel] [PATCH v3] dco: fix source IP selection when multihome X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: <openvpn-devel.lists.sourceforge.net> List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>, <mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe> List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel> List-Post: <mailto:openvpn-devel@lists.sourceforge.net> List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help> List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>, <mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1825179422625280206?= X-GMAIL-MSGID: =?utf-8?q?1825179422625280206?= |
Series |
[Openvpn-devel,v3] dco: fix source IP selection when multihome
|
expand
|
diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c index 02fae816..d6e8ec5f 100644 --- a/src/openvpn/dco.c +++ b/src/openvpn/dco.c @@ -562,7 +562,7 @@ dco_multi_get_localaddr(struct multi_context *m, struct multi_instance *mi, { struct sockaddr_in *sock_in4 = (struct sockaddr_in *)local; #if defined(HAVE_IN_PKTINFO) && defined(HAVE_IPI_SPEC_DST) - sock_in4->sin_addr = actual->pi.in4.ipi_addr; + sock_in4->sin_addr = actual->pi.in4.ipi_spec_dst; #elif defined(IP_RECVDSTADDR) sock_in4->sin_addr = actual->pi.in4; #else
When multihome option is enabled, OpenVPN passes ipi_addr to DCO, which is always 0.0.0.0. It should use ipi_spec_dst instead. Signed-off-by: Qingfang Deng <dqfext@gmail.com> --- src/openvpn/dco.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)