From patchwork Mon Mar 24 13:54:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4191 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:81e:b0:60a:d70a:d3c7 with SMTP id jj30csp1902083mab; Mon, 24 Mar 2025 06:54:53 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXi0XGKwgfiH+LO3t46locjjmgIJNHAIeRnG7MF/M/IbfRkpN4js2a6Bmx59Wy60dxvqoyVRSIrXlU=@openvpn.net X-Google-Smtp-Source: AGHT+IG3t9m0hfZGWzzw6g6lCN5GdCmH43kvOjh3XEoUHH9pRrYA88SvzlXZ0XczUT56jgxZNcax X-Received: by 2002:a05:6e02:3785:b0:3d4:6f9d:c0d0 with SMTP id e9e14a558f8ab-3d5960e27aemr131820745ab.8.1742824493125; Mon, 24 Mar 2025 06:54:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1742824493; cv=none; d=google.com; s=arc-20240605; b=CFAnlbdPnIIWRbVAIAzExm1S279klwQffXMb433nKdYT/QKLYYmhJumhz9/jMsl27N i43Cav8MsL6bAfAIb5w74xBMVguCzHeMppkUtrf1cXuFRrnfd0sOU40V++xCGBNYyAFG JJKfn6ALw67/tmtQJB+rcgFcsMUSbl85hB/LdbvzyRyi3rbwTfaJqCkdYSaB7O9q4ks1 jE1QfYiz7UNyBuoElMFIHfyoMdOg4wBUs599VGq0RDKYOYrp4OFYZtv4kyRW21EFSyNG cB2F8wItFsuqP5nD9hlGiNznRdnuB5lrNv3+NeNlOzi/bAFaLpdyBGeCo6Uc81+Qzmvv TSUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature; bh=473xAwoWXxvbobpfac8jchVBWyKmgUgzOpOHJmC6jzY=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=W+HZYbAICf2C92keGyN20XM6gGLL7LuvmGsNCXZMcgLZFPYfGh+pd74lztaIwYGwES TAvYHfgtNpvWmaov7igSuchlpYeI5wHl3iTA7eToMzV33lJzxswBXeAaKFdhNCKl7o4k o4fxOexrPJczqruDeUjG5KF34qa5F8XkdT3C/zz0L2BTp6yOmA3V+ZI0HpZjNYmI0uDQ D1R7ZhTz3iSDlEHx60SXeIlOVROmOK91z7Oy8S0yWhLt6uXLW88Y0xzcyS2HMZISjRSy GL/YUM6OUO9cTIdVmZos4UK8v2pjrhL1qpFrWvu7gg7+RqkiR2tCm4pOPEepFaJ+YA/L lOgw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=H0++BXd4; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=lVnHSU3v; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id e9e14a558f8ab-3d59614f30fsi92897015ab.166.2025.03.24.06.54.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Mar 2025 06:54:53 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=H0++BXd4; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=lVnHSU3v; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1twiGQ-0004Gy-PC; Mon, 24 Mar 2025 13:54:51 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1twiGP-0004Gq-Ds for openvpn-devel@lists.sourceforge.net; Mon, 24 Mar 2025 13:54:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sPnLIdAOmGTrxjTGIiRrj0AnT8xpARho6EACGWssyfQ=; b=H0++BXd4A99aLvuZYEvFipRT9j zPuR4dSyJPcdf6X6MUZ9RqTFWnXl4g7Vl2eaC4Ao/NrYJs0ZhtH01XUD+8J/V2K9zHvyH8T8LpeLU dZaWxud8sbexx/iSyI114mF//lOETsxjvys7VUYYP8Ts3eR20n03cM/og2iwuM8nn2Es=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sPnLIdAOmGTrxjTGIiRrj0AnT8xpARho6EACGWssyfQ=; b=lVnHSU3vYN6iDgwvljS6WVcv9V WsjXJn/01xxh4hwwpIHly5sS9oUcvVxvtOSRuOXqW12CWXo1+NhpDA2zrChDM33LKUPNv1H9lv6V7 gRiYobUN2UJ5Ei77fQotwUgDmqe/huQgr7fQlsGMRdktXF7bnGmhAGmpyDbiWazq+WPg=; Received: from dhcp-174.greenie.muc.de ([193.149.48.174] helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1twiGP-0007AV-2X for openvpn-devel@lists.sourceforge.net; Mon, 24 Mar 2025 13:54:49 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 52ODsgwK026808 for ; Mon, 24 Mar 2025 14:54:42 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 52ODsgKb026807 for openvpn-devel@lists.sourceforge.net; Mon, 24 Mar 2025 14:54:42 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 24 Mar 2025 14:54:33 +0100 Message-ID: <20250324135441.26725-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Arne Schwabe - Mention that pushing auth-token-user only happens when OpenVPN also generates the auth-token. - mention that OpenVPN will only accept the original and overridden username from a client - suggest to [...] Content analysis details: (0.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.174 listed in bl.score.senderscore.com] X-Headers-End: 1twiGP-0007AV-2X Subject: [Openvpn-devel] [PATCH v1] Improve documentation for override-username X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1827483935944177550?= X-GMAIL-MSGID: =?utf-8?q?1827483935944177550?= From: Arne Schwabe - Mention that pushing auth-token-user only happens when OpenVPN also generates the auth-token. - mention that OpenVPN will only accept the original and overridden username from a client - suggest to use auth-token-user when a user generates the auth-token Change-Id: Ifc7443974345042ab9945d6a10e1d1b4525e5e05 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/914 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/doc/man-sections/server-options.rst b/doc/man-sections/server-options.rst index e93b04d..ccc1374 100644 --- a/doc/man-sections/server-options.rst +++ b/doc/man-sections/server-options.rst @@ -432,7 +432,12 @@ The changed username will be picked up by the status output and also by the ``--auth-gen-token`` option. It will also be pushed to the client - using ``--auth-token-user``. + using ``--auth-token-user`` if ``--auth-gen-token`` is enabled. + + Internally on all subsequent renegotiations the client provided username + will be replaced by the username provided by ``--override-username``. + If the client changes to a username that is different from both the initial + and the overridden username, the client will be rejected. Special care should be taken that both the initial username of the client and the overridden username are handled correctly when using @@ -444,6 +449,10 @@ can be used for ``--auth-gen-token`` to allow providing a username in these scenarios. + If the ``--auth-token`` directive is pushed by another script/plugin or + management interface, consider also generating and pushing + ``--auth-token-user``. + --port-share args Share OpenVPN TCP with another service