[Openvpn-devel,v1] Remove UINT8_MAX definition

Message ID 20250415155259.12601-1-gert@greenie.muc.de
State Accepted
Headers show
Series [Openvpn-devel,v1] Remove UINT8_MAX definition | expand

Commit Message

Gert Doering April 15, 2025, 3:52 p.m. UTC
From: Lev Stipakov <lev@openvpn.net>

Because this is a part of C99 if uint8_t is available.

Change-Id: I37482a8c322680add00bab52272f9945fbb3bd09
Signed-off-by: Lev Stipakov <lev@openvpn.net>
Acked-by: Gert Doering <gert@greenie.muc.de>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/940
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Comments

Gert Doering April 15, 2025, 6:11 p.m. UTC | #1
Simple enough :-) - buildbots say that all supported platform are fine
with this change.

Your patch has been applied to the master branch.

commit ea1e6490a69b6209d6f972a50df8a0d05cb3d27e
Author: Lev Stipakov
Date:   Tue Apr 15 17:52:53 2025 +0200

     Remove UINT8_MAX definition

     Signed-off-by: Lev Stipakov <lev@openvpn.net>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20250415155259.12601-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31440.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c
index bd7a449..a0c22b1 100644
--- a/src/openvpn/socket.c
+++ b/src/openvpn/socket.c
@@ -3036,10 +3036,6 @@ 
     return BSTR(&buffer);
 }
 
-#ifndef UINT8_MAX
-#define UINT8_MAX 0xff
-#endif
-
 /* add some offset to an ipv6 address
  * (add in steps of 8 bits, taking overflow into next round)
  */