From patchwork Wed May 28 11:59:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4267 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:ea43:b0:667:60b:5921 with SMTP id ou3csp634809mab; Wed, 28 May 2025 05:00:05 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX64KsYcF3Qf240N+tqTWMFOSrghOGn6l1WTLjGL3dhcByr++fK6g7msGFQ6STsK0cQim7tglNa11M=@openvpn.net X-Google-Smtp-Source: AGHT+IGzIrKr8Vzq1MHrzVDLEEAeZlxgFw+A+C3Vc2ctox5z6HHON7TBbukWeoZWp6cJLXb+707x X-Received: by 2002:a05:6e02:4cc:b0:3d9:2992:671b with SMTP id e9e14a558f8ab-3dd87614c8cmr33118625ab.4.1748433605278; Wed, 28 May 2025 05:00:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1748433605; cv=none; d=google.com; s=arc-20240605; b=PxhNZUSVciY23Tp65cz5p2gjdMSEm3KUALfGk+YuQEtQG8iC/0v1eK7gMqhNqZcA1s GfG1fOeRRBkc5dDcEsfnpqn9FOxKJvMU4fATKkPU+eczhQps/qNvBsrSwZEQkJhAq9BW fGAVhRHpqhQmecUNPOs3jQfddlSE7noCI6OytRzKQmpFxhYgs4uqy74pC6LZr+BAeq3m bpVm+361PzRxRUJWtxW7eygffpkZQlfzgGvi0RRQYwTLX5OymiMjgQaEGpi+HZmt/3Po 9cSYmnguBeMtWGlOUYpo7DJjj3/v0aGE8W575FYUfgZyMBobFW+XOxWw9iPs+wxtLwMl d6Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=xkmRHVKiaXQ8eFDP0tohNXDLy2bZ5SYEqJ6nzj6ti7Y=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=GwJQHunWONLP5fx0SHcs/bhn2oo43EwvQhAgnGJfltkk7wx7bSlbOflvcFPSdKnEnD lcw+rvAlxWr0Svf0iNUPZhSVmVLOVxgAintepEGKeyfMn/Dv5ZmNbn3quVa/qVz0NaEh pQ2cEYB4hl3ejrbRzDMWFjLTheW6vxFIDy7NZ7Y3mulQ2DcRLUMRf6DQxw8XhxuNy/DG ZA5kSQaFKt1p5pqGzD/Jjtw4i4Ct6DQq+UjPeig+fP1+OCRU1QinRKBnwfZz+RfBDX38 MIyFzGXpMhQYx5fJSizotIVejLlVudHnnS9ld0uItPiOiT/2IflWUtkZ4S6nMCRy2HnU 1e/Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=ghTd8SBD; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="I4YgO/Rb"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=D7zT1E7H; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id e9e14a558f8ab-3dd8c1fa1e0si8589895ab.126.2025.05.28.05.00.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 May 2025 05:00:04 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=ghTd8SBD; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="I4YgO/Rb"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=D7zT1E7H; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xkmRHVKiaXQ8eFDP0tohNXDLy2bZ5SYEqJ6nzj6ti7Y=; b=ghTd8SBDCz43ynUZ93fa+0c1Tb ZcLxamQSgagsy6AkLvhswo4WeYJcj/RiDo7MUOFN0EJmyexTCOZohLSrLDMBXMjeGKrQI6eSPYRAK /ELbt/j5avLNKbsof673DbL+ZaQcriDQUQeIeVOuYZfY583Z6MiuDkkdy9Zt2EkXqywA=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uKFRy-0006DJ-CS; Wed, 28 May 2025 12:00:02 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uKFRv-0006CS-Vv for openvpn-devel@lists.sourceforge.net; Wed, 28 May 2025 11:59:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/CsRT+Ito+jWMPa7PU0r4nNAyaHw4Jiv+nSMZgdCjZE=; b=I4YgO/Rb+jfo/AaIvwUEtx9yRU Q1LmnZN8pERvxKsE1tdAvyd9vRS5fhTbDQZfDaBd3RsraiV+44b6ANgjzdMLyKG0ZEm8znxM4Kn32 oaQzb1z6PeWExxqzViVwErREEpmAEcWt/TQiScRylkc9SbzQrwPnW+g7ZWMs4vAFDe5w=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/CsRT+Ito+jWMPa7PU0r4nNAyaHw4Jiv+nSMZgdCjZE=; b=D7zT1E7Hb5uAylVKzGGJwZ8ef1 U7XYhXpPwq9hihdSyVTERvk4xB5iB7c7j+oZ3wcQw0q/7JaMVNlJqZqmTg0AvtvDNjQWnsR/l6iMR tKLKsLCtpr4/Bqfs9MPxOh3iDFS8zhq8BdDlPSUJXGExjxBku2aoj3N0gnrGFl5ldmw4=; Received: from [193.149.48.143] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uKFRu-0000PG-BN for openvpn-devel@lists.sourceforge.net; Wed, 28 May 2025 11:59:59 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 54SBxkCa004878 for ; Wed, 28 May 2025 13:59:46 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 54SBxknf004877 for openvpn-devel@lists.sourceforge.net; Wed, 28 May 2025 13:59:46 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 28 May 2025 13:59:39 +0200 Message-ID: <20250528115945.4856-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 X-Headers-End: 1uKFRu-0000PG-BN Subject: [Openvpn-devel] [PATCH v2] Add missing header in unit tests Makefile.am X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1833365516351589185?= X-GMAIL-MSGID: =?utf-8?q?1833365516351589185?= From: Max Fillinger make distcheck fails since we are not listing all headers that are used by the unit tests. Change-Id: I674af04e1a6449544b7def0725337c3b353ea276 Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1033 This mail reflects revision 2 of this Change. Signed-off-by line for the author was added as per our policy. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/tests/unit_tests/openvpn/Makefile.am b/tests/unit_tests/openvpn/Makefile.am index 471389b..c6c1699 100644 --- a/tests/unit_tests/openvpn/Makefile.am +++ b/tests/unit_tests/openvpn/Makefile.am @@ -43,7 +43,8 @@ argv_testdriver_CFLAGS = -I$(top_srcdir)/src/openvpn -I$(top_srcdir)/src/compat @TEST_CFLAGS@ argv_testdriver_LDFLAGS = @TEST_LDFLAGS@ -L$(top_srcdir)/src/openvpn -Wl,--wrap=parse_line -argv_testdriver_SOURCES = test_argv.c mock_msg.c mock_msg.h \ +argv_testdriver_SOURCES = test_argv.c \ + mock_msg.c mock_msg.h test_common.h \ mock_get_random.c \ $(top_srcdir)/src/openvpn/platform.c \ $(top_srcdir)/src/openvpn/buffer.c \ @@ -52,7 +53,8 @@ buffer_testdriver_CFLAGS = -I$(top_srcdir)/src/openvpn -I$(top_srcdir)/src/compat @TEST_CFLAGS@ buffer_testdriver_LDFLAGS = @TEST_LDFLAGS@ -L$(top_srcdir)/src/openvpn -Wl,--wrap=parse_line -buffer_testdriver_SOURCES = test_buffer.c mock_msg.c mock_msg.h \ +buffer_testdriver_SOURCES = test_buffer.c \ + mock_msg.c mock_msg.h test_common.h \ mock_get_random.c \ $(top_srcdir)/src/openvpn/win32-util.c \ $(top_srcdir)/src/openvpn/platform.c @@ -61,7 +63,8 @@ -I$(top_srcdir)/include -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/openvpn \ @TEST_CFLAGS@ crypto_testdriver_LDFLAGS = @TEST_LDFLAGS@ -crypto_testdriver_SOURCES = test_crypto.c mock_msg.c mock_msg.h \ +crypto_testdriver_SOURCES = test_crypto.c \ + mock_msg.c mock_msg.h test_common.h \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/crypto.c \ $(top_srcdir)/src/openvpn/crypto_mbedtls.c \ @@ -78,8 +81,10 @@ -I$(top_srcdir)/include -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/openvpn \ @TEST_CFLAGS@ ssl_testdriver_LDFLAGS = @TEST_LDFLAGS@ $(OPTIONAL_CRYPTO_LIBS) -ssl_testdriver_SOURCES = test_ssl.c mock_msg.c mock_msg.h \ - mock_management.c mock_ssl_dependencies.c mock_win32_execve.c \ +ssl_testdriver_SOURCES = test_ssl.c \ + mock_msg.c mock_msg.h test_common.h \ + mock_management.c \ + mock_ssl_dependencies.c mock_win32_execve.c \ $(top_srcdir)/src/openvpn/argv.c \ $(top_srcdir)/src/openvpn/base64.c \ $(top_srcdir)/src/openvpn/buffer.c \ @@ -114,7 +119,8 @@ -I$(top_srcdir)/include -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/openvpn \ @TEST_CFLAGS@ packet_id_testdriver_LDFLAGS = @TEST_LDFLAGS@ -packet_id_testdriver_SOURCES = test_packet_id.c mock_msg.c mock_msg.h \ +packet_id_testdriver_SOURCES = test_packet_id.c \ + mock_msg.c mock_msg.h test_common.h \ mock_get_random.c \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/otime.c \ @@ -156,7 +162,8 @@ -Wl,--wrap=buffer_write_file \ -Wl,--wrap=parse_line \ -Wl,--wrap=rand_bytes -tls_crypt_testdriver_SOURCES = test_tls_crypt.c mock_msg.c mock_msg.h \ +tls_crypt_testdriver_SOURCES = test_tls_crypt.c \ + mock_msg.c mock_msg.h test_common.h \ mock_win32_execve.c \ $(top_srcdir)/src/openvpn/argv.c \ $(top_srcdir)/src/openvpn/base64.c \ @@ -229,7 +236,8 @@ @TEST_CFLAGS@ $(OPTIONAL_CRYPTO_CFLAGS) pkcs11_testdriver_LDFLAGS = @TEST_LDFLAGS@ \ $(OPTIONAL_CRYPTO_LIBS) -pkcs11_testdriver_SOURCES = test_pkcs11.c mock_msg.c \ +pkcs11_testdriver_SOURCES = test_pkcs11.c \ + mock_msg.c test_common.h \ pkey_test_utils.c cert_data.h mock_get_random.c \ $(top_srcdir)/src/openvpn/xkey_helper.c \ $(top_srcdir)/src/openvpn/xkey_provider.c \ @@ -251,7 +259,8 @@ auth_token_testdriver_LDFLAGS = @TEST_LDFLAGS@ \ $(OPTIONAL_CRYPTO_LIBS) -auth_token_testdriver_SOURCES = test_auth_token.c mock_msg.c \ +auth_token_testdriver_SOURCES = test_auth_token.c \ + mock_msg.c test_common.h \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/crypto.c \ $(top_srcdir)/src/openvpn/crypto_epoch.c \ @@ -269,7 +278,8 @@ @TEST_CFLAGS@ user_pass_testdriver_LDFLAGS = @TEST_LDFLAGS@ -user_pass_testdriver_SOURCES = test_user_pass.c mock_msg.c \ +user_pass_testdriver_SOURCES = test_user_pass.c \ + mock_msg.c test_common.h \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/console.c \ $(top_srcdir)/src/openvpn/env_set.c \ @@ -287,7 +297,8 @@ ncp_testdriver_LDFLAGS = @TEST_LDFLAGS@ \ $(OPTIONAL_CRYPTO_LIBS) -ncp_testdriver_SOURCES = test_ncp.c mock_msg.c \ +ncp_testdriver_SOURCES = test_ncp.c \ + mock_msg.c test_common.h \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/crypto.c \ $(top_srcdir)/src/openvpn/crypto_epoch.c \ @@ -306,7 +317,8 @@ misc_testdriver_LDFLAGS = @TEST_LDFLAGS@ -misc_testdriver_SOURCES = test_misc.c mock_msg.c \ +misc_testdriver_SOURCES = test_misc.c \ + mock_msg.c test_common.h \ mock_get_random.c \ $(top_srcdir)/src/openvpn/buffer.c \ $(top_srcdir)/src/openvpn/options_util.c \