From patchwork Mon Jun 2 15:38:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4273 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:9994:b0:667:60b:5921 with SMTP id d20csp2647532mav; Mon, 2 Jun 2025 08:39:17 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXNiYABDka5GuIUrQd3VaeDOq3o0dN4CrYVKuWSS3YkSOVTjYnAN4rhhx+8O6b/WU1jYI4g+lDA1+4=@openvpn.net X-Google-Smtp-Source: AGHT+IFCt4N4N8oqxS7OV8x5KIkcLjBj33XSiASCJBdRUbjphRevfoHdMOfC9zxc/Ur1WnfDMQuQ X-Received: by 2002:a05:6830:6609:b0:72b:9180:cc75 with SMTP id 46e09a7af769-73758b62861mr5136361a34.7.1748878757233; Mon, 02 Jun 2025 08:39:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1748878757; cv=none; d=google.com; s=arc-20240605; b=E2XaLlcRtYu8EkFGV/maKm6Wb3EprLjwwIUSiW8uMLCjtUG9jOgByrg+FSP+13lv2z 8G2TM/2VuY2FNKtsaj8heLrwND3k/JTMILedsCnP4+yLZaY8Zyj9Y3jtuyMgw2Cf9Eka ixTwUhe66OYsToUTXt10W7SmeveDpnPAtvwgwaaxPZ0lUy4dxJBHXZdGvJ61oCnSz9E8 Nw6YSTnHo3+pYuPW2dOvjvGhUvGO4B7RJmar+Avx/gyWpZnhD/NcCZGHOU231EB/jV4U /DT2pB53wvAr0X2WxLz1AzD7PQ1BBF801WaOwUK3UUNzcRmhL2wlUpIVeLkngsWuQSSr WLJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=mZQIdYyO0dcOVIKSgfrmivFB2OD+ECe55+0LcJdvB4w=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=KoKsJLUNtuFHXzSQ0lqHFRDnUQUeC2XpCUR35GzCHYtrfiTL7rDVPpTimaocx8GHQO Fy92HiFzMcVUvWxd9752JQx9d1wwa42ofNFbph4O/JNfuA+IMB2Jrur0x8srJwUswtLi a4u2ljWr8kMWk++Ygl6KTSaJuJmqYqnzNthEUM23/07CQzVX/7DMPvdpXVFl20bz0LmM rvLlg6TLOuZzV5FSLpCircXuo4A8KG9M8mtHqMpadCKXvkMkJumHCP3HRUngRCZ/T8su dgvVacErUtOOFGbtWoRQB8Vw3p1hMi0/MQkfKtzCt8c5wWc/C8db9k3s8jxoiYSATBE4 EWNQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="HsJ/ikEx"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=f7Io8h9R; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=AP9soTvJ; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-735afa0ce10si4873237a34.295.2025.06.02.08.39.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Jun 2025 08:39:17 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="HsJ/ikEx"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=f7Io8h9R; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=AP9soTvJ; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mZQIdYyO0dcOVIKSgfrmivFB2OD+ECe55+0LcJdvB4w=; b=HsJ/ikExguX4UX/TD5cxW/IaLy ErRa1DsZ4L2Nt6FZj5ozg6coZnMHagIor8+cPKvZbtuYAZsjo2OTt4P08H/vaI5a56i1NOVuLo5u+ mHJplmf9nCv1HoWIjy1Ek32Zb/ZU27Tv/WkwlnIomiY+SYEmh+yzg8lDkRBUSX1BH1y4=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uM7Fr-0001R2-DP; Mon, 02 Jun 2025 15:39:15 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uM7Fp-0001Qt-Em for openvpn-devel@lists.sourceforge.net; Mon, 02 Jun 2025 15:39:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WMOB2ZknGPVjWh1tHQyIFiCVxrAYZ5oYxXmX7qlDL8Q=; b=f7Io8h9RkruIXjPpBBBP8rUIEW 3F2yh7XBkD5dSbDubT1LZoqkLueQ5Ry8uHBl/VREFutJPa8l7XS6eakrb/s1iooJyKSRlmE8EyRUU MOCT175Dp8BdjXhgQunkqcv2Linnz1T6kYHQtvjejpem/l90bUnKRypJUIT6NTCxelm0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WMOB2ZknGPVjWh1tHQyIFiCVxrAYZ5oYxXmX7qlDL8Q=; b=AP9soTvJq3PrwCxaDIaw9f1Oys 7FSk/8xYSkzC2E5LczUyVZyNoWs8JQhVdcDeBkfkZRKMLsM34dE3YGPfGfmvmy8oUeYKgHevqRyY2 lJZmzPYh+Fk9wy6TFdXZuzqpt2wO4F+X5672xXnoPtQBnsQxR4z8I/zFEyDn9VOKGjic=; Received: from [193.149.48.143] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uM7Fo-0006YO-D0 for openvpn-devel@lists.sourceforge.net; Mon, 02 Jun 2025 15:39:13 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 552Fd0gE029663 for ; Mon, 2 Jun 2025 17:39:00 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 552Fd0vO029661 for openvpn-devel@lists.sourceforge.net; Mon, 2 Jun 2025 17:39:00 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 2 Jun 2025 17:38:54 +0200 Message-ID: <20250602153900.29646-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld This file is apparently over 20 years old and was never updated besides fixing some obvious syntax errors with new versions. So let's just get rid of it. AFAICT the Windows installer does not use it. Only the {server,client}.ovpn. And even there, it just uses the files directly from the build directory and does not depend o [...] Content analysis details: (1.7 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.4 NO_DNS_FOR_FROM DNS: Envelope sender has no MX or A DNS records 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_FAIL SPF: HELO does not match SPF record (fail) [SPF failed: Rejected by SPF record] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.143 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.149.48.143 listed in bl.score.senderscore.com] 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1uM7Fo-0006YO-D0 Subject: [Openvpn-devel] [PATCH v3] Delete old sample-windows file and obsolete Windows sample handling X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1833832291781000939?= X-GMAIL-MSGID: =?utf-8?q?1833832291781000939?= From: Frank Lichtenheld This file is apparently over 20 years old and was never updated besides fixing some obvious syntax errors with new versions. So let's just get rid of it. AFAICT the Windows installer does not use it. Only the {server,client}.ovpn. And even there, it just uses the files directly from the build directory and does not depend on us renaming them (which is obvious since we do not use the Makefile at all in the Windows build, only CMake). Github: Closes OpenVPN/openvpn#758 Change-Id: I15c730c9eb3f1338019577e7c665c0ca5b1edcd4 Signed-off-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1036 This mail reflects revision 3 of this Change. Acked-by according to Gerrit (reflected above): diff --git a/sample/Makefile.am b/sample/Makefile.am index 9443cf3..4ed78a6e 100644 --- a/sample/Makefile.am +++ b/sample/Makefile.am @@ -18,20 +18,5 @@ EXTRA_DIST = \ sample-plugins \ sample-config-files \ - sample-windows \ sample-keys \ sample-scripts - -if WIN32 -sample_DATA = \ - client.ovpn \ - server.ovpn \ - sample-windows/sample.ovpn - -client.ovpn: sample-config-files/client.conf - -rm -f client.ovpn - cp "$(srcdir)/sample-config-files/client.conf" client.ovpn -server.ovpn: sample-config-files/server.conf - -rm -f server.ovpn - cp "$(srcdir)/sample-config-files/server.conf" server.ovpn -endif diff --git a/sample/sample-windows/sample.ovpn b/sample/sample-windows/sample.ovpn deleted file mode 100755 index be24faa..0000000 --- a/sample/sample-windows/sample.ovpn +++ /dev/null @@ -1,102 +0,0 @@ -# Edit this file, and save to a .ovpn extension -# so that OpenVPN will activate it when run -# as a service. - -# Change 'myremote' to be your remote host, -# or comment out to enter a listening -# server mode. -remote myremote - -# Uncomment this line to use a different -# port number than the default of 1194. -; port 1194 - -# Choose one of three protocols supported by -# OpenVPN. If left commented out, defaults -# to udp. -; proto [tcp-server | tcp-client | udp] - -# You must specify one of two possible network -# protocols, 'dev tap' or 'dev tun' to be used -# on both sides of the connection. 'tap' creates -# a VPN using the ethernet protocol while 'tun' -# uses the IP protocol. You must use 'tap' -# if you are ethernet bridging or want to route -# broadcasts. 'tun' is somewhat more efficient -# but requires configuration of client software -# to not depend on broadcasts. Some platforms -# such as Solaris, OpenBSD, and Mac OS X only -# support 'tun' interfaces, so if you are -# connecting to such a platform, you must also -# use a 'tun' interface on the Windows side. - -# Enable 'dev tap' or 'dev tun' but not both! -dev tap - -# This is a 'dev tap' ifconfig that creates -# a virtual ethernet subnet. -# 10.3.0.1 is the local VPN IP address -# and 255.255.255.0 is the VPN subnet. -# Only define this option for 'dev tap'. -ifconfig 10.3.0.1 255.255.255.0 - -# This is a 'dev tun' ifconfig that creates -# a point-to-point IP link. -# 10.3.0.1 is the local VPN IP address and -# 10.3.0.2 is the remote VPN IP address. -# Only define this option for 'dev tun'. -# Make sure to include the "tun-mtu" option -# on the remote machine, but swap the order -# of the ifconfig addresses. -;tun-mtu 1500 -;ifconfig 10.3.0.1 10.3.0.2 - -# If you have fragmentation issues or misconfigured -# routers in the path which block Path MTU discovery, -# lower the TCP MSS and internally fragment non-TCP -# protocols. -;fragment 1300 -;mssfix - -# If you have set up more than one TAP-Win32 adapter -# on your system, you must refer to it by name. -;dev-node my-tap - -# You can generate a static OpenVPN key -# by selecting the Generate Key option -# in the start menu. -# -# You can also generate key.txt manually -# with the following command: -# openvpn --genkey secret key.txt -# -# key must match on both ends of the connection, -# so you should generate it on one machine and -# copy it to the other over a secure medium. -# Place key.txt in the same directory as this -# config file. -secret key.txt - -# Uncomment this section for a more reliable -# detection when a system loses its connection. -# For example, dial-ups or laptops that travel -# to other locations. -# -# If this section is enabled and "myremote" -# above is a dynamic DNS name (i.e. dyndns.org), -# OpenVPN will dynamically "follow" the IP -# address of "myremote" if it changes. -; ping-restart 60 -; ping-timer-rem -; persist-tun -; resolv-retry 86400 - -# keep-alive ping -ping 10 - -# enable LZO compression -comp-lzo - -# moderate verbosity -verb 4 -mute 10