Message ID | 20250630164207.10477-1-gert@greenie.muc.de |
---|---|
State | New |
Headers | show
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net> Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:3846:b0:671:5a2c:6455 with SMTP id n6csp2638343mal; Mon, 30 Jun 2025 09:42:26 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWSKUVAnf+q60l/lKLN0MBvruOvc0SiW56z81N38RVGG+4vADHXr9TLyNDiqEp+lJbhnCXUyoCoVVs=@openvpn.net X-Google-Smtp-Source: AGHT+IGKmAJrsPnjaGUGsKuWTASm9fl2B+EqNj3jp+WC3yAoAJrGCzHiU2wiRfdEVDZbhTQ0txc+ X-Received: by 2002:a05:6830:61cc:b0:72b:9df9:f7d1 with SMTP id 46e09a7af769-73afc69c0eemr9785737a34.26.1751301746502; Mon, 30 Jun 2025 09:42:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1751301746; cv=none; d=google.com; s=arc-20240605; b=NJaY3l5NFSpq2lH6E1nmW5ch5DGOi5v6nRSINXWSzvtHxvafM+zWzSVYCzWjRlOb/j HuXj9dgOfV0rC7vQDjui94aCuho5hr3ncO6Ev2ACQC46Wl9AYPs8fKIlOcKnbm1tYFXR g0PW2z4r5nEfKSWj4qG/eQX8uPIBP8SPrzDDwo0ifvPnUTRqrJIaO+mJ1z9oIRsBOUMs YMCmWluOp2dGD8HJf+BgPE29/eaCZAJYIyiAJM6JpJ29ARlKqzZ/LrPHiaVPNaLQWjMT T9NCNUFpPjzyvml3Rc6TNluLEIZiok31pcC1ihwoWap+BsHqWk+YTENzi7Qemp3xyXLn zsXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=EsoL8zn/4ThhnFYcmRgfvaLqVqunSV2b9aTPwOOIsaI=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=OrwF+PWRXsbmaE+so3+2RfFzP1UcXN7DnU4CsTR6kvQZkE+vIQx8F1JBJZXhFtbkz1 57GcJsnaB6mGfQDf0+zty0rnNk4qMonMm7YEDzotTA9SrfChF9Nst9Q/X3jfyPGK9rC2 zkZR88Zw9y1EhnG3Dp83fZvS3aGGp+O2t5Bcr7d9uTIilZxQkBwFhnippy02b7YJ3sbt mC8gvfKr7Qni9fLl6e/kVLO+X5KSRzfydq063grFUScqag66fyDYgD8vm+CCdqKoTP5D 6y0aog91oTZw1WqhxeNi7ShKpkN87TjpKQIaYVp6mlqKSoUN2Iz0ytnkoPtPalfZLrgd B8YA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Oeko84yL; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="Tw/j/Qj2"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=JDbcDqxw; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-73afb1003dcsi5257059a34.256.2025.06.30.09.42.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jun 2025 09:42:26 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Oeko84yL; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="Tw/j/Qj2"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=JDbcDqxw; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EsoL8zn/4ThhnFYcmRgfvaLqVqunSV2b9aTPwOOIsaI=; b=Oeko84yL5jHbOFTanNlLTdALdu crJOmXn6FUst+tUvTKQR+LSmhbp5ES04Y3telYsA3laupuDDNrHlw3DUYa7C6J7KVuTbndjJxYiej nkeW7JYwa+pXAH3AJMMCDoNA9JDsC2C0q3Dtnax64JmT82yFHGWVQSvCo6jXdpKHXGxs=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from <openvpn-devel-bounces@lists.sourceforge.net>) id 1uWHaJ-0000WD-CW; Mon, 30 Jun 2025 16:42:23 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from <gert@blue4.greenie.muc.de>) id 1uWHaH-0000W6-Re for openvpn-devel@lists.sourceforge.net; Mon, 30 Jun 2025 16:42:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=p1V9a4FypYo754GOQ2/lZpwhHYbJxwu5iTnEgzu2wwI=; b=Tw/j/Qj2h7/ow/o5Z/7liwCAJk F1jzWfKnMx7OmkazxZIM7UQYoItiwo1PSafrARYnv8WFkHvWw0k5pHBKm/SgxYcI18l/55FfQvORU S/KKq91T0uUOo1E3cr8mM1LNwNf3hln0YYjcrKsCfsXrLMTGm9gF17QObX8yv8BCQBOw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=p1V9a4FypYo754GOQ2/lZpwhHYbJxwu5iTnEgzu2wwI=; b=JDbcDqxwxO6QBhmmCiWNTSWLJ3 gqsXTG4J+PEAmPirwZ1h0DEiIgkPi4wNSZTLlwNuONVnvoqGTJlM10Ji21sUCwDa4+eAw62MOmh1M nwhe/lTpqIXDEfdS6bZBJ/OvOR9NnwkgBDWm24JSJXNsNJfP0jWp6DjlwHzk32J6PmBc=; Received: from [193.149.48.143] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uWHaG-0005fy-Nz for openvpn-devel@lists.sourceforge.net; Mon, 30 Jun 2025 16:42:21 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 55UGg8s3010509 for <openvpn-devel@lists.sourceforge.net>; Mon, 30 Jun 2025 18:42:08 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 55UGg8P0010508 for openvpn-devel@lists.sourceforge.net; Mon, 30 Jun 2025 18:42:08 +0200 From: Gert Doering <gert@greenie.muc.de> To: openvpn-devel@lists.sourceforge.net Date: Mon, 30 Jun 2025 18:42:01 +0200 Message-ID: <20250630164207.10477-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <gerrit.1751292607000.I3bed9c7aafee8e62ddae14c0d3e21cf4c146a37c@gerrit.openvpn.net> References: <gerrit.1751292607000.I3bed9c7aafee8e62ddae14c0d3e21cf4c146a37c@gerrit.openvpn.net> MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld <frank@lichtenheld.com> Broken since commit bc62a9a02cb7365a678bcd3f2faf537a420cc5a0 "Add methods to read/write packet ids for epoch data" Change-Id: I3bed9c7aafee8e62ddae14c0d3e21cf4c146a37c Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com> Acked-by: Gert Doering <gert@greenie.muc.de> --- Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1uWHaG-0005fy-Nz Subject: [Openvpn-devel] [PATCH v1] packet_id: Fix build with --disable-debug X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: <openvpn-devel.lists.sourceforge.net> List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>, <mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe> List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel> List-Post: <mailto:openvpn-devel@lists.sourceforge.net> List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help> List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>, <mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1836372979842595232?= X-GMAIL-MSGID: =?utf-8?q?1836372979842595232?= |
Series |
[Openvpn-devel,v1] packet_id: Fix build with --disable-debug
|
expand
|
"Obviously correct" ;-) - not tested beyond what the buildbots do anyway. Your patch has been applied to the master branch. commit 16c1da39e93578766acd6ba085f4960190fd6220 Author: Frank Lichtenheld Date: Mon Jun 30 18:42:01 2025 +0200 packet_id: Fix build with --disable-debug Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: <20250630164207.10477-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32013.html Signed-off-by: Gert Doering <gert@greenie.muc.de> -- kind regards, Gert Doering
diff --git a/src/openvpn/packet_id.c b/src/openvpn/packet_id.c index c8dae32..76a81c6 100644 --- a/src/openvpn/packet_id.c +++ b/src/openvpn/packet_id.c @@ -673,6 +673,8 @@ gc_free(&gc); } +#endif /* ifdef ENABLE_DEBUG */ + uint16_t packet_id_read_epoch(struct packet_id_net *pin, struct buffer *buf) { @@ -711,6 +713,3 @@ return buf_write(buf, &net_id, sizeof(net_id)); } - - -#endif /* ifdef ENABLE_DEBUG */