[Openvpn-devel,v1] packet_id: Fix build with --disable-debug

Message ID 20250630164207.10477-1-gert@greenie.muc.de
State New
Headers show
Series [Openvpn-devel,v1] packet_id: Fix build with --disable-debug | expand

Commit Message

Gert Doering June 30, 2025, 4:42 p.m. UTC
From: Frank Lichtenheld <frank@lichtenheld.com>

Broken since commit
bc62a9a02cb7365a678bcd3f2faf537a420cc5a0
"Add methods to read/write packet ids for epoch data"

Change-Id: I3bed9c7aafee8e62ddae14c0d3e21cf4c146a37c
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1071
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Comments

Gert Doering June 30, 2025, 5:01 p.m. UTC | #1
"Obviously correct" ;-) - not tested beyond what the buildbots do
anyway.

Your patch has been applied to the master branch.

commit 16c1da39e93578766acd6ba085f4960190fd6220
Author: Frank Lichtenheld
Date:   Mon Jun 30 18:42:01 2025 +0200

     packet_id: Fix build with --disable-debug

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20250630164207.10477-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32013.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/packet_id.c b/src/openvpn/packet_id.c
index c8dae32..76a81c6 100644
--- a/src/openvpn/packet_id.c
+++ b/src/openvpn/packet_id.c
@@ -673,6 +673,8 @@ 
     gc_free(&gc);
 }
 
+#endif /* ifdef ENABLE_DEBUG */
+
 uint16_t
 packet_id_read_epoch(struct packet_id_net *pin, struct buffer *buf)
 {
@@ -711,6 +713,3 @@ 
 
     return buf_write(buf, &net_id, sizeof(net_id));
 }
-
-
-#endif /* ifdef ENABLE_DEBUG */