From patchwork Fri Jul 18 19:16:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4316 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:1914:b0:671:5a2c:6455 with SMTP id g20csp477202maz; Fri, 18 Jul 2025 12:17:23 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX1XxDjeDnVOoIvxVvyr1q7JtYaTfEOFARwXRgnrqaZMvy8Tr+T93GtEwwvb9O0K/TKaFwDkhydPuo=@openvpn.net X-Google-Smtp-Source: AGHT+IHnnKAxDU6cUM+gfRvIuFc+Pr6Wg6cgGygH48UtiSt1l6KNMFrx2/YspopZq4tGIwd7prMb X-Received: by 2002:a05:6808:148a:b0:41c:8cba:1ac9 with SMTP id 5614622812f47-41d0526d7a3mr9449709b6e.28.1752866243562; Fri, 18 Jul 2025 12:17:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1752866243; cv=none; d=google.com; s=arc-20240605; b=inLE53XrlthzX2cw5LstxSEZj1oAx8QIJYpDxtJUh/qU0MY11G8+1n5z2Dnv35SyM4 uCdBQU0x1aURr6aKfrI2K6NxKtNefbxgnN3+EqjH8OqV+oLyHqjlWTOJXeD4qrdpwQ3c g3h3OTiB9uK52igCnJ2I9UknXRnJjteg5M4o2uGOn+E/Bqtvfq6srGwbIeBPYEokpQ3G GRxF6eFtAZ90na1dGjHGxIzTf2n2/69U5+9oHoTC5hDDiwE3K7R/eTVIXLq+cuxHwEfR Srtb1s+00poN0QsGhAmBpklwjtB8lt7FlhgvaSNxIYgY7pKrPHIzDa8V9RXfJebyDO4R 2Pug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=hQueQpi8arUVEjuZgavpciBYMhFMbs2RmR8U5BkfuDQ=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=ByduGOrWi2+4pE872+9FmzMFHdKdeQmYFKDi7Dy9WDys0oNk9/ior17mB5Fsz4lWRA TUka4A1FCxhsWCq/yZqMmMXfbocmT+VFT/PodO4oLGAqGdgPEjAgQJsC0pwmp5t6Y60d jHoFucwUwzwVCTpWygyv5NjqDaSkz/oCLosKmeNpdSHGZ11EU3hoD2ae9uOj+7ntvv4E Aw7JrCJSnIJHdMDwsAAPU5nWT5qNpCm0N7ZDlwmcOslwBl0a6VZmrM6DeYKgp7/hRcZI fou/6te6HWxKb+d7lR71fDP2hzUtpSNxiIwnZye9ZcthhPwey1rKHdOS/HHB/pM6CtCs j8Hg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=ABbkKc5G; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=C7MJqlYn; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="N9P/E5nB"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-41fd4791db7si919105b6e.197.2025.07.18.12.17.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jul 2025 12:17:23 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=ABbkKc5G; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=C7MJqlYn; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="N9P/E5nB"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hQueQpi8arUVEjuZgavpciBYMhFMbs2RmR8U5BkfuDQ=; b=ABbkKc5Gbekec9jCIh1AS85DRL SwkRwddPP5taR0jbGFLy8ttoYhHOqGwsisOBGKMyw+163qUCAXyZr//HLXWeeYkrtoiPar4req1PT LfcI4zXuQX7mHalIToRIy+bzM4qdn3k3ygdGcPR4laCSDaZ5gdCJObykff+V9DvrabAc=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1ucqa7-0001jB-At; Fri, 18 Jul 2025 19:17:20 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ucqa5-0001iZ-2u for openvpn-devel@lists.sourceforge.net; Fri, 18 Jul 2025 19:17:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PLZgJtrL4nWHTIU0PljIrYgMd4Jvwxq1GDPrklNjIm8=; b=C7MJqlYn9EDiIoifXU/ZyLmEoU 8BeEojWQkRh31ZFOwI9iW/12AgUbIOQphSr9yiOdWFdS/8rC/iX2l62JKJkdfpAPRMRWNkxr1CJOe WDZcAIPp6FkOkItPRZaaIwMwjRXVszv/hU3UUrw4+lHpqwcjcURsdSAv9mMw/nYcGrz0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PLZgJtrL4nWHTIU0PljIrYgMd4Jvwxq1GDPrklNjIm8=; b=N9P/E5nBwi9Fib1pN2cW66TPMj 3tYXGszqaQSX02SdKoEnI95NBBH+bztGSfCUf3/hfpck4mOj71QAS2Wkbs2qVI9hMtZ82ZIJeCyqw p9Ufk301vDc9Rx71cp1YEIoaCITfCSB+CrNSLIOc2cjGOwJPpGNQopo5wuOtMQk92wss=; Received: from [193.149.48.143] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1ucqa2-0005XT-ET for openvpn-devel@lists.sourceforge.net; Fri, 18 Jul 2025 19:17:15 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 56IJH2iB009480 for ; Fri, 18 Jul 2025 21:17:02 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.17.1.9/8.17.1.9/Submit) id 56IJH26f009478 for openvpn-devel@lists.sourceforge.net; Fri, 18 Jul 2025 21:17:02 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Fri, 18 Jul 2025 21:16:56 +0200 Message-ID: <20250718191702.9451-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Ralf Lici Extend the log message printed when an instance floats to an address already taken by another instance with the same certificate. The updated message now includes the instance being closed, the reason [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1ucqa2-0005XT-ET Subject: [Openvpn-devel] [PATCH v1] improve float collision logging X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1838013473982747699?= X-GMAIL-MSGID: =?utf-8?q?1838013473982747699?= From: Ralf Lici Extend the log message printed when an instance floats to an address already taken by another instance with the same certificate. The updated message now includes the instance being closed, the reason it's being closed, and the new instance taking over that address. Change-Id: I217cfb319b85fd75a88f7d4d50c374d28771df28 Signed-off-by: Ralf Lici Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1091 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index ead3dd0..4696686 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -3263,7 +3263,11 @@ mroute_addr_print(&mi->real, &gc)); goto done; } - msg(D_MULTI_MEDIUM, "closing instance %s", multi_instance_string(ex_mi, false, &gc)); + + msg(D_MULTI_LOW, "closing instance %s due to float collision with %s " + "using the same certificate", + multi_instance_string(ex_mi, false, &gc), + multi_instance_string(mi, false, &gc)); multi_close_instance(m, ex_mi, false); }