[Openvpn-devel,v1] unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42

Message ID 20250728104234.29797-1-gert@greenie.muc.de
State Accepted
Headers show
Series [Openvpn-devel,v1] unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42 | expand

Commit Message

Gert Doering July 28, 2025, 10:42 a.m. UTC
add <stdint.h> to test_search_and_replace.c to fix build error on
fedora 42 / arm64 ("error: uintptr_t undeclared")

Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1118
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <frank@lichtenheld.com>

Comments

Gert Doering July 28, 2025, 11 a.m. UTC | #1
It seems this would also affect feodora-42 on amd64, we just missed on
the "updates that bring in the breaking change" - but now we are prepared ;-)

Patch has been applied to the master branch.

commit 035d47e6d80996a4cde8af1b35f9ba40b676c825
Author: Gert Doering
Date:   Mon Jul 28 12:42:29 2025 +0200

     unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42

     Signed-off-by: Gert Doering <gert@greenie.muc.de>
     Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
     Message-Id: <20250728104234.29797-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32384.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
Gert Doering July 29, 2025, 10:14 a.m. UTC | #2
Hi,

(uh, forgot to send this - push has been done yesterday already)

On Mon, Jul 28, 2025 at 01:00:09PM +0200, Gert Doering wrote:
> It seems this would also affect feodora-42 on amd64, we just missed on
> the "updates that bring in the breaking change" - but now we are prepared ;-)
> 
> Patch has been applied to the master branch.
> 
> commit 035d47e6d80996a4cde8af1b35f9ba40b676c825
> Author: Gert Doering
> Date:   Mon Jul 28 12:42:29 2025 +0200

Frank has pointed out that this is the sort of maintenance fixes we 
do want in release/2.6 as well, so here we go...   tested via GHA and
local fedora42/arm64 VM

commit 5c968a361fba7362306fcd977acdff52ccb4c884 (release/2.6)
Author: Gert Doering <gert@greenie.muc.de>
Date:   Mon Jul 28 12:42:29 2025 +0200

    unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42

gert
- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             gert@greenie.muc.de

Patch

diff --git a/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c b/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c
index d40467f..50b241d 100644
--- a/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c
+++ b/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c
@@ -2,6 +2,7 @@ 
 #include <unistd.h>
 #include <stdlib.h>
 #include <stdarg.h>
+#include <stdint.h>
 #include <string.h>
 #include <setjmp.h>
 #include <cmocka.h>