From patchwork Tue Jul 29 09:39:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kristof Provost X-Patchwork-Id: 4336 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:b86:b0:671:5a2c:6455 with SMTP id mw6csp88770mab; Tue, 29 Jul 2025 03:07:23 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUlcDuzqYIj1uguvFi+VBOKkQWRNUk4SDtRVb7wWwxyKRD63IgiImudFCRnJ2z/TpoVf+pGuH1Ok4k=@openvpn.net X-Google-Smtp-Source: AGHT+IFcDxyZmGySJk5GBsc7bxPQnOowDWMDqZ8W/QtCjeAipiWnnB4UhMW1OnY65u5kN2f1fZSp X-Received: by 2002:a05:6871:606:b0:301:1218:60a0 with SMTP id 586e51a60fabf-30701b46a6dmr9691575fac.34.1753783643589; Tue, 29 Jul 2025 03:07:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1753783643; cv=none; d=google.com; s=arc-20240605; b=ONHMZswDzyucZ2lCljBtUh6oHP8tC9B/xsV1ae1aoA67dbam5VPTLqs7wr13qynKRE jSA47XKyi8/xKh/M+mZnKy11RaQwSiK8e3V9kvFvaqnrJleJ4jPAmlpmzEaD0LRwWb+O DwWC0rldBABPRzQq4uxxYZH1bbkDvbUpyXYxYH40TvOBbxmdsA6VWSDeBXD/isLRg74r TWG91GDB6WI4k6hiaeUqtWJhQF6RqAg8SSSMeMedMB6XZ/cAoea1y0wnKvqLf+p/8c7U MiPUQl9JqZ3eXgZg6lgOK6LKT8JpbpJW4Rpe+kQIVTdCkClHtnnAW64AGdDSVrhhV3Vg XVbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:reply-to:from:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:dkim-signature :dkim-signature:dkim-signature:dkim-signature; bh=cymIcfUottlfYKG20DoT1h4Z3ck0ydtW77oWEO++eOo=; fh=UWlByhJXNGJKzcJ5WmyoA1tw5ugXp4S86SRVYqcTfsM=; b=SXzRppk1f1CBNo4Iy2OQ/XroPrMWm5rlSaTO0oJPmrAc7pkFcSO9rlmtPa64Blgl0v lDhSjBdCJVZxDNGgwqryyF0OOelqPL6n02l8SFFMVtlmcGop+sJyUvziA1aFvNXWCmEV Nb2m1IqDqkiKFLcOnkY4oXBGn4R2tHwfmnAXV77t5THDXNgrRZjyWb7kQE7qMClVrZKC 4A0QQ8npQYIkWaKaR0I4wq3/URhYxOfi1wJgwt7egb8mSIXMTyWJH/5IfMogXcYBPKl8 FnvRKteGitwlXD6bplm7mu52lyFGfTxSniL/EqYXaXV1yXVpgog/K6S3P8h6CjGJUbYX VGzQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=bhZbOHPI; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=NAeeH69u; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Qfo0o+Uc; dkim=neutral (body hash did not verify) header.i=@netgate.com header.s=google header.b=mYXMjWWQ; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lists.sourceforge.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-307135a4330si2818804fac.370.2025.07.29.03.07.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jul 2025 03:07:23 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=bhZbOHPI; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=NAeeH69u; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Qfo0o+Uc; dkim=neutral (body hash did not verify) header.i=@netgate.com header.s=google header.b=mYXMjWWQ; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lists.sourceforge.net; dara=fail header.i=@openvpn.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:MIME-Version:Message-ID:Date:To:Sender:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=cymIcfUottlfYKG20DoT1h4Z3ck0ydtW77oWEO++eOo=; b=bhZbOHPIcWUTZtQrQvlnggnfzq EFjo5+D2j++XlSjGwhQnEuuJ32ZfpMbC6J7MCbviiHIVS8KQUX9XwMIAkLlIkGNbMBK58ZnVDuiKR xicKWfuX9usStc0FNeq+DeA38KDh3UtVZrzEnLJkltG/QDMH/ErAOE6wZ2og4x/62xKA=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1ughEq-0005B5-3X; Tue, 29 Jul 2025 10:07:16 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ughEp-0005Az-JF for openvpn-devel@lists.sourceforge.net; Tue, 29 Jul 2025 10:07:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=S9DAgkVoW9Vf7i7RMkzWh3rz4BJCLyWKyMVuqrxqNc4=; b=NAeeH69usYtKDZinOf1VLOcVj1 FFG2hgewNi2UbUVmx7HQ4U8hgc05gzQTUfQRR9zww88lcBWC+/Io5Leq9ewKm/uWsWX2sIqPZUlFj YHtDifMZvQVzuAzu3tnAxA3Y5bEsd0/Pw/MiHgzYtVTbSJkVUhEKc1HTSF+dwS2jhLn0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=S9DAgkVoW9Vf7i7RMkzWh3rz4BJCLyWKyMVuqrxqNc4=; b=Q fo0o+UceQBjaksN3o5YXurXDVc9wKj78rJ0Xbubf7xvkwG/rHsvzZRrbbG2cA4oVfMZCWUOgUmkhD cyTJeheucMoYN7WRP6YIpS1LgNJtFrPuLS0eQ2Ii4g+7o92oEzkB/Pg7nzO5tLHjEwUjlAZeWbaga S8Tq0TQUxkzmDG5E=; Received: from mail-wr1-f47.google.com ([209.85.221.47]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1ughEp-0000jV-3g for openvpn-devel@lists.sourceforge.net; Tue, 29 Jul 2025 10:07:15 +0000 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3b7813c7858so331657f8f.2 for ; Tue, 29 Jul 2025 03:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netgate.com; s=google; t=1753783623; x=1754388423; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=S9DAgkVoW9Vf7i7RMkzWh3rz4BJCLyWKyMVuqrxqNc4=; b=mYXMjWWQkNtCmwUfU35e10jUlccZZ1FILS5ZYno8JcWHUHPo5J6KtBqWvCAK8u9jj0 XSoFOS+GSMvwcUV29lqu2k1ySPerAmGFRSFGicaX6Vn/UW5Gn2DsGD2CfjbdoUEzmTFz SdYeyIrnE5ISXvF4RUo8M3liTvOFdGZ3o28e8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753783623; x=1754388423; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S9DAgkVoW9Vf7i7RMkzWh3rz4BJCLyWKyMVuqrxqNc4=; b=VrPvmJCCdjuWg1bPQYRERkB0DrOVrq5JST6XfgXae5Wm3liXBqRPSSfu7WqOU+iIZp jUHgHO3Wow4g5Kz4lwG2ok3zryHV37O5pgan0eszBZN5yDaLt5Gh+F9lyfMl1g1evCfX wa9F7s9uvi15rmq7a1WPlUe14HlUigsgigFYBVF89cMqqXFh4PYlWh4xrcnezKHMA0Su 6Yq5tjBNThUM9VDe85kcWM0f99EAAUQVWdCXBRH5B13Yk26qv/VDE/pk6pqeCyio2hXS rk9kiLrEwo6yV9i//uTnQVrXk+RFFFdWSqJ7yc8kmGyUcCNKRjemQqiGWWWJDp5WL1Bi liWg== X-Gm-Message-State: AOJu0YyzCprihNY6H5mkRKN1LjYiCwMemBZB6emEtW3kXoi3HSKusdty gVPJQZ7VKGo04BZO7k+bHT1bc3ASLdZog1y4Zq8QloCNsldXceHPzXuVC01oMlavA4W/877xXrU nAhKtPw== X-Gm-Gg: ASbGncsRGZvqsNK8FXPTt2RRYYZYV/kfBtibDoGJKL0a1xsWPF2EzC63bRx4M9eStu4 HrFi3HoC5Fo2Bu4A6q6RUBy9Z7cQX7VnLqd3AFu2meNG6/oHiYj7smvtQNpWTk97JCOeDQIgeaO IEkxyP93MzbLwHvJWFuoEdUDEXshUI2ZeeHwx0FiogfWe+AiOXrPza6JOQjUtKh+6xUY0a40kuA AkjPjMOVW9dJv/xQRBnwVV5GDgJk2vIAaSDiopHe+OWARIv7fs/6PEZLpRbjVUDa14kcHKrl4mC UpsI1tBDN+1eCqNDvUkTq9X0Nxiu+erB2ZSNLFcaNvc0XEnLjZFkbKBzC6aPPxbyyGUUBje9lxW rXqPI1ld1CwyISISuzgzPGGUbhXVeLzPI7fpWRDNB2iTNUL/sgphXz/qHBzR+nAArfLKwDTeYsD yKViRXidVOts4QPbIAtvLPOqP1Qd8s6q9yeZpL9A== X-Received: by 2002:a05:6000:420c:b0:3b7:9173:696c with SMTP id ffacd0b85a97d-3b79173702dmr402310f8f.8.1753781949156; Tue, 29 Jul 2025 02:39:09 -0700 (PDT) Received: from nut.jupiter.sigsegv.be (ptr-8rhf62vj1z1egmd2c2g.18120a2.ip6.access.telenet.be. [2a02:1811:2410:bf00:f602:70ff:feae:6e98]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4588e5db456sm18758655e9.26.2025.07.29.02.39.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jul 2025 02:39:08 -0700 (PDT) To: openvpn-devel Date: Tue, 29 Jul 2025 11:39:07 +0200 Message-ID: <20250729093907.37849-1-kprovost@netgate.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Kristof Provost If the kernel doesn't support it we'll simply never get the notification. In other words, there's no downside to always enabling this, so let's do that. Signed-off-by: Kristof Provost --- configure.ac | 9 --------- src/openvpn/dco_freebsd.c | 4 ---- 2 files changed, 13 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.47 listed in wl.mailspike.net] X-Headers-End: 1ughEp-0000jV-3g Subject: [Openvpn-devel] [PATCH 2/2] dco-freebsd: always enable float notification support X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kristof Provost via Openvpn-devel From: Kristof Provost Reply-To: Kristof Provost Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1838975437765304130?= X-GMAIL-MSGID: =?utf-8?q?1838975437765304130?= From: Kristof Provost If the kernel doesn't support it we'll simply never get the notification. In other words, there's no downside to always enabling this, so let's do that. Signed-off-by: Kristof Provost --- configure.ac | 9 --------- src/openvpn/dco_freebsd.c | 4 ---- 2 files changed, 13 deletions(-) diff --git a/configure.ac b/configure.ac index 50697b8e..66cb79b1 100644 --- a/configure.ac +++ b/configure.ac @@ -848,15 +848,6 @@ if test "$enable_dco" != "no"; then else AC_MSG_ERROR([DCO support can't be enabled]) fi - else - AC_CHECK_DECLS( - [OVPN_NOTIF_FLOAT], - [AC_DEFINE([ENABLE_DCO_FLOAT_FREEBSD], [1], [We have DCO float notifications on FreeBSD])], - , - [[ - #include - ]] - ) fi ;; *-mingw*) diff --git a/src/openvpn/dco_freebsd.c b/src/openvpn/dco_freebsd.c index 306ecd31..488665fc 100644 --- a/src/openvpn/dco_freebsd.c +++ b/src/openvpn/dco_freebsd.c @@ -73,7 +73,6 @@ sockaddr_to_nvlist(const struct sockaddr *sa) return (nvl); } -#ifdef ENABLE_DCO_FLOAT_FREEBSD static bool nvlist_to_sockaddr(const nvlist_t *nvl, struct sockaddr_storage *ss) { @@ -133,7 +132,6 @@ nvlist_to_sockaddr(const nvlist_t *nvl, struct sockaddr_storage *ss) return (true); } -#endif /* ifdef ENABLE_DCO_FLOAT_FREEBSD */ int dco_new_peer(dco_context_t *dco, unsigned int peerid, int sd, @@ -636,7 +634,6 @@ dco_do_read(dco_context_t *dco) dco->dco_message_type = OVPN_CMD_SWAP_KEYS; break; -#ifdef ENABLE_DCO_FLOAT_FREEBSD case OVPN_NOTIF_FLOAT: { const nvlist_t *address; @@ -655,7 +652,6 @@ dco_do_read(dco_context_t *dco) dco->dco_message_type = OVPN_CMD_FLOAT_PEER; break; } -#endif default: msg(M_WARN, "Unknown kernel notification %d", type);