diff mbox series

[Openvpn-devel,v1] Log setting DNS via NRPT

Message ID 20250803144950.21034-1-gert@greenie.muc.de
State Accepted
Headers show
Series [Openvpn-devel,v1] Log setting DNS via NRPT | expand

Commit Message

Gert Doering Aug. 3, 2025, 2:49 p.m. UTC 
From: Lev Stipakov <lev@openvpn.net>

Unlike other ways of setting DNS, we don't log anything
when we use NRPT. Since dco-win/--dns is the recommended
configuration and it uses NRPT to set DNS, let's log it.

Change-Id: Ib2f30fe69cb676e347e4d59cd2db68db7568ba5b
Signed-off-by: Lev Stipakov <lev@openvpn.net>
Acked-by: Gert Doering <gert@greenie.muc.de>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1126
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Comments

Gert Doering Aug. 3, 2025, 3:16 p.m. UTC | #1 
Looks good, and is a useful addition.

I haven't actually run the resulting binary yet (too lazy), but counted
the arguments (twice!) and test compiled with mingw/ubuntu22 to see if the
compiler disagrees.

Your patch has been applied to the master branch.

commit ff371d1aaa71ef89157ba89b8c992494bac31b34
Author: Lev Stipakov
Date:   Sun Aug 3 16:49:45 2025 +0200

     Log setting DNS via NRPT

     Signed-off-by: Lev Stipakov <lev@openvpn.net>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20250803144950.21034-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32480.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/src/openvpn/dns.c b/src/openvpn/dns.c
index ea3d91b..e079cd0 100644
--- a/src/openvpn/dns.c
+++ b/src/openvpn/dns.c
@@ -461,6 +461,11 @@ 
     make_domain_list("dns search domains", search_domains, false,
                      nrpt.search_domains, sizeof(nrpt.search_domains));
 
+    msg(D_LOW, "%s NRPT DNS%s%s on '%s' (if_index = %d) using service",
+        (add ? "Setting" : "Deleting"), nrpt.resolve_domains[0] != 0 ? ", resolve domains" : "",
+        nrpt.search_domains[0] != 0 ? ", search domains" : "",
+        nrpt.iface.name, nrpt.iface.index);
+
     send_msg_iservice(o->msg_channel, &nrpt, sizeof(nrpt), &ack, "DNS");
 }