| Message ID | 20250806144238.11332-1-gert@greenie.muc.de |
|---|---|
| State | Accepted |
| Headers |
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net>
Delivered-To: patchwork@openvpn.net
Received: by 2002:a05:7000:fd13:b0:671:5a2c:6455 with SMTP id
cw19csp267565mac;
Wed, 6 Aug 2025 07:43:00 -0700 (PDT)
X-Forwarded-Encrypted: i=2;
AJvYcCUS922nFy1zZCx9RNo33X2sZVrguQnGSil3CwDABVjFtfwCnxrgspShxgu+u5NT66hzWZAcoXBAV3Y=@openvpn.net
X-Google-Smtp-Source:
AGHT+IES2iH/dUgVIjukO+7kmYX5RJE/AVcPHQibCOp+uZEyVgPcN8urOmIR/6kTPqdrCJ98b9xA
X-Received: by 2002:a05:6808:19a9:b0:406:6e86:683e with SMTP id
5614622812f47-4357a073decmr1959089b6e.14.1754491379898;
Wed, 06 Aug 2025 07:42:59 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1754491379; cv=none;
d=google.com; s=arc-20240605;
b=XxK1Dx/mxrDDvz2OW6/XZIYfeyYX0Sv0u1g1GL52gVlJg5FwtseewBdFJL3qG+oez0
333k3vHve100M/ZQJV8Hv3P4ysdGWOr+BK//AVh53JCbGmUdEjjFNJKEgGxZHDGsNBuN
1pSgSVX+4tk8NW0atkqOvIiTd/BJkTfGDtq/1/meZQ8wdcWUnXSYcE9kG0PWgJWgscpG
kOjVnniR74wemUofoa5FNBm+lITNF1c9b7En1cgTFXujuuDOYJlzRz1vtkR7DdAK5eRM
oBvTaiKeC+dJYrFmBPsEcAL57UWABupynuEEC4Ryp3Jmrhu6Fi4YZEygVS/TL2V7GJgR
raJQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20240605;
h=errors-to:content-transfer-encoding:list-subscribe:list-help
:list-post:list-archive:list-unsubscribe:list-id:precedence:subject
:mime-version:references:in-reply-to:message-id:date:to:from
:dkim-signature:dkim-signature:dkim-signature;
bh=h/TnExqu/c8gQ5Q5EYGq7qdz0mKvbfCqt6jTEhCxgVk=;
fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=;
b=QKJ/Vc2pST7uCIf767FW/g41HsofNL6hPWR6JIuRHWKiYCOvflsahvcOjS1Big6LgS
RFO5Wx4IE5/s7XwLJbstJohJnWAbx9abAfvv5w467uhTr/ER7OKhmcRb8ORlOTRDQoUE
5VBtlp/pTgvL6O35FLkmui4983vdFc4PzadafenQLZa61rBuifw610T/lsEhB9Wfabnr
Bgs4GBYcDnhTDfbugw7HmbWTnVz6Ue/llb3CsVt+yolFtJfMYSa1b+uh427AXAgAXSWf
urbTAm9HL4GwW6mVNFu/ePYxurqsnwgsmBQ8Jas/v8c3qmsp/A3sf+1dsnUO86Idl+b7
1Row==;
dara=google.com
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=ObbJnVgy;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=gxeSqoWX;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=NzM0zuiw;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7])
by mx.google.com with ESMTPS id
586e51a60fabf-30bb5701919si1663079fac.268.2025.08.06.07.42.59
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Wed, 06 Aug 2025 07:42:59 -0700 (PDT)
Received-SPF: pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) client-ip=216.105.38.7;
Authentication-Results: mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=ObbJnVgy;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=gxeSqoWX;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=NzM0zuiw;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:
List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:
Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender:
Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;
bh=h/TnExqu/c8gQ5Q5EYGq7qdz0mKvbfCqt6jTEhCxgVk=; b=ObbJnVgy6Gwx8tfKfurJ+/Y4sX
qOATMv52AsRvK2ycPrLK5JqlI4wa+51+ia3AkgHmFga6shK4cQ7zASXiffjMQwS0Yu2ZV1xbAIPYu
ttfO2de3JOj8jv3afg7Xtxzs5umRQJ/mmUEXhgvym3ugxOnJm6ViD7OSkv5qevwTamL0=;
Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com)
by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95)
(envelope-from <openvpn-devel-bounces@lists.sourceforge.net>)
id 1ujfLz-0006nU-VL;
Wed, 06 Aug 2025 14:42:55 +0000
Received: from [172.30.29.66] (helo=mx.sourceforge.net)
by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95)
(envelope-from <gert@blue4.greenie.muc.de>) id 1ujfLy-0006nK-JI
for openvpn-devel@lists.sourceforge.net;
Wed, 06 Aug 2025 14:42:54 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References:
In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=5erV6LkBiS1Pm00gXXMgNzWhvNYhUwshz9xi9EYvzZo=; b=gxeSqoWXPMyl2+1oTHLGxBiTlg
tEPd3i5zINPpykSPyd808uJunbdlIXSl4VrcgD3WDsDyp7Ee9l6SQYxpLctaKgGYd7YhOGv7zDB4W
lYocx6RHVH5HTC2AFei+foioixG20bV6Sz87KzNkaBLlnOw9LkurjTs+3A5HtWe2II/E=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:
Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive;
bh=5erV6LkBiS1Pm00gXXMgNzWhvNYhUwshz9xi9EYvzZo=; b=NzM0zuiwLdr7kpPj0/zI3Nj7iA
kxetWl2UiUGt9DjAuX3lN3PaKqQr2zk6PKDJotH95GfcB19m3US5ineHi2kZ3LWMOnLpbZod7dg5T
nNmdspAUDEsHxrNQNvVNxVBFjfNKE3fOAoduAVPoS7ZRwPeqyn+hGZnrEET6E/pxuT44=;
Received: from [193.149.48.143] (helo=blue.greenie.muc.de)
by sfi-mx-2.v28.lw.sourceforge.com with esmtps
(TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95)
id 1ujfLu-0006wx-G4 for openvpn-devel@lists.sourceforge.net;
Wed, 06 Aug 2025 14:42:51 +0000
Received: from blue.greenie.muc.de (localhost [127.0.0.1])
by blue.greenie.muc.de (8.17.1.9/8.17.1.9) with ESMTP id 576Egc7j011357
for <openvpn-devel@lists.sourceforge.net>; Wed, 6 Aug 2025 16:42:38 +0200
Received: (from gert@localhost)
by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 576EgckG011356
for openvpn-devel@lists.sourceforge.net; Wed, 6 Aug 2025 16:42:38 +0200
From: Gert Doering <gert@greenie.muc.de>
To: openvpn-devel@lists.sourceforge.net
Date: Wed, 6 Aug 2025 16:42:31 +0200
Message-ID: <20250806144238.11332-1-gert@greenie.muc.de>
X-Mailer: git-send-email 2.49.1
In-Reply-To:
<gerrit.1754490554000.I71981e39932cafe3fd68b475fdb81a8f20a3a547@gerrit.openvpn.net>
References:
<gerrit.1754490554000.I71981e39932cafe3fd68b475fdb81a8f20a3a547@gerrit.openvpn.net>
MIME-Version: 1.0
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software,
running on the system "sfi-spamd-2.hosts.colo.sdot.me",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: From: Frank Lichtenheld <frank@lichtenheld.com> Change-Id:
I71981e39932cafe3fd68b475fdb81a8f20a3a547 Signed-off-by: Frank Lichtenheld
<frank@lichtenheld.com> Acked-by: Gert Doering <gert@greenie.muc.de> ---
Content analysis details: (1.3 points, 5.0 required)
pts rule name description
---- ----------------------
--------------------------------------------------
1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Headers-End: 1ujfLu-0006wx-G4
Subject: [Openvpn-devel] [PATCH v1] buffer: remove unused function
buf_write_alloc_prepend
X-BeenThere: openvpn-devel@lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <openvpn-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive:
<http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel>
List-Post: <mailto:openvpn-devel@lists.sourceforge.net>
List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: openvpn-devel-bounces@lists.sourceforge.net
X-getmail-retrieved-from-mailbox: Inbox
X-GMAIL-THRID: =?utf-8?q?1839717552958635435?=
X-GMAIL-MSGID: =?utf-8?q?1839717552958635435?=
|
| Series |
[Openvpn-devel,v1] buffer: remove unused function buf_write_alloc_prepend
|
|
Commit Message
Gert Doering
Aug. 6, 2025, 2:42 p.m. UTC
From: Frank Lichtenheld <frank@lichtenheld.com> Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547 Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com> Acked-by: Gert Doering <gert@greenie.muc.de> --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1134 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering <gert@greenie.muc.de>
Comments
"Remove unused function" is easy to review :-) - out it goes. BB and
"git grep" confirm.
Your patch has been applied to the master branch.
commit 028846f0f73db0e598a8fcdb3d5578bb5920046c
Author: Frank Lichtenheld
Date: Wed Aug 6 16:42:31 2025 +0200
buffer: remove unused function buf_write_alloc_prepend
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20250806144238.11332-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32565.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
--
kind regards,
Gert Doering
diff --git a/src/openvpn/buffer.h b/src/openvpn/buffer.h index 8d6bb64..6f15115 100644 --- a/src/openvpn/buffer.h +++ b/src/openvpn/buffer.h @@ -644,12 +644,6 @@ } static inline uint8_t * -buf_write_alloc_prepend(struct buffer *buf, int size, bool prepend) -{ - return prepend ? buf_prepend(buf, size) : buf_write_alloc(buf, size); -} - -static inline uint8_t * buf_read_alloc(struct buffer *buf, int size) { uint8_t *ret;