diff mbox series

[Openvpn-devel,v1] options: Fix --hash-size virtual argument

Message ID 20250822205223.3492-1-gert@greenie.muc.de
State New
Headers show
Series [Openvpn-devel,v1] options: Fix --hash-size virtual argument | expand

Commit Message

Gert Doering Aug. 22, 2025, 8:52 p.m. UTC 
From: Frank Lichtenheld <frank@lichtenheld.com>

Previously we ignored the second argument to --hash-size.
This bug is older than the openvpn git repository, but
clearly this is not an option often used (or at all).

Change-Id: Ibec7ffb9085503f72e79514776042bc310384f13
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1149
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Comments

Gert Doering Aug. 22, 2025, 8:55 p.m. UTC | #1 
Trivially correct.  And amazing that this oversight is in the code
since before the dawn of git...

I have not tested this, nor am I going to build a test rig that 
tests --hash-size variants.  Anyone feels like a unit test? ;-)

Your patch has been applied to the master branch.

commit 4f7ae8acdecf2ad45319270a0045af92d610264c
Author: Frank Lichtenheld
Date:   Fri Aug 22 22:52:16 2025 +0200

     options: Fix --hash-size virtual argument

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20250822205223.3492-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32658.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index 5f9971c..e9584a8 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -7951,7 +7951,7 @@ 
             goto err;
         }
         options->real_hash_size = real;
-        options->virtual_hash_size = real;
+        options->virtual_hash_size = virtual;
     }
     else if (streq(p[0], "connect-freq") && p[1] && p[2] && !p[3])
     {