From patchwork Fri Aug 22 20:52:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4370 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:c414:b0:671:5a2c:6455 with SMTP id jt20csp4216838mab; Fri, 22 Aug 2025 13:52:37 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUKLDVk1u+bStusUF9cgX+D+eL/NruuKfg0zCj1/MDmv9iPN4Y+lY+JRqmAMNOcNcfJ+5AAgK8khRE=@openvpn.net X-Google-Smtp-Source: AGHT+IFoW2g4ArUSNM1J2eiJ3wqOzZNPN+ifPhkaQjdxVV5puLUnlia8IvPwWDhr2neUgcJQJCit X-Received: by 2002:a05:6870:a48d:b0:314:b6a6:687c with SMTP id 586e51a60fabf-314dce3e28dmr2088620fac.50.1755895956952; Fri, 22 Aug 2025 13:52:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1755895956; cv=none; d=google.com; s=arc-20240605; b=FN5Ae3hOO5jhQo+N4iqCRAWmdGG5Sufp5QaagmH/xyPHhhD5FM3Um6ge+j0rX6+Jrr 1+kWa5sY/luMHV+YnAdpv2kvpt+pHRdVSEFEoUl5Fx2fBh75V7N2j0EDiYXaS5Tqwm9O Dv5KNwq9FvsfvG7ho5SVl0QAE9sk18Me/Bu2eMM7NaonSLrzoFaUoom1LE4QbnFnEvhv pK2QSXc7n2hK19y/QXe9KwkDuWYdwQBbLgMVixoXN7RrXHj0vs98oR1yIMtOmQbbtafV ZF0+iLEw7P0Poegi7T+X3dyFbt2SOuscnRj2Z6G32rYjFVJqv9mYK7c+9fN1HYFlN3me mI1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=yKGbGmtB+yU+mhIfHr8QzOss43F9BxQOOnvvfNrfmog=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=bdzS+BmVHcTbRJ9JIXKdZqqi+/70f9t1wVrMHkxpSay6GgfqgbfO2nXIlPUtaPp67X 2XOH+TLWBp6y/bYr/lQleJwQWpg0AavgqSTzjEoP0ju1sjJnU4SIbUsmE39+n3DeAyMG wM4auSkmjiNBEnleAy5ci5q3eyBlRtfTXrILu6f+9PmFwA+bo848Y/3jPr1IpaonzbAl qPRS6ooEf3/JpAzpM9Frer+SEMpCHvEycZqtUvo6eZtOSUQaQYOFe+cEZ1jz/G2lbzuN dK6hp42MGRoPBBk2XDre68feSfiQyllrFbS+W/a6/xhjT8/82g3eiMg3lptLtQhdU3LS GANw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=CZ7E+a3I; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="KxR/LBCv"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=hsKz3SLS; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-314f7d5800csi137674fac.245.2025.08.22.13.52.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Aug 2025 13:52:36 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=CZ7E+a3I; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="KxR/LBCv"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=hsKz3SLS; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yKGbGmtB+yU+mhIfHr8QzOss43F9BxQOOnvvfNrfmog=; b=CZ7E+a3IZLiSHqESBiTE59s5CU VV1MX+Mma5PT7A+jvzsoCixPgoa7h37MSy6KZ4wgyxkF1J624c3Y5J1nQ+sg7pvzx/xKfdEdr8A3C Le9DInzRa+4UEoCgASQYR8aOSUtMEWaPCh8NVjrUP7bb6EP1AgPwSPEBIKxq/T7WmgoU=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1upYkT-0002Fb-5K; Fri, 22 Aug 2025 20:52:33 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1upYkR-0002FU-6x for openvpn-devel@lists.sourceforge.net; Fri, 22 Aug 2025 20:52:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=J7QRvXfcUJLAYP/k/CZeMFoGPibKiSiWqxIsvj8VJv0=; b=KxR/LBCvXYR3AyRZxYB/4o3vGJ A3rkVUGw/89zx2xDVthVPFj2wOOXgUs0yHuJeddRsIjTtzzG4JBeISzezlKYKUlDR9WXibFU4kvpX 2eCvJ1wV26DmZuSfLOf03hmkE5e2D5OCQj5ot/gI2ywU3vEg52aJO8ra0XqbDwwq/m9U=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=J7QRvXfcUJLAYP/k/CZeMFoGPibKiSiWqxIsvj8VJv0=; b=hsKz3SLSc5TQ6hKrjjKg3TDUeA Y7eAeqiwIA8VbXxsF3eFNQ21fY6ykFKg2/o53ehN5/C4GB5VgwTrAf+cUZJyOb2pzWZXl30nmMBpR YManlJ3lmAANQiSDqZ56zR+rlL0/WkcpLq4lkrh4TRwfj4F9Nw8ZrVYqy8JJxhZC8smA=; Received: from [193.149.48.143] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1upYkQ-0006uS-SU for openvpn-devel@lists.sourceforge.net; Fri, 22 Aug 2025 20:52:31 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 57MKqNc4003508 for ; Fri, 22 Aug 2025 22:52:23 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 57MKqNnW003507 for openvpn-devel@lists.sourceforge.net; Fri, 22 Aug 2025 22:52:23 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Fri, 22 Aug 2025 22:52:16 +0200 Message-ID: <20250822205223.3492-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Previously we ignored the second argument to --hash-size. This bug is older than the openvpn git repository, but clearly this is not an option often used (or at all). Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1upYkQ-0006uS-SU Subject: [Openvpn-devel] [PATCH v1] options: Fix --hash-size virtual argument X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1841190358890535333?= X-GMAIL-MSGID: =?utf-8?q?1841190358890535333?= From: Frank Lichtenheld Previously we ignored the second argument to --hash-size. This bug is older than the openvpn git repository, but clearly this is not an option often used (or at all). Change-Id: Ibec7ffb9085503f72e79514776042bc310384f13 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1149 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 5f9971c..e9584a8 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -7951,7 +7951,7 @@ goto err; } options->real_hash_size = real; - options->virtual_hash_size = real; + options->virtual_hash_size = virtual; } else if (streq(p[0], "connect-freq") && p[1] && p[2] && !p[3]) {