From patchwork Sun Aug 31 15:12:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4382 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:2a1c:b0:671:5a2c:6455 with SMTP id k28csp681188maz; Sun, 31 Aug 2025 08:13:14 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXVsyhUi7HR3pbC+spNUbNVdmjqXG4zYTLDMJGUYaEcjKT9vriSewUp8y4cjXnp3mZjqx4HGNDbnkk=@openvpn.net X-Google-Smtp-Source: AGHT+IG/CmAkglpSWyv0gbWjsLkk7CDXdCoDYTtKEzOSSmE3fgQbF4f+/97y+9OUDvs2zHrrZO9b X-Received: by 2002:a05:6820:603:b0:61e:32e5:6e1 with SMTP id 006d021491bc7-61e33744a66mr1846695eaf.5.1756653194112; Sun, 31 Aug 2025 08:13:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1756653194; cv=none; d=google.com; s=arc-20240605; b=OjztfUDW3ftItmqNbyEf6DC7M7y4oD2t8re2Rfif45KhTcsGTXAnxo51XML0vn1zIU pkstcyjO2+qEtqv2RDO0RQXuBtZJivaQsW/UMm7JTgeTB5YdVqL1ZRTc3Eru8zFbdy0N tMyplymg2UyZC/5/CgAx4L+YJS9zuAbGvVYIwLysXUFrS0kr6RHvWL777rZwukvsxpZw x+NcrsI4gNNGbHwFogKxAnlOoKPx1SjWzpBgrx7FM/kc2rS0aWo7c32f+FEfb9/L27cj dguMP5XOfeSEkuCVlhtE910vYWopS+2VapfH4RBWuTtPkrm69oxaqycb8rXBrxuQTzzI U89g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=g+6o6Y5IERG/pddlrKAbEV/PLnJpC8pUWXsQjb3OMjw=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=CISpn1pMkDtUupBnFqHgfXGYRvc1ltYyiT1sko2uhgRQDDbbQeHZ9jbB6j5R/167Zh HV1s2oZxER40xeJus50MCesj+MbJrsVSoEbIOXrhpS6Xt3CUOIZVmphhWbITsFklgJMu AL7CRqUHCyJTyAL32kwIschrDOPpC9IGTKtyA0yuqHIY5KnWS/KhSWfOZq8emju19qnh fvE+UFV3NKvOmHZpc8ZMqXwNSCCTB0+jHKUhVHh9ZGG3UoJKybvUkys8DL7M5J5FpDj6 oStbRtq+Pc80z+3igk8wIDy5HLxrhcGoYT8r43K1JAOxQUQtgAbfEqrW1Q444snAlKtT JqaA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Do1SbA55; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=RqZOJqqV; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=f02T8jv1; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 006d021491bc7-61e31ee706esi712645eaf.20.2025.08.31.08.13.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Aug 2025 08:13:14 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=Do1SbA55; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=RqZOJqqV; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=f02T8jv1; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g+6o6Y5IERG/pddlrKAbEV/PLnJpC8pUWXsQjb3OMjw=; b=Do1SbA5546nsBl14qqREwdcXgJ q7vixmpLNDw8qo55/7uOaximYx807kTmsrqc+KF4PCSpCY0hRXzCf9cgQaO4PE5x7X7uyEHts39z3 3gXKOaeKgprL7cJB/oOHdskssj41Vr3LNhBXY7ZOQgZHLbE87MYC8hCQX+XX4vVnz3oY=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1usjjw-0007q9-Ep; Sun, 31 Aug 2025 15:13:08 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1usjjv-0007q3-1j for openvpn-devel@lists.sourceforge.net; Sun, 31 Aug 2025 15:13:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GkrSOe+KavCDrzMoWoFcIWfPIbRL7Ggv7nvFgjqN7qM=; b=RqZOJqqVK092EbRa8eOnMJISIO ocb7xIwhNQ6Gg2pFuSgPczfyXhf4s+qlG7iq5q9rt2hNzWmzi/RA3mAIcXfFVxvT2LDFiFVWE0gqq o6iA0/pk64+LV8RlgpytsUSMRVg+LLrAjw/9H3a3wSvlq98ILbHlYX0vymk4pVuJ8/uQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GkrSOe+KavCDrzMoWoFcIWfPIbRL7Ggv7nvFgjqN7qM=; b=f02T8jv1fZZziFw19L+AvEr+ga UmDoQjq2UrqA4nhXVB8ayHE93Elwx3Sqz+T5gIi/HEjk884B2SOOtsM5K2WSCWG8IHHyv1z8ACqVs KZfbpc7yfN8reH9r/m1skauWJ17m3+lRkb0eZxwA885PnlCoQVF1GQjWOyclvoTBjTDU=; Received: from [193.149.48.143] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1usjju-0002Ej-5u for openvpn-devel@lists.sourceforge.net; Sun, 31 Aug 2025 15:13:06 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 57VFCxmQ025804 for ; Sun, 31 Aug 2025 17:12:59 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 57VFCx7A025803 for openvpn-devel@lists.sourceforge.net; Sun, 31 Aug 2025 17:12:59 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sun, 31 Aug 2025 17:12:52 +0200 Message-ID: <20250831151259.25788-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Change-Id: Id3b8719ee6b457ce2d85156b39e0cea771a97e74 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1usjju-0002Ej-5u Subject: [Openvpn-devel] [PATCH v4] socket_util: Clean up conversion warnings in add_in6_addr X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1841984379703192560?= X-GMAIL-MSGID: =?utf-8?q?1841984379703192560?= From: Frank Lichtenheld Change-Id: Id3b8719ee6b457ce2d85156b39e0cea771a97e74 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1161 This mail reflects revision 4 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/socket_util.c b/src/openvpn/socket_util.c index 13f8c32..9b7312d 100644 --- a/src/openvpn/socket_util.c +++ b/src/openvpn/socket_util.c @@ -241,14 +241,12 @@ struct in6_addr add_in6_addr(struct in6_addr base, uint32_t add) { - int i; - - for (i = 15; i >= 0 && add > 0; i--) + for (int i = 15; i >= 0 && add > 0; i--) { - register int carry; + register uint32_t carry; register uint32_t h; - h = (unsigned char)base.s6_addr[i]; + h = base.s6_addr[i]; base.s6_addr[i] = (h + add) & UINT8_MAX; /* using explicit carry for the 8-bit additions will catch