diff mbox series

[Openvpn-devel,v4] management: resync timer on bytecount interval change

Message ID 20250902101628.20568-1-gert@greenie.muc.de
State Accepted
Headers
Series [Openvpn-devel,v4] management: resync timer on bytecount interval change |

Commit Message

Gert Doering Sept. 2, 2025, 10:16 a.m. UTC 
  From: Ralf Lici <ralf@mandelbit.com>

coarse_timer_wakeup tracks when the next timer-driven task will occur.
If a user issues `bytecount n` via the management interface, but the
next scheduled wakeup is more than n seconds away, bandwidth logging
will be delayed until that timer fires.

To ensure timely logging, reset the timer whenever a new `bytecount`
command is received. This guarantees that logging begins exactly n
seconds after the command, matching the user-defined interval.

Change-Id: Ic0035d52e0ea123398318870d2f4d21af927a602
Signed-off-by: Ralf Lici <ralf@mandelbit.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1113
This mail reflects revision 4 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>
diff mbox series

Patch

diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c
index aed04f5..92c5500 100644
--- a/src/openvpn/manage.c
+++ b/src/openvpn/manage.c
@@ -41,6 +41,7 @@ 
 #include "manage.h"
 #include "openvpn.h"
 #include "dco.h"
+#include "multi.h"
 
 #include "memdbg.h"
 
@@ -513,6 +514,27 @@ 
         man->connection.bytecount_update_seconds = 0;
         event_timeout_clear(&man->connection.bytecount_update_interval);
     }
+
+    /* The newly received bytecount interval may be sooner than the existing
+     * coarse timer wakeup. Reset the timer to ensure it fires at the correct,
+     * earlier time.
+     */
+    ASSERT(man->persist.callback.arg);
+
+    struct context *c;
+
+    if (man->settings.flags & MF_SERVER)
+    {
+        struct multi_context *m = man->persist.callback.arg;
+        c = &m->top;
+    }
+    else
+    {
+        c = man->persist.callback.arg;
+    }
+
+    reset_coarse_timers(c);
+
     msg(M_CLIENT, "SUCCESS: bytecount interval changed");
 }