From patchwork Wed Sep 17 12:07:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4422 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:fc89:b0:671:5a2c:6455 with SMTP id cv9csp91879mac; Wed, 17 Sep 2025 05:07:57 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUgC3V0EzoNtmxFnRa7sU9hotoGGhNj6+3PHHygjr8ZZy9wDeL2YgN/oGa/qIVZtPj0P5sXbnT6MzY=@openvpn.net X-Google-Smtp-Source: AGHT+IHgbfHmAZaGQSjN+JJdrFarervCug0tjip0fiiKbrkEvmr37b3XCQTkR8OdySwBmJyKEClC X-Received: by 2002:a05:6870:350d:b0:331:9036:6151 with SMTP id 586e51a60fabf-335bd292718mr974509fac.4.1758110877056; Wed, 17 Sep 2025 05:07:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758110877; cv=none; d=google.com; s=arc-20240605; b=j/E/zNnM82QkR8kIqTho+Ib39XsqxefdSgDx/mPc1stXifC6shdOCzEJXDQpSee9bO 5WXipK+BzkIK1va2tLhtEqa/I2eLYm2FE4S1KKMqupdPW9WE/ilAMeQnsJVEEGDtigCV OI33YaWQn/Y5eQ3Hx/6SI+ZSZoN7WbKuZg7a155fue/w0u5QqJgArnRDsAEkXgL0KowK IpJys2jXePP+rRo4PrJ7lp3CWp7yJFsPoOaC52k0hVvaMbVySdPsztXJmr/w/bn5VVDA nMAC8Gu2+6hMAQ6x2ZyLzvNDsRBA3+PfScKPmxIk8llODE5kUPrIs5dkO+lMsmjtJ17I zcDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=MS9CHKa+9TzkvesYheFK5pOAvntSD6rE0KkIaO4dKK0=; fh=Ah1vny6GT2h2jkNHfYFPIaYOg4hzkNSW0Qsu7DwT6uI=; b=NgbwPyj90KUGC/e2WYTwSTnnoyDLKTkRaMW93hn3cEi8AyBwzcDlV7+8HUkQYSWwrk B8lmTPzvypXNQTXIh+F6lMCN8psz+ZqR8t6VcyKVFt77OrjKzOFDATKjLdWJQLs98PAt /hztR2SGHjknUDbG82UgpSqyfGRY/EMxJgkZmrfcLO9eZTaRxCJd8VhF5t34heF5dF2i 3ZRNyE9uD2ReJwgwoSIhdHQAPon3+Fe0eu9A4ezgkUccLpWOD3XNCJBBjz+TYzqju3+S vQav21BExcGV/pgJ5VzgNNsi9sPbym2AWlaiuqI+nyRMJeoYxFjqc4wVhQtrwwAo/rbT TPHA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="Z/bK/Wb6"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=kOGAFiPU; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="F/tOKCHN"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-32d359dae67si4258259fac.227.2025.09.17.05.07.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Sep 2025 05:07:56 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b="Z/bK/Wb6"; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=kOGAFiPU; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="F/tOKCHN"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MS9CHKa+9TzkvesYheFK5pOAvntSD6rE0KkIaO4dKK0=; b=Z/bK/Wb6WSXuVbxyMZ/PtOPsxq mCBp2QzhnzsB0Fq69vUiXxJhPqpaoZ+cHNlMN7y1D1ZNqjIq/WFqUt6pr4LvLg8hp5nNJzGtn6uJW 7QaZok0IgdD17q5bvfSoPIhtCz15wMQ4t2MhQx4CDyC1PyGiBsFq3Jp6KB9ydYZ9GnAw=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uyqwz-0003U8-PZ; Wed, 17 Sep 2025 12:07:53 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uyqwx-0003U0-Pu for openvpn-devel@lists.sourceforge.net; Wed, 17 Sep 2025 12:07:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TL+l6w9aciNsewEmgktlnoTwl8GYcNSGzxYTIz4AAEw=; b=kOGAFiPU2NHiEXW4leqfqcIEn6 WeB8q/QfqTqo0UmMNFXCR5HSBDfFMU11kWouOzYBqmkIK7HAQmsWHp/3d2NQtZG4E+YWzhn+bHZON lzWs5UJUb1lafclmGXjh4NW0K0IeeA2Gv/NKNBAi4nPbMBKpZqSn6GLmOGFk74o1BLjI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TL+l6w9aciNsewEmgktlnoTwl8GYcNSGzxYTIz4AAEw=; b=F/tOKCHNzC0s3tuU741WjKVfLq 3zUr0om55slWpceYKKxKcGKK/LIOTFnCAHwJLPqNwwBG81SSG7TTZh4Q4chon3VFZkTG55lGSHWGm ref3n5a3kOWMbTPRVapNsGgm/Byxmeiyc2VSyNicIBcJXe8vbVCDiw1ZuHzRnNGe9JEQ=; Received: from chekov.greenie.muc.de ([193.149.48.178]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uyqww-00028n-Fe for openvpn-devel@lists.sourceforge.net; Wed, 17 Sep 2025 12:07:51 +0000 Received: from chekov.greenie.muc.de (localhost [IPv6:0:0:0:0:0:0:0:1]) by chekov.greenie.muc.de (8.18.1/8.18.1) with ESMTPS id 58HC7LFf030744 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 17 Sep 2025 14:07:21 +0200 (CEST) (envelope-from gert@chekov.greenie.muc.de) Received: (from gert@localhost) by chekov.greenie.muc.de (8.18.1/8.18.1/Submit) id 58HC7LKY030743; Wed, 17 Sep 2025 14:07:21 +0200 (CEST) (envelope-from gert) From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 17 Sep 2025 14:07:15 +0200 Message-ID: <20250917120720.30738-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: We used to reference to one of the mailing list archives as the formal reference for the patch and the review discussions. With the problematic reliability of the archives, I've started to manually ad [...] Content analysis details: (0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- X-Headers-End: 1uyqww-00028n-Fe Subject: [Openvpn-devel] [PATCH v2] dev-tools/gerrit-send-mail.py: include Gerrit URL into the commit message X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gert Doering Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1843512870790425332?= X-GMAIL-MSGID: =?utf-8?q?1843512870790425332?= We used to reference to one of the mailing list archives as the formal reference for the patch and the review discussions. With the problematic reliability of the archives, I've started to manually add the URLs in the OpenVPN Gerrit to the commits because they give a better reference and (usually) all the feedback is there in a useful format. So, enhance this dev-tool script to do this automatically. Change-Id: Idb137ecbade4b0584a4d74aee34978062e247bc5 Signed-off-by: Gert Doering Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1196 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1196 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/dev-tools/gerrit-send-mail.py b/dev-tools/gerrit-send-mail.py index 0b49ae9..450e920 100755 --- a/dev-tools/gerrit-send-mail.py +++ b/dev-tools/gerrit-send-mail.py @@ -99,6 +99,7 @@ assert comment_start > signed_off_end acked_by_text = "" acked_by_names = "" + gerrit_url = f"{args.url}/c/{details['project']}/+/{args.changeid}" for ack in details["acked_by"]: acked_by_text += f"Acked-by: {ack}\n" acked_by_names += f"{ack}\n" @@ -106,12 +107,13 @@ patch_text[:signed_off_end] + signed_off_text + acked_by_text + + f"Gerrit URL: {gerrit_url}\n" + patch_text[signed_off_end:comment_start] + f""" This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to {details["target"]}. -Gerrit URL: {args.url}/c/{details["project"]}/+/{args.changeid} +Gerrit URL: {gerrit_url} This mail reflects revision {details["revision"]} of this Change. {signed_off_comment} Acked-by according to Gerrit (reflected above):