diff mbox series

[Openvpn-devel,v1] Fix t_net.sh / networking_testdriver after 'broadcast' change

Message ID 20250922080305.18477-1-gert@greenie.muc.de
State Accepted
Headers
Series [Openvpn-devel,v1] Fix t_net.sh / networking_testdriver after 'broadcast' change |

Commit Message

Gert Doering Sept. 22, 2025, 8:02 a.m. UTC 
  Commit 0df0edc49c re-introduced explicit setting of broadcast addresses
for Linux IPv4 interfaces.  t_net.sh verifies that the built-in netlink
code (sitnl) achieves the same result as "equivalent" iproute2 statements
- and we missed adjusting of these iproute2 statements (printed by
networking_testdriver).  Done.

Change-Id: I5fea6ca1ccadb434b5c4f4b49881524a079a9d15
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Antonio Quartulli <antonio@mandelbit.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1203
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1203
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Antonio Quartulli <antonio@mandelbit.com>

Comments

Gert Doering Sept. 22, 2025, 8:49 a.m. UTC | #1 
Now this was actually tested and verified on a Linux system with "sitnl"
backend, and t_net.sh passes again... thanks Antonio for the quick +2.

Your patch has been applied to the master and release/2.6 branch.

commit 2bb658c826b19cba830328fd8ed8580838e51d5f (master) 
commit fb9a6808c10f773348e8818d28622dc8898560b3 (release/2.6)
Author: Gert Doering
Date:   Mon Sep 22 10:02:59 2025 +0200

     Fix t_net.sh / networking_testdriver after 'broadcast' change

     Signed-off-by: Gert Doering <gert@greenie.muc.de>
     Acked-by: Antonio Quartulli <antonio@mandelbit.com>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1203
     Message-Id: <20250922080305.18477-1-gert@greenie.muc.de>
     URL: https://sourceforge.net/p/openvpn/mailman/message/59236810/
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/tests/unit_tests/openvpn/test_networking.c b/tests/unit_tests/openvpn/test_networking.c
index f2da83e..6a2d09f 100644
--- a/tests/unit_tests/openvpn/test_networking.c
+++ b/tests/unit_tests/openvpn/test_networking.c
@@ -61,7 +61,7 @@ 
 
     addr = ntohl(addr);
 
-    printf("CMD: ip addr add %s/%d dev %s\n", addr_str, prefixlen, iface);
+    printf("CMD: ip addr add %s/%d dev %s broadcast +\n", addr_str, prefixlen, iface);
 
     return net_addr_v4_add(NULL, iface, &addr, prefixlen);
 }