From patchwork Mon Sep 22 20:41:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4436 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:c08a:b0:72f:f16c:e055 with SMTP id jr10csp459281mab; Mon, 22 Sep 2025 13:42:14 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV3tgO0SJCaR298lYUKI4WASTHrhdTim6rukhqjBoyESL4LCBr7s40J5TbC0qNdo5+PBHELLxIrXf0=@openvpn.net X-Google-Smtp-Source: AGHT+IHkt4b/zvk7JhLNHZI+7WbOtQbefMTE6Up8DgRJ1zSp23s/vT9ILr8PB4FPzgNmmXz24lUa X-Received: by 2002:a05:6830:d13:b0:746:d925:2ef6 with SMTP id 46e09a7af769-791527760abmr33079a34.17.1758573734411; Mon, 22 Sep 2025 13:42:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758573734; cv=none; d=google.com; s=arc-20240605; b=MCPcvi9dGh5cqY7akFMCp2mK0VsynoAGY8TysLY9C9zSdobN6dIa5NUNfzqFA+Uokd y9zK3lIxdqhDIPvCu+Dj6cvNdWliNrMi9vaGLCnsdlQ67P4KTuZq1cTUseXyIpiJZV8x zIan/Gbpk8uif+rnv5RVcmJttk911UzGuP2PyRexxA5x4cIvIF3J2y0LS7wSmHR93FAS 76sZSmPxNtLUSfuLbm3y//Oa6Z5CWG86YBT1VGB8DFzApcYcZ4JaZcDjqk/RSkzs1qD4 htBmoEp4x04vQ0BjzKyC6iP4Y2rrqp6id7khPk+LqSGI376/J5aboM5I/FtM70zpHX/n 7ysw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=n1QcxG9K/IeGsGH1ZxO6l3JThkafUl99F3CC+Fa3j7g=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=Bqnh8NMNPPsAOvJbYxSqJXpehNyetmYa+LsO/SBW3jrckf0YMHDb0/bpcXwHFAxwvb roHo4rTyaif62PQo76z64we+7S0of0vpoT8+Lb1zUIxNLe09q40J3k4oibpcU1CbM/FP Xkf3j2LqfME5mtlg0P1k/p87sXLLzHaPqoiJNFlD7lV0d+bKUukwadIL3A1t6NnsCwZT +55wXObXp0zbA0vaDJLHmqN0eFJxKCK+LpMfHW5evDAytvPxd4I2kfazyKKYTccG4Yjw k9l3cw6HyYpuqZVU2IYGoCUWpt0s7IUv2Yh+pkKc3/a0GsaNajORsQM6IvwFLkDDsBQc 6chg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=FTxUOyhH; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="FLkI7M/h"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=lgd3GeGp; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-78d93c022a5si363079a34.109.2025.09.22.13.42.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Sep 2025 13:42:14 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=FTxUOyhH; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="FLkI7M/h"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=lgd3GeGp; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n1QcxG9K/IeGsGH1ZxO6l3JThkafUl99F3CC+Fa3j7g=; b=FTxUOyhH8DnxM+WHVkXiP65slQ 8nnn97igrdsLnvSK9N3lKF8WcvPkwnpwUH2f9hpgzU9UWTBpLXg/OoRLM9hEkSCMiKkT+R8P72aNZ wtDipTd84eRTjQ+rVQeZGdQmEGtB6ZIeHgVIzPwwDEPFe9rfVgCdwUFRrWvpGjfL6gg8=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1v0nMS-0002pb-SF; Mon, 22 Sep 2025 20:42:12 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1v0nMR-0002pT-HR for openvpn-devel@lists.sourceforge.net; Mon, 22 Sep 2025 20:42:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SqZn5P6/pWH5nbfZP5hp0YMOb6OP/lyEBvdX0VvqPBg=; b=FLkI7M/hVQMXCOhb58JhvzmJPu X7eRnpBOuO98Hk+DnVN9C5S36vGiSkqlWHaFObLVJ1TlgqY7Z57H29+uJk4AIRaoDe02vtQMZwb09 9R/H7ltLWkMmOb7zsfdaMGGV1F9kTsq9Eo/Myit+O/rm9Tmswl0vQ08gq7+MXz877jV4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SqZn5P6/pWH5nbfZP5hp0YMOb6OP/lyEBvdX0VvqPBg=; b=lgd3GeGpONMP9tMGVSQwIWGLzh 2kDO5grDPAoG9Q1smTa4duFIHPrQwmnj+WEqm8zQhCxVlOTylbI1B3HNF2FujQXC1al1WDQG+ABgB lfQ7B/JpIBLQXAOtUbK/XMIKpRBfwux2I6mVxX4vX85SAqkoEswtTiSVXQ1kirXRmI0g=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1v0nMP-0004NK-Uw for openvpn-devel@lists.sourceforge.net; Mon, 22 Sep 2025 20:42:11 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 58MKfwdn023332 for ; Mon, 22 Sep 2025 22:41:58 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 58MKfwPB023331 for openvpn-devel@lists.sourceforge.net; Mon, 22 Sep 2025 22:41:58 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 22 Sep 2025 22:41:52 +0200 Message-ID: <20250922204158.23319-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld The OpenSSL API is how it is, so adapt with casts. Change-Id: I053ddbb71cc5b9ae16c5a49be833035d943d7eba Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/open [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1v0nMP-0004NK-Uw Subject: [Openvpn-devel] [PATCH v9] ssl: Fix -Wconversion warnings in pem_password_callback X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1843998211964561746?= X-GMAIL-MSGID: =?utf-8?q?1843998211964561746?= From: Frank Lichtenheld The OpenSSL API is how it is, so adapt with casts. Change-Id: I053ddbb71cc5b9ae16c5a49be833035d943d7eba Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1137 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1137 This mail reflects revision 9 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index c17e608..284d951 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -264,10 +264,10 @@ /* prompt for password even if --askpass wasn't specified */ pem_password_setup(NULL); ASSERT(!passbuf.protected); - strncpynt(buf, passbuf.password, size); + strncpynt(buf, passbuf.password, (size_t)size); purge_user_pass(&passbuf, false); - return strlen(buf); + return (int)strlen(buf); } return 0; }