diff mbox series

[Openvpn-devel,v2] Document that tls-crypt-v2 can be used in connection profile

Message ID 20251007202816.27730-1-gert@greenie.muc.de
State New
Headers show
Series [Openvpn-devel,v2] Document that tls-crypt-v2 can be used in connection profile | expand

Commit Message

Gert Doering Oct. 7, 2025, 8:28 p.m. UTC 
From: Steffan Karger <steffan@karger.me>

As reported in https://github.com/OpenVPN/openvpn/issues/795,
tls-crypt-v2 was not documented as an option that was allowed to be used
in <connection> blocks. This is a documentation mistake - it has from
it's introduction been possible to do so.

Verified in the code and tested locally.

Github: OpenVPN/openvpn#795
Change-Id: Ie8c6381e66d57e0c1ec31132fad8277e0133283f
Signed-off-by: Steffan Karger <steffan@karger.me>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1254
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1254
This mail reflects revision 2 of this Change.

Acked-by according to Gerrit (reflected above):

Comments

Gert Doering Oct. 8, 2025, 8:14 a.m. UTC | #1 
Good to hear from you :-) - and such a nice patch, not even a one-line fix,
just a one-word addition.

(And indeed, the code talks about "ce", so it very much confirms what
you wrote)

Your patch has been applied to the master branch.

commit d19e431b3102a511136befa7c3b8fb6a28b89f54
Author: Steffan Karger
Date:   Tue Oct 7 22:28:10 2025 +0200

     Document that tls-crypt-v2 can be used in connection profile

     Signed-off-by: Steffan Karger <steffan@karger.me>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1254
     Message-Id: <20251007202816.27730-1-gert@greenie.muc.de>
     URL: https://sourceforge.net/p/openvpn/mailman/message/59243550/
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
Gert Doering Oct. 8, 2025, 8:16 a.m. UTC | #2 
Hi,

On Wed, Oct 08, 2025 at 10:14:15AM +0200, Gert Doering wrote:
> Good to hear from you :-) - and such a nice patch, not even a one-line fix,
> just a one-word addition.
> 
> (And indeed, the code talks about "ce", so it very much confirms what
> you wrote)
> 
> Your patch has been applied to the master branch.
> 
> commit d19e431b3102a511136befa7c3b8fb6a28b89f54
> Author: Steffan Karger
> Date:   Tue Oct 7 22:28:10 2025 +0200

Meh.  Due to the mail-archive org issues I need to --amend my commits
and the script that pre-generates the mails does not know that.  So the
right commit ID is

commit 7fa59cdf0c38972bdaa9d9106e78f468179d6bff
Author: Steffan Karger <steffan@karger.me>
Date:   Tue Oct 7 22:28:10 2025 +0200

    Document that tls-crypt-v2 can be used in connection profile

(same change, different commit message "URL:" part)

Sorry.

gert
diff mbox series

Patch

diff --git a/doc/man-sections/connection-profiles.rst b/doc/man-sections/connection-profiles.rst
index 767ff3a..8710a2a 100644
--- a/doc/man-sections/connection-profiles.rst
+++ b/doc/man-sections/connection-profiles.rst
@@ -58,7 +58,7 @@ 
 ``http-proxy-option``, ``key-direction``, ``link-mtu``, ``local``,
 ``lport``, ``mssfix``, ``mtu-disc``, ``nobind``, ``port``, ``proto``,
 ``remote``, ``rport``, ``socks-proxy``, ``tls-auth``, ``tls-crypt``,
-``tun-mtu and``, ``tun-mtu-extra``.
+``tls-crypt-v2``, ``tun-mtu and``, ``tun-mtu-extra``.
 
 A defaulting mechanism exists for specifying options to apply to all
 ``<connection>`` profiles. If any of the above options (with the