From patchwork Wed Oct 8 10:55:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4482 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:7d42:b0:72f:f16c:e055 with SMTP id fr2csp840321mab; Wed, 8 Oct 2025 03:55:20 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUH6fEzwm8I5qOcyks4/3yivBbePHkBRXICj9/NSC6jFaQPMfkCrAQwMg5gmDZdmAblwk3S9McBcg8=@openvpn.net X-Google-Smtp-Source: AGHT+IFLCprlHGo1FzHEpqcJd50JdR7DytcmgCdBpG93qI6MmQp2pQtPuPFldXEyADI5+bTRlqAd X-Received: by 2002:a05:6830:a8f:b0:7b0:df6f:4c with SMTP id 46e09a7af769-7c0df6bc5d3mr1767379a34.17.1759920920362; Wed, 08 Oct 2025 03:55:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1759920920; cv=none; d=google.com; s=arc-20240605; b=ZUu6fI+A1n741tqVFb9RSr3NJJxnjHCqIcXkJRvhheBxbcbwvryKlJ8GDJsnas6zHG 2m49WlQoi1ICfiRiaZEUHLE5yJBfsMaHrT33/mWuMfQvyo4Y/zSkiKVMG2LCNI33+L+L uIcEArn8hEUJM1OpJ5ZS7kB1cPU8LmZDlg7qhlsyUtnyGe1IIF01jnwSTzLnxmzWYl5d IDbbnfQfDBHDKkoShwOskFf/C3kypO8aiC/wDTumMzhTMFEN9oIrDvIboM201YVleFPe PFHFxlYVPxKSqrnBwviI7dCxh9EDXFof1kNTOgL4cKYp4KMJVHeh8bhnbyyrMPlSZyPW MZpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=nID/dwW2G7r7Uh1Q5ePHlS13TYpZZZcyGr4ErRS4SMw=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=CwFfqFCfJIRVC93SDQFIThI8F/tGOnY787xfpXHr/mRWzLNTO3mnpEAXe+c5YHoC1B 36VhGz6uMYBk0/6DOvLQSj++aU4ZuUWp1WjYoO508ZLL3O7e/O5ldkqpPu61ZrptVJSf 0tmTRkuwKyesBFR8sWb+eRBLvrPJI957eSitlrFnJyUeG4ZV7tcJRZRrbSkkmFhTp33U FRwqyXO5UriJYwT2Ad9KvR99v1eMtXXwGSm6qJYjz5upDoyNJwaX98okgrvuGVkVW0vy 2hiyxVMA3Ig4U6PwyGCwcWfSFbcwhBDXHpH3S7XtsJB8f0p/TTw4nVCeykmSll2PWvRK FihA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=jY1Z2Dcq; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=AhpRIZrD; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="NRRb67/T"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7c06be374ffsi1235324a34.315.2025.10.08.03.55.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Oct 2025 03:55:20 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=jY1Z2Dcq; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=AhpRIZrD; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="NRRb67/T"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nID/dwW2G7r7Uh1Q5ePHlS13TYpZZZcyGr4ErRS4SMw=; b=jY1Z2DcqDhHFJSXoqwyRt8PTxF uUZX2+hXH0fkRr5+zKbZ9YaoigqoXdRABMIls7ldr1da2XVWbh2wn/n7C/J8nMSs7E0gp2RBzhDtu 85c685H72s09Tc/aWdhcR0U5XI+/phOOx6oVGkuctBsZV0n6tTEaGyfC0Rd5XGa99fOA=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1v6RpF-0002Sz-7E; Wed, 08 Oct 2025 10:55:17 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1v6RpD-0002Ss-IR for openvpn-devel@lists.sourceforge.net; Wed, 08 Oct 2025 10:55:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=h0HdM54Q/geKrAeQGa2IvhqfcGuNr3d7tlO7sMwbS0c=; b=AhpRIZrDIvDNebWGM4Nz/9vDj+ dixEYxzi4fPJq2dVcaHuch5nuVskFMz+kFSGLAI4b0GGjRHXVr9yFvmhMDc75hOVHqBK0/lTZsFa8 RTKMIQjT0I9rCo0ndB/N1XKI+8QoGvKPW8Tef516HIK0MHQ82liQquwYdWD5cviwfA64=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=h0HdM54Q/geKrAeQGa2IvhqfcGuNr3d7tlO7sMwbS0c=; b=NRRb67/T+N2yxD7hD+2LHFFDQl s7ut+QREs/s7c7uH8L6f+tHFG10F7vePCG/hvM/4imbKAnZFiPo2j7Ywe87ByMJyYxtQfW5eyIEGb 1EwUY96fNgLZlO+SIk/QZ5TnMEn198NhFsinVXOHK/jug/7LrBHVEAyfh7wqz7M+Ogyc=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1v6RpC-0006lt-Cp for openvpn-devel@lists.sourceforge.net; Wed, 08 Oct 2025 10:55:15 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 598At7EZ010015 for ; Wed, 8 Oct 2025 12:55:07 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 598At7QI010014 for openvpn-devel@lists.sourceforge.net; Wed, 8 Oct 2025 12:55:07 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 8 Oct 2025 12:55:01 +0200 Message-ID: <20251008105507.9997-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Only Debian 11 (GCC 10) complains about this. We decided not to add work-arounds for GCC 10 and older and instead accept that they do not build -Werror clean. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1v6RpC-0006lt-Cp Subject: [Openvpn-devel] [PATCH v11] vlan: Remove -Wconversion override X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1845410838879760232?= X-GMAIL-MSGID: =?utf-8?q?1845410838879760232?= From: Frank Lichtenheld Only Debian 11 (GCC 10) complains about this. We decided not to add work-arounds for GCC 10 and older and instead accept that they do not build -Werror clean. Change-Id: I73c46ac630834a8cf8894aaa2dcc429fbedd3db7 Signed-off-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1179 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1179 This mail reflects revision 11 of this Change. Acked-by according to Gerrit (reflected above): diff --git a/src/openvpn/vlan.c b/src/openvpn/vlan.c index 3da470a..a6a6e93 100644 --- a/src/openvpn/vlan.c +++ b/src/openvpn/vlan.c @@ -43,11 +43,6 @@ return ntohs(hdr->pcp_cfi_vid & OPENVPN_8021Q_MASK_VID); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wconversion" -#endif - /* * Set the VLAN Identifier (VID) in an IEEE 802.1Q header. * @@ -61,10 +56,6 @@ (hdr->pcp_cfi_vid & ~OPENVPN_8021Q_MASK_VID) | (htons(vid) & OPENVPN_8021Q_MASK_VID); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif - /* * vlan_decapsulate - remove 802.1q header and return VID *