From patchwork Fri Oct 17 20:57:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4518 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:7d42:b0:72f:f16c:e055 with SMTP id fr2csp4750258mab; Fri, 17 Oct 2025 13:57:40 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWvi5pYBfJQhX9nHMVIYmOgeeW5E0xhDHVBjdwBjPNf+JWMAma3zSXEJ8kK98qltCe0sujIWf2lx5A=@openvpn.net X-Google-Smtp-Source: AGHT+IH4IS3CYlq6hGdvHg5ARK0yi3SLFT2g6yBrO3u/jr3ItHWYpJZc7rlkX8uEQSZtDiEFhJBl X-Received: by 2002:a05:6808:4489:b0:438:273f:d09f with SMTP id 5614622812f47-443a192f62emr2946486b6e.5.1760734660085; Fri, 17 Oct 2025 13:57:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1760734660; cv=none; d=google.com; s=arc-20240605; b=a/1QINJMWYFo1plmrSl1MotOkFW4bVUfVAp+o9ABQrRpVNUZKybHbkozPtLmBFqdhP lumJxcE0YfzsWu/u6NhE68NEGE7uNE15NW7xYQaMdJiRDubVyheyC0Zx72qC78Raqh/a eE8INc5vyt9cbopBRt0ohJJhGnKAeh10u68YDIDd4OuN1vbVLsKsddzbqDGB8cHFzcrr YppBPR61ntt3mXFBk3ToT98da1ELi1Z+kfYBVsBNbLmI9DjC1xY3FioqIebeq8KWpAKu kLf6HcnI8x2BnuFkHon6mYYQZedDwX1BuhTFb5ZbB2yynKd9MoAAnxPaaJ8+BqrVtnos /Ojw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=6T2sw4j5tQu7enytE/esCzffLF0DTPRs05vQ8dfehWk=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=lyHQ43bNI5KWmQkRkBmPt93eJX1atGSdTQf15fa7e0eeRlWSuBkCTLk9h8mFG5Rjv4 izXabcp3oah8IC69Ppf0H+Su7zKIXzADlvWYgMsHhupAI2LLcAO8QI+pXVWjqMhsZ4mA M2CFLVw8pWC91JVmodCw2YBUeXurFVU9NefzzcrRVfQcKBgNTBaU2OBS27m+tLN+hbmi Avy33X9txBk9HdD/K/zGbQ8yGju+n7t8knpqJP2qUehsKMe02mr5F7oa6PHFRaWz2lE0 7Jhl1SUjEEefC+2q10dA7sMe1q58c0Vkdx7fPfTTQBdOwtNneqW+TbtK5PRrUgPwq+jA Q8pQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=SdzSohgh; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=BieYZ5b6; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=kNiERp0X; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-443de8edfe3si117009b6e.193.2025.10.17.13.57.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Oct 2025 13:57:40 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=SdzSohgh; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=BieYZ5b6; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=kNiERp0X; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6T2sw4j5tQu7enytE/esCzffLF0DTPRs05vQ8dfehWk=; b=SdzSohghvNYaAwjeODmeXqHEix PMXALM9GuYqnmDqI7GZ5kPWaOPOfHPZTHdyHN9OBjOBgK3JbQHSybUn0vyedKUkkqYG1eG39tPeq6 koqwmilT0QHye0duMrxBA2E2kkEx6O9/PshFvaF18PeGdU/4qclsF8YQ19AIJPHsBL0g=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1v9rW6-0005eg-DU; Fri, 17 Oct 2025 20:57:38 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1v9rW5-0005eZ-SN for openvpn-devel@lists.sourceforge.net; Fri, 17 Oct 2025 20:57:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RIIKubzztFWPx+XCYD3HvJO9izPTGZ8W8NcYgQXxGmE=; b=BieYZ5b6syJaGb3wADd5AzQ5QN 4xvQTjY8G/TbGVTEP2wAAftd5XletR56OdvMcQO54NqLGcemROEGunWYTZ0ixpjA/i8k0EoA4iZeY r6TSEN9q0NSUTUPJZMY2fGO28WNB0yyo0S5i+1sMDacCseMIq/VuSlAYB1RruPSqk1EE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RIIKubzztFWPx+XCYD3HvJO9izPTGZ8W8NcYgQXxGmE=; b=kNiERp0X8rVHCFbwKRT3IyiTZp ry5pq1Kep09eU8b6xTA/eMtvTkLK35Zvp5YdsKkA+3Ka0PgRa4BkNZS/lRMHiwklK84J3XVjM7nvt p0bdAX+QM/n4D+TnCRMeRWs+5XI47dJEQGfWqlNZ9n8Eg08VA+uqlaxnoKhkFKhBt/jk=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1v9rW5-0006VE-20 for openvpn-devel@lists.sourceforge.net; Fri, 17 Oct 2025 20:57:37 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 59HKvU0N008474 for ; Fri, 17 Oct 2025 22:57:30 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 59HKvU93008473 for openvpn-devel@lists.sourceforge.net; Fri, 17 Oct 2025 22:57:30 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Fri, 17 Oct 2025 22:57:24 +0200 Message-ID: <20251017205730.8450-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Cherry-pick dca6b03098ab0f3ef808c891673305651dc6704a broke uncrustify compliance. Apparently this one added line pushed it over the limit to require the #endif comment. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1v9rW5-0006VE-20 Subject: [Openvpn-devel] [PATCH v1] route: Add #endif comment for uncrustify compliance X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1846264106534757240?= X-GMAIL-MSGID: =?utf-8?q?1846264106534757240?= From: Frank Lichtenheld Cherry-pick dca6b03098ab0f3ef808c891673305651dc6704a broke uncrustify compliance. Apparently this one added line pushed it over the limit to require the #endif comment. Change-Id: I46d0e4be82a5cc7e466d6e8f658e5b131b5401c4 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1284 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to release/2.6. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1284 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 3ff9717..75e94c2 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -2368,7 +2368,7 @@ { gateway_needed = true; } -#endif +#endif /* ifndef _WIN32 */ struct gc_arena gc = gc_new(); struct argv argv = argv_new();