From patchwork Mon Nov 3 11:59:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4560 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7001:a40d:b0:72f:f16c:e055 with SMTP id vo13csp1353242mab; Mon, 3 Nov 2025 03:59:57 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCV+PmFWczeTr6wr+retUrvzAp9Dba6Mk1CiIV1gA3OcoQ346Gze6CoL701hxbrKPLfYYLO1QVfCYrg=@openvpn.net X-Google-Smtp-Source: AGHT+IHOIpWNhvy0Dz3HMvsw6oA92L2t0cyht0Lxpss6d8ENwz5tbbUug8uT33POGONiXfdnpl4a X-Received: by 2002:a05:6870:1591:b0:30b:86ed:a23b with SMTP id 586e51a60fabf-3dacccec4b2mr5537851fac.15.1762171196937; Mon, 03 Nov 2025 03:59:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1762171196; cv=none; d=google.com; s=arc-20240605; b=UjCwZAi6U8dTUD6T9OhLWwAZLdHa1m3K8JAR83eyeaYgcuidVUEPz/vlUzvmYrmp/9 qghUQcqi6yoUK1uosXjf5KlGADEoM2wpxVLQ8f3gsn3F8RIWf7hfcROKz/webBCVQJh+ esyfDblWeiQlgS7e9zvTxHS6ctiWg7cOSbjOVg1j/ht1PpGYabgsDTv+y4WPD+LtVsR9 Zc0nw2QDChznmfKxUUSt+QyCqqduPnysRqNI8/WTiWxUjlUVxJ1bObbYG9J4eAs+nRwP PJ7xuA2D+JLsPbnSdl0BYNYu3HrmSlu/ePeI2TtGOuuLYPCMGWF8Z6g4kn970ZJHOyqb zOyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=WkbRkbVtgsPva7EhpBXzJrzf8nP/B4vcOunpLadPk1Y=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=ALAOPdMZPkTmBuybU/ZVgq54qMbhPA9KIoSXbaws1pRP24dHpYxLogui+ahQd9ThLw 43FQG1C09xhSGhEDZ6UbiwLXTNLQ6lO46j5zYChzO8fbD+UGXbM6YNhkbZL0ZY18X8dh 81Xec+I7GdbTUIdKBAS6jl42twXObpnHDsYbEii3hpLfuc47PnOe1P8XBP68ODJwjYH4 4awRlOJ4Oa1VUi7uqSZ084g+Qxghb3u4402popqia0czfQmRNDJIdQSDvf/T36VkEB6r uNX/3BkVXWLwyzpctL8sAsSr0ALwUCoMLyEk9QnVdIJwfw6d5M5T6Y3f2dQoxa72mY2j A5iA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=KG+pe7JR; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=AYVtATfn; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=EFkGkmv4; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-3db42cc453bsi3470666fac.260.2025.11.03.03.59.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Nov 2025 03:59:56 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=KG+pe7JR; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=AYVtATfn; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=EFkGkmv4; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WkbRkbVtgsPva7EhpBXzJrzf8nP/B4vcOunpLadPk1Y=; b=KG+pe7JRPe9EzOlwDyYxIA/Mlo QJk8dEagQ0lLG6xFRfMqaMvkL8hZiryH5cxfNXcdFus061+6dmHlRt/7Fnk9zEFkHF4ZEunhHnKXF s+AmXTp28xO+FHbvOVC+ig6A4xyHvLOIgTm3h5QYNW7iZ8V1mqP4qbozGN0+XCqhCzlE=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vFtE2-0002mj-5Y; Mon, 03 Nov 2025 11:59:54 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vFtE1-0002md-Ax for openvpn-devel@lists.sourceforge.net; Mon, 03 Nov 2025 11:59:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=j+sdUoxfwRLiG7IqX2d3jHzMqiSboJo3k0YO6famCs4=; b=AYVtATfn6TOp9fv3IWQKVytX4U RZ4aVrh9rmq3vX8yvuR+xTXBxX0DBbWWFYpMelJggzABta8D9MEuJeNZmriAJALBtzIssa/rz6WuJ v9k33teKoxKRhjbGhCQNgeSshSgwyMrCaxxBsRt6201fyuPusza4iRTgi15Ydqcb7IoE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=j+sdUoxfwRLiG7IqX2d3jHzMqiSboJo3k0YO6famCs4=; b=EFkGkmv4Hz0OTK946nzgIZJKhh 2xq6U8tEh6Mc8AlQuVzDBSFJHnh3rRoK+mW4kPH5ntn+qF5x6ziRDrmujxlqmgfjYHECAJtiEir7N gr5LBhDBYv+1POyNvkMFnuPB9IvBmVRi1/YRrTAw780uEV8W3O/AXLQJoR6asKQ+eonY=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vFtE0-0002xr-IU for openvpn-devel@lists.sourceforge.net; Mon, 03 Nov 2025 11:59:53 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 5A3BxkeW006641 for ; Mon, 3 Nov 2025 12:59:46 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 5A3BxkDZ006640 for openvpn-devel@lists.sourceforge.net; Mon, 3 Nov 2025 12:59:46 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 3 Nov 2025 12:59:40 +0100 Message-ID: <20251103115945.6615-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Heiko Hund While generating the address list string for the DNS server addresses, to be set in the registry, the offset is calculated the wrong way. This results in gaps between addresses after the first two. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vFtE0-0002xr-IU Subject: [Openvpn-devel] [PATCH v1] iservice: fix DNS address list generation X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1847770424869655773?= X-GMAIL-MSGID: =?utf-8?q?1847770424869655773?= From: Heiko Hund While generating the address list string for the DNS server addresses, to be set in the registry, the offset is calculated the wrong way. This results in gaps between addresses after the first two. Reported-By: aarnav@srlabs.de Change-Id: I7252d5a252e91ffc03db142aa226c9eb1656480b Signed-off-by: Heiko Hund Acked-by: Lev Stipakov Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1339 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1339 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Lev Stipakov diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index 577d89c..58f1e02 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -1873,7 +1873,7 @@ { RtlIpv4AddressToStringA(&msg->addr[i].ipv4, addrs + offset); } - offset += strlen(addrs); + offset = strlen(addrs); } err = SetNameServers(iid, msg->family, addrs);