From patchwork Tue Nov 4 08:42:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4565 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:9ac3:b0:72f:f16c:e055 with SMTP id m3csp221357maw; Tue, 4 Nov 2025 00:42:51 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCW9+iAWaQAQsgqojzEvUic+2N0zUYJc859MJlPhJwkZF003kQA/2HJ/13lu98DthNoQlbnKTKj4BNM=@openvpn.net X-Google-Smtp-Source: AGHT+IGgvf3suMDvCFtMDYvxQcsys1jfI6TVxkgAWjzNoYHPtSSm4vVAGrHUJzzT17qyYUmrw9yr X-Received: by 2002:a05:6602:489c:b0:93b:da4b:d0a3 with SMTP id ca18e2360f4ac-94822a674d9mr2586042639f.19.1762245771714; Tue, 04 Nov 2025 00:42:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1762245771; cv=none; d=google.com; s=arc-20240605; b=Y71VysJ3H3emhD/utRDupkRztdxOnqyZualzS5MKF+MCvoCm6zBgEBS/vc9iVJ89JN 0ODbjmlHpiQKommOPGTUGOtgpPb7Fx/7fg/ZZ/CyoVT5o6VGXcL0YaH8+wqDittwjz9u J+ZzuFgtXxjF5+3whJMpTv+kU5Xknh37oEXDRkUZzRpnr9pQ+Md5+bqnBYlzepp9Koo5 EtZeiQjmpAUuWLYOEzO0ObVzLIl9e2ElJKhErwElx76xxCNf0cQ7UQDvEynx4xMuVWx8 +6v6hJIIef1F7F51DcxhVs2lbkfqEgM3xl7xcM1QZUKgzOGjy5QMMPfHz6jvlPbA8Mee ymXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=TvgcRz9Z/8Z3UZ2gsNzk3tkFWZ9sojfzUfI6tQJtasE=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=BPD++T4U6xWQYi3jG52Xo0Yi/KE1lOQDuZj5qqouthlgkG4lbDksEcy+7PUuczIlmk hrxCDBETcTMRCGdNrkZBxh3Zq6EfE0Pdz+Ca92m6UzeDQTnbg17FOWCUCQj39ylJCr3H qdyaJJtjzBVCRf0+y1tpQT8LJ1AIe5Mk9rG6EPfMVmQMxVZDAdp8lRKHbFo4kC+bT9/g TPpnKu1G9g42pXEs1Zbyw1A26o3hPa01+8pwxB5sHs9Si3JxAiDf6/TknFasQLEzMdAy UKtjCcfdBBRKSuYqnlnX4TySMzKxN+dSPJ6SVZILz1z/k7w9LKcs2agR1T8KM9vadZ8p ZONg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=PigWxi5z; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=WFJ9aUCO; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=CScdcFwR; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id ca18e2360f4ac-9485aff7cf8si116045539f.348.2025.11.04.00.42.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Nov 2025 00:42:51 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=PigWxi5z; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=WFJ9aUCO; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=CScdcFwR; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TvgcRz9Z/8Z3UZ2gsNzk3tkFWZ9sojfzUfI6tQJtasE=; b=PigWxi5z2Shwyal6EcZ/wXj9bB avy3yso9uLHcsC5uENelh7MmKxirX3TmQDV6un/7+cucxUCwkepQd5DSG/Cif3/NkBIT6ULN4L77i xcJQStXxAfmZsUXrF/W1qpY4fmnNvhuAzoGgWns5V6PzdVfFHSwusN/023aI3gsspgmI=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vGCcq-0005UN-Cj; Tue, 04 Nov 2025 08:42:48 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vGCco-0005UH-Kq for openvpn-devel@lists.sourceforge.net; Tue, 04 Nov 2025 08:42:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AXcNoIQw9cnNGKEcIkcNZcSKYoyAezLK+OYyxzkYI4g=; b=WFJ9aUCOVbq0cxS+1U2VuBve+F gOIMRf41auZsjIy0kd7CVA/dQ7w7D3q8s/PFM6iN1UHj/Txoy3DLLaik1rqqCSHSuvRhrihPy/Lfc 9X+HwBniT0GB2ehKdoDH3Z5YIUyXTxtmA9oLaS9lBY1Oxk1Wwa1vq5dILETznFBACC40=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AXcNoIQw9cnNGKEcIkcNZcSKYoyAezLK+OYyxzkYI4g=; b=CScdcFwRIfMhiO5mgQWgRYkdMh I7gGHpE7ihHvKzfz9Fz+N48bcMCsuLJXq0HwE3Wb/zdJ5gZhrXQV/4xUKfFCb22mfCdbcxKbXV5Ct gWl+IJtLdGF+H2tcx5x2kHAcR/24+pKyBz2KJWcDsJJ2FOeJC3MTVAG0/p3NobI/nHfo=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vGCcn-0006qW-FN for openvpn-devel@lists.sourceforge.net; Tue, 04 Nov 2025 08:42:46 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 5A48gc2B006740 for ; Tue, 4 Nov 2025 09:42:38 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 5A48gcLi006739 for openvpn-devel@lists.sourceforge.net; Tue, 4 Nov 2025 09:42:38 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 4 Nov 2025 09:42:32 +0100 Message-ID: <20251104084238.6722-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Marco Baffo Update mi->reporting_addr(_ipv6) for staus reporting purposes after sending a PUSH_UPDATE containing an ifconfig(-ipv6) option. Github: fixes OpenVPN/openvpn#889 Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vGCcn-0006qW-FN Subject: [Openvpn-devel] [PATCH v1] PUSH_UPDATE server: update reporting_addr after ifconfig update X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1847848622022725758?= X-GMAIL-MSGID: =?utf-8?q?1847848622022725758?= From: Marco Baffo Update mi->reporting_addr(_ipv6) for staus reporting purposes after sending a PUSH_UPDATE containing an ifconfig(-ipv6) option. Github: fixes OpenVPN/openvpn#889 Change-Id: Ie15977b44091445b9d1edebe885d92ec5cb5770a Signed-off-by: Marco Baffo Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1340 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1340 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index 261209d..2b944667 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -4346,6 +4346,7 @@ multi_unlearn_in_addr_t(m, mi, old_addr); mi->context.c2.push_ifconfig_defined = false; mi->context.c2.push_ifconfig_local = 0; + mi->reporting_addr = 0; } /* Function to unlearn previous ifconfig-ipv6 of a client in the server multi_context after a PUSH_UPDATE */ @@ -4358,6 +4359,7 @@ multi_unlearn_in6_addr(m, mi, old_addr6); mi->context.c2.push_ifconfig_ipv6_defined = false; CLEAR(mi->context.c2.push_ifconfig_ipv6_local); + CLEAR(mi->reporting_addr_ipv6); } /** @@ -4389,6 +4391,8 @@ { mi->context.c2.push_ifconfig_defined = true; mi->context.c2.push_ifconfig_local = ntohl(new_addr.s_addr); + /* set our client's VPN endpoint for status reporting purposes */ + mi->reporting_addr = mi->context.c2.push_ifconfig_local; } } @@ -4408,6 +4412,8 @@ { mi->context.c2.push_ifconfig_ipv6_defined = true; mi->context.c2.push_ifconfig_ipv6_local = new_addr6; + /* set our client's VPN endpoint for status reporting purposes */ + mi->reporting_addr_ipv6 = mi->context.c2.push_ifconfig_ipv6_local; } } }