From patchwork Wed Nov 12 09:22:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4584 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:33c4:b0:7b1:439f:bdf with SMTP id u4csp2437513maf; Wed, 12 Nov 2025 01:22:41 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXFx/2rUtetf4JwhwBxA1g+BRcqp1vhiw+vHDmJiVNScnaaGZdTXasDf2tMEZLKYyCMM1QqG3MPCvA=@openvpn.net X-Google-Smtp-Source: AGHT+IFq5r9ck6weRN9K3shwzcigJk6olOcn6MbSL+VrBLbT4Oabwb08KA73Lgn00t9mf9b1hmIs X-Received: by 2002:a05:6830:30b5:b0:7c5:3798:fa4e with SMTP id 46e09a7af769-7c72e3be869mr889960a34.17.1762939361350; Wed, 12 Nov 2025 01:22:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1762939361; cv=none; d=google.com; s=arc-20240605; b=iPqbkkkPNKmPbb+O7I0+RqNl7t747CyZH816SEKia2dpMklnsdhtredE8HBosRlbxO GP4QSl86ORksLzxi1wsoteFzxDYjDf2/dWQ9M79dv0jhsKZiUAW/q9KE4zJU23gxg3cl Px7Rs3WzO+dIjX0Va5M94vZRlO51G2iKX+s1NM8/48huKO08067O1L1EuAjZ/psIDInD xTWpYYe71bsNGBLEd746AO408almu3DOl4RL4QzPAFOMfbK77L7r9ZD3erRSJ51LSlu6 NeOL+RqZv2i6IyB+Zy31mhAs2Wfh3d+xUp6VkoS5VgU93jpjSvHtNdPmDzwb1lScliei o7lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=g6TUEZ1CkMbA69/r7j59vQ1kAp8kmOuPLQyNtfauawU=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=T3yriTaEwbYUQXLXQSXfsxfYf9wXfezy94ZqL4z8nnbQ7BacHR14nXHcQAPck3yJnd sDSVYRO8VtHF5cfSxpX2M1QrKZ+YEsgnrMh6m1pbgjNz4fskDCZM7+53F6HuAe9Ln7/T t40/gSl50o1GZXUeUHnsjS1XLs08BIGL4K6k54WQ0sfdZNOsmEIdjm1+PWRtbrZzA+UW Art5iMIuiey3xPZI2BbMaI0yEIAFm2OHGXiGZv3lio9vln6+RRpqs0AQNyYGTzQptv1W wBY+I17QR7vtBFMPErL3gDlN1GX0WmuNy0Akk7bR7290Hp9ITigVd/y02rYxP3qcKhcM CT5Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=GmD3dK1N; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=C34FK7st; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Foq0e0rg; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7c6f113266esi5505839a34.383.2025.11.12.01.22.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Nov 2025 01:22:40 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=GmD3dK1N; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=C34FK7st; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Foq0e0rg; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g6TUEZ1CkMbA69/r7j59vQ1kAp8kmOuPLQyNtfauawU=; b=GmD3dK1N1s+te23XjbIYGfJ4vc a+aX7I3QPVugKCskV8ptVGWNrRlWYJXADOPtMUFssMZAvBDH52dbgtzAI3oXN9L3UP70o3Kj5lasa l+EHdLNy/bJ8S2MpiY4u/Qzjk+9ZmpaTHt9OTvqiIsM8ZdoPo63RhMTDweRGaSjQ8zS8=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vJ73l-0006u9-9d; Wed, 12 Nov 2025 09:22:37 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vJ73f-0006tv-Dh for openvpn-devel@lists.sourceforge.net; Wed, 12 Nov 2025 09:22:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VOff9MRTPmhn6ONyGu7igqLh65FwxJGhXE4RxwexuUQ=; b=C34FK7st8s1bN7XIAH8WmnLTTk R4J0lF5daxzkGSQLInmHwc/pCxXr5oxSvFc3wszFU+w11pVLy592izpdAooM2LRS2v4vdfyFh/HqP zUawXJVSAdz8uxh9whzqCVlHDyrZN4pIkqxOBZpxjxtHvatvI3F3Yqszs0dRijJcQSU8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VOff9MRTPmhn6ONyGu7igqLh65FwxJGhXE4RxwexuUQ=; b=Foq0e0rg2Vj4zY49iYP1T4k8dR 3rbAuTPpYZYpUb5adtEi2y/oBWm9RDItp99ras92iyk29lBWLNbsmrjBYFO1hVPMiTnt6Zxx5Bkgn 3ghS7c46VDPmPaWDcsANZpfBa6ouDHFfT9CeqnnD5xUia6XQyiWYr93J8twLoZA8s3m0=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vJ73c-0008KM-Rm for openvpn-devel@lists.sourceforge.net; Wed, 12 Nov 2025 09:22:29 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 5AC9MHIW022716 for ; Wed, 12 Nov 2025 10:22:17 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 5AC9MHNZ022715 for openvpn-devel@lists.sourceforge.net; Wed, 12 Nov 2025 10:22:17 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 12 Nov 2025 10:22:10 +0100 Message-ID: <20251112092216.22703-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Heiko Hund Since the define is no longer used, remove configuration-time checks if it exists, and also code dealing with situations where it doesn't. Change-Id: I50f189048ef1a624e6ac84b71d7b22fcbbc3ab6b Signed-off-by: Heiko Hund Acked-by: Lev Stipakov Gerrit URL: https://gerrit.openvpn.net/c/openvpn/ [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vJ73c-0008KM-Rm Subject: [Openvpn-devel] [PATCH v5] win: remove checks for PATHCCH_ENSURE_TRAILING_SLASH X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1848575903761455429?= X-GMAIL-MSGID: =?utf-8?q?1848575903761455429?= From: Heiko Hund Since the define is no longer used, remove configuration-time checks if it exists, and also code dealing with situations where it doesn't. Change-Id: I50f189048ef1a624e6ac84b71d7b22fcbbc3ab6b Signed-off-by: Heiko Hund Acked-by: Lev Stipakov Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1354 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1354 This mail reflects revision 5 of this Change. Acked-by according to Gerrit (reflected above): Lev Stipakov diff --git a/configure.ac b/configure.ac index 3117e13..8f3c01d 100644 --- a/configure.ac +++ b/configure.ac @@ -1383,17 +1383,6 @@ fi fi -if test "${WIN32}" == "yes"; then - AC_CHECK_DECLS( - [PATHCCH_ENSURE_TRAILING_SLASH], - [AC_DEFINE([HAVE_PATHCCH_ENSURE_TRAILING_SLASH], [1], [PATHCCH_ENSURE_TRAILING_SLASH is defined])], - , - [[ - #include - ]] - ) -fi - # When testing a compiler option, we add -Werror to force # an error when the option is unsupported. This is not # required for gcc, but some compilers such as clang need it. diff --git a/src/openvpnserv/CMakeLists.txt b/src/openvpnserv/CMakeLists.txt index a92ee08..2c8f310 100644 --- a/src/openvpnserv/CMakeLists.txt +++ b/src/openvpnserv/CMakeLists.txt @@ -8,9 +8,6 @@ include(CheckSymbolExists) -# Some old versions of mingw does not have PATHCCH_OPTIONS enums -- add a check -check_symbol_exists(PATHCCH_ENSURE_TRAILING_SLASH pathcch.h HAVE_PATHCCH_ENSURE_TRAILING_SLASH) - set(MC_GEN_DIR ${CMAKE_CURRENT_BINARY_DIR}/mc) target_include_directories(openvpnserv PRIVATE diff --git a/src/openvpnserv/validate.c b/src/openvpnserv/validate.c index 2dcfe1a..b3189b7 100644 --- a/src/openvpnserv/validate.c +++ b/src/openvpnserv/validate.c @@ -27,10 +27,6 @@ #include #include -#ifndef HAVE_PATHCCH_ENSURE_TRAILING_SLASH -#define PATHCCH_ENSURE_TRAILING_SLASH 0x20 -#endif - static const WCHAR *white_list[] = { L"auth-retry", L"config",