From patchwork Sun Nov 23 12:00:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4624 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6c3:b0:7b1:439f:bdf with SMTP id j3csp1269228maw; Sun, 23 Nov 2025 04:00:46 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUeRbtr9+MT4wDldnOydi++71AjUOhO+YYaB1Ije4y4bReoJDtkzobIlbULdfPadupiqW3aXqgslXE=@openvpn.net X-Google-Smtp-Source: AGHT+IFVQt4bigtz0o+GgiPFNXRl7VJSr1RSLXrcNj/oyPbiTNh4IOjK3LXfvWOdhnpNC/0nA68X X-Received: by 2002:a05:6808:18a6:b0:44d:bf83:d7f8 with SMTP id 5614622812f47-451159c889emr3028214b6e.4.1763899246466; Sun, 23 Nov 2025 04:00:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1763899246; cv=none; d=google.com; s=arc-20240605; b=dz2tAZWMgx6ywfZE2UHNSDQdRNF4gpwVK/ggZaAFQsBOoM6Nki22jrSIjK1U0gGTpB 9x/CXUA9pwjtHmNys5Rv2UYjXmckCCWPlZCcBI3d2otdP7+xG6HjvF/XO7sBrihFQZSf XOdZRU3Z7lWgt1BGkteoKjbJD7mL/Ig/3/Z+jdVJax10ZMm+/zQ+603JJri12ZHhoO5e ejdXpZNGVXK2OXY5FVncAd0kklxi0q7HKgnybfBpoTMizVLR77X85+nVbVSbXu7csuw3 s9XfwznLqRNuLgYB6XhbvGCiTGnL+LliTDSjz/CxPHyvntloTmug9r+S4MR2Nc3yZmu3 7M7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=n1rqUXsCkbVRW7rwQnURDytXAhtzFF6MQ74VfEu7Crk=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=lCENDd7/0FKWR65rq75bGdXbGBx6bDVh2O7apNMVgWnrrVFPjmWjTXu+bnB0FYllMH q5OBusWjKIahSnUFfEQsRp9Gr0WWBRRmjrTtC6a3S9LL8Exms8OnCPBDmcO5DVnHTe9B LlrTulVbY9RRh7FWgHqrDsrbe3dL3dWanKEypyPKiGkO4Yh64QVMi3BWa1Q6YRPYRDAo ApxkE/vbuEwDPtGMli9EBYIXw0R0A4AR60sAmsbQOcWpyNLlvs98WQQeJCEB+7zFd7P9 gQFGyylSh8+PuL/gA22ScVCfxjstYEcv6GkXSW9+Wk8FIGmRGdUnJcWISyz51mStyNmy pJvA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=YTYk+yrc; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=fLDolCQM; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=dKVYdJmL; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-3eca1b64f43si1815871fac.1450.2025.11.23.04.00.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 23 Nov 2025 04:00:46 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=YTYk+yrc; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=fLDolCQM; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=dKVYdJmL; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n1rqUXsCkbVRW7rwQnURDytXAhtzFF6MQ74VfEu7Crk=; b=YTYk+yrcF2rNJHNJSabyqz2aWv b/JVL4pUptFn55K04UYhkD1bKHW0W62Rrc6766r+06Z3s3uGrkVpqd+/LYthYX6SuDdmOumH4Kg3/ FARFDmQnd3qrureH/YlsQB7lRF70br/JKO2UuKHiUHACL3kFjzfRLbnP/YSit3ffjFyg=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vN8ln-0006SJ-6Q; Sun, 23 Nov 2025 12:00:43 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vN8ll-0006S2-Lm for openvpn-devel@lists.sourceforge.net; Sun, 23 Nov 2025 12:00:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6NQXZ99Wg0nA2HolZ4GeXUqkp83I1ricNMkHdBZ0Eow=; b=fLDolCQMH8DWNj6FBlvhG+X4TM 2thsgwhmnfsKhUuCRTti2Q2xeFDMb5mHiAwNYJZDROAqgGSLOBpuQ7jWqzdhbY0RPWMeYNpwY3gFQ /ElQbN7EdtsN26LUx6oq08sksw00B3py9XEyxX9xMmsqvaBa8QGtbE4p8KjEBk3qPiZA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6NQXZ99Wg0nA2HolZ4GeXUqkp83I1ricNMkHdBZ0Eow=; b=dKVYdJmLed9dSvUXjOMEV8hKxR OIniHDWhaqKHXM0WLiDwlNOpDRkM5FYdLVUv8nbAPQpxUoZxAIHRY+atep5yzTuUFxIUMI09jxG3s 3j7W9pI8LPfhRGVBRA9taoQniOlGELKmVeiF04mAaEXW2R7pNEOBVUZhSgvkKwPWwIJU=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vN8ll-0000mk-DQ for openvpn-devel@lists.sourceforge.net; Sun, 23 Nov 2025 12:00:42 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 5ANC0T1D019754 for ; Sun, 23 Nov 2025 13:00:29 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 5ANC0TEH019753 for openvpn-devel@lists.sourceforge.net; Sun, 23 Nov 2025 13:00:29 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sun, 23 Nov 2025 13:00:23 +0100 Message-ID: <20251123120029.19736-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.49.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Heiko Hund Check if the list argument to ListContainsDomain() is NULL. Otherwise the call to wcsstr() will bail out. Reported-by: Marc Heuse Reported-by: stephan@srlabs.de Change-Id: Icd7c7b08e317aefd91a60bfc62e92cd8707b6fac Signed-off-by: Heiko Hund Acked-by: Gert Doering [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vN8ll-0000mk-DQ Subject: [Openvpn-devel] [PATCH v1] iservice: check for NULL pointer X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1849582416223215241?= X-GMAIL-MSGID: =?utf-8?q?1849582416223215241?= From: Heiko Hund Check if the list argument to ListContainsDomain() is NULL. Otherwise the call to wcsstr() will bail out. Reported-by: Marc Heuse Reported-by: stephan@srlabs.de Change-Id: Icd7c7b08e317aefd91a60bfc62e92cd8707b6fac Signed-off-by: Heiko Hund Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1393 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1393 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index ec80a30..006f748 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -2106,7 +2106,7 @@ ListContainsDomain(PCWSTR list, PCWSTR domain, size_t len) { PCWSTR match = list; - while (TRUE) + while (match) { match = wcsstr(match, domain); if (!match)