From patchwork Mon Dec 8 19:42:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4666 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:29c3:b0:7b1:439f:bdf with SMTP id g3csp889450max; Mon, 8 Dec 2025 11:42:54 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVoVY5uY5Heddh0C6T2rs5KJB3TNylLiV21BX5h5LBGiuv5h8HH5GhNTeFq2tUI0pUdW0Nx9GVOVdQ=@openvpn.net X-Google-Smtp-Source: AGHT+IHyzm2U3uas0c3s3Ix/C2469QdM0g25DZ6ylwv4qmucNexo69x8Kb1j0SM6M1XgXhQo/deP X-Received: by 2002:a05:6871:8403:b0:3ec:4559:1611 with SMTP id 586e51a60fabf-3f5a1c90291mr246518fac.21.1765222974196; Mon, 08 Dec 2025 11:42:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1765222974; cv=none; d=google.com; s=arc-20240605; b=loFVjxcBYzKaKsvsrZRPEC1CmjE2N6qRBjNjFS6YiU4C0WOlpFBC9Q0/7+KugJsk0X a0mQDrw2XW0zPnWrxwdjK4t54/7HuQQQZ45AhNtBJRQgGZB4h7uNTGScTFwZ39j8SBn7 VxjblmINwEjcPyeXlnabhNZWLQXl+pZ73aSLLdLGMGHto3yF00eRB48gRvuRr7bLkEOb 4p8dKX27xRio3xv/wKMN3d4HMwmJD8ywNayPiqXwS+OrmozgF/j8ou8Ut6aeikYBvmFo sSF4yRPM558cJcyo2bU+UY7JU+HF4oBt/Ihoqj4cy80dQYWhaKCkLf9bFyImvcImU22q A4eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=LaVJv/wsc3vcwibDTOPlZLq1NetE5EHS6FxQJLNMnY8=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=NIxJfuKWsrX1MF0F1VFDxYvPlNqQWelpj++qjyI1IVI+mRrocOB3pVnCRqOoJqfOpI u6dLjSfM1otTdScWLTNZGeW/P7su+YUfpPbkOon+HHQ8q68zarKBZ6aRIupmBoyxYmaf LHqFRMVwxMOwsomYedy47meFYsNlPbUS6U2Z+3OC6vvIppsrbVFER05nvMDPx020WkFM lPKyMenBORloEPy7/Ywx29HxyzhUfxLP8wuIbhsBFIlxPTaU6UPkIBjGIgEYx1MZVG2p cuy1RQhowDqMF9bRamF+eMH5a5rexgWMvctAwD84Wdmp4te3uKB+8OuuCBahIEuFrJQg KYUA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=SUyujYCm; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=aiugR5+r; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=CvQu+Yuy; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-3f50aa2138fsi8287760fac.208.2025.12.08.11.42.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Dec 2025 11:42:54 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=SUyujYCm; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=aiugR5+r; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=CvQu+Yuy; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LaVJv/wsc3vcwibDTOPlZLq1NetE5EHS6FxQJLNMnY8=; b=SUyujYCm+hjedGsZvSV86rD7wQ Flc7faDPUR8wMMG4bDSegUeRQGV6rxXtJkVseIAhlVczHWVeHBIglvaRuHqNeejqPvkKZZRZPz6ct 5qM3A9qPFKmtbTE6dnCjCifFzCPCGvuOQj77yoN8aPcnFvXv/eTgM9LxjBmN2YwIbkNo=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vSh8F-0001Kg-87; Mon, 08 Dec 2025 19:42:52 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vSh8D-0001KR-SJ for openvpn-devel@lists.sourceforge.net; Mon, 08 Dec 2025 19:42:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hXdP78ns4yi22PKcY1LHGcYMR5z0sBOrTnqTmMuHJLY=; b=aiugR5+rLjMAFOPQjuFQ8kpLJi VI9fxcHlaHQpTVYJRRQzNyhBXAuweLawH0glSzAz2LjlcBsMx/muQWAgPMsh/ocDexQl9MiKWPnz6 bv3V1K1EgCgoThfBZ+sFbK5UVCLds9HyXFxmTRugXbw7o0SlAXNiV9WT3jgY59pSJv/E=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hXdP78ns4yi22PKcY1LHGcYMR5z0sBOrTnqTmMuHJLY=; b=CvQu+YuydUowBW8JqeJ3WAoMlE adtCFRGBB8Qh9eI4PR/+WWUJg7Nt5zkDREamQqcnjV1BZ7xl0qKUG3C40f3m12kIE5g7yB/8TTYJt 7fqijSsPc2gt7ik4IbwhpwKo1Yf5OGL/uW2AHtMc9jp6MuyO1EJKOu5x/pAV4O4weN4Q=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vSh8D-00034c-NR for openvpn-devel@lists.sourceforge.net; Mon, 08 Dec 2025 19:42:50 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 5B8JghMJ017540 for ; Mon, 8 Dec 2025 20:42:43 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 5B8JghcK017538 for openvpn-devel@lists.sourceforge.net; Mon, 8 Dec 2025 20:42:43 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 8 Dec 2025 20:42:37 +0100 Message-ID: <20251208194242.17520-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.51.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld This code was copied over and over since many years, since commit 9a3f670248d6f519a399e65a7232e2196b5115db ("Fixed autoconf script to properly detect missing pkcs11 with polarssl"). It is unclear what [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vSh8D-00034c-NR Subject: [Openvpn-devel] [PATCH v1] configure.ac: Remove use of PKCS11_HELPER_LIBS in mbedTLS checks X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1850970445670908046?= X-GMAIL-MSGID: =?utf-8?q?1850970445670908046?= From: Frank Lichtenheld This code was copied over and over since many years, since commit 9a3f670248d6f519a399e65a7232e2196b5115db ("Fixed autoconf script to properly detect missing pkcs11 with polarssl"). It is unclear what exact purpose it served back then but probably it is obsolete. It is definitely wrong since it means that you get PKCS11_HELPER_LIBS even if you do not specify --enable-pkcs11. Change-Id: I317be5253d6563906dd3826421dc81f737beba76 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20250716151857.385959-1-frank@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32187.html Signed-off-by: Gert Doering Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1423 (cherry picked from commit ed690d1d58792f70b86b75b00c09df2ad96babca) --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to release/2.6. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1423 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/configure.ac b/configure.ac index 307329d..e77fd47 100644 --- a/configure.ac +++ b/configure.ac @@ -801,14 +801,6 @@ ;; esac -PKG_CHECK_MODULES( - [PKCS11_HELPER], - [libpkcs11-helper-1 >= 1.11], - [have_pkcs11_helper="yes"], - [] -) - - if test "$enable_dco" != "no"; then enable_dco_arg="$enable_dco" if test "${enable_iproute2}" = "yes"; then @@ -1022,13 +1014,12 @@ [mbedtls_ssl_init], [MBEDTLS_LIBS="-lmbedtls -lmbedx509 -lmbedcrypto"], [AC_MSG_ERROR([Could not find mbed TLS.])], - [${PKCS11_HELPER_LIBS}] ) fi fi - CFLAGS="${MBEDTLS_CFLAGS} ${PKCS11_HELPER_CFLAGS} ${CFLAGS}" - LIBS="${MBEDTLS_LIBS} ${PKCS11_HELPER_LIBS} ${LIBS}" + CFLAGS="${MBEDTLS_CFLAGS} ${CFLAGS}" + LIBS="${MBEDTLS_LIBS} ${LIBS}" AC_MSG_CHECKING([mbedtls version]) AC_COMPILE_IFELSE( @@ -1399,7 +1390,12 @@ fi if test "${enable_pkcs11}" = "yes"; then - test "${have_pkcs11_helper}" != "yes" && AC_MSG_ERROR([PKCS11 enabled but libpkcs11-helper is missing]) + PKG_CHECK_MODULES( + [PKCS11_HELPER], + [libpkcs11-helper-1 >= 1.11], + [have_pkcs11_helper="yes"], + [AC_MSG_ERROR([PKCS11 enabled but libpkcs11-helper is missing])] + ) OPTIONAL_PKCS11_HELPER_CFLAGS="${PKCS11_HELPER_CFLAGS}" OPTIONAL_PKCS11_HELPER_LIBS="${PKCS11_HELPER_LIBS}" AC_DEFINE([ENABLE_PKCS11], [1], [Enable PKCS11])