From patchwork Wed Dec 10 07:50:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4673 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:29c3:b0:7b1:439f:bdf with SMTP id g3csp1886770max; Tue, 9 Dec 2025 23:51:09 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVRZWyRDg5dxe/xCzmgVg0Qa0uNxP6jQLsFTmvgmxdDHbR8vhBwxQk8yEo7yHt79rWTjXePjjZk5YY=@openvpn.net X-Google-Smtp-Source: AGHT+IEJKJd9ounWGrkhOX7KHIa+in9yOB03/BxWQ2dr3BFHx6/D+tkZbLctL6YomDdm9MYpQgsB X-Received: by 2002:a05:6870:4186:b0:3d1:b23f:5fc5 with SMTP id 586e51a60fabf-3f5bd9ff6bfmr955363fac.22.1765353069483; Tue, 09 Dec 2025 23:51:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1765353069; cv=none; d=google.com; s=arc-20240605; b=PhWk4MqBLLYeE4ktO35eXDi/VafYw5t2dPzEL4KUB2or+GTZ/PQd+d1Tzc8zHgnJP/ 8OcFq7LvNFqdgSB9rao1Db+4zRt5qbjYCInM6xvmN4CddptPBansewFd1s+YdWIvmYEd qQeFouo67eUZmiY1oVeob1bWoPhyw+W/bXomKoeHlAYGynyI6gKNIN4/2jNbG4Dk5rH7 P/p3X15GhIwCy57KVCCjrveoIaH5PVd+Mivcw+CD6DaQZavBH4qGZCZQo7N43IofVCKr 0+c6aVDoOVCMaj92LBxpJq0+4csDi4jQNJePpdD6mQphIZlueW6yVRB6ILyFate468HO 8Kvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=sR/5dSXYmGXpvJn168RsuMe4v3ALlZauNytbmUb+0Ys=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=Hc9pSYSzeSQNwiWFXpEcmAaCpJCnhqfZ03xS7fgMSdTMZeYCo7GV/O+K3xnwiwWy9m TlQ9inDhtHU3DDkFBFALsqBWelAVfz24xevlmeeTwsXRoBY9vzA6Wi7+2hwP0TuEEbTx uNqlRCkm/ml0NRC03G63de5DJqMt/GbRDp+t1Zl0FfBWMN3yERS4Hx/jnR1vjwElNj4f xGU4P2wX4eWjyp0gADPsBYnQDZx1dUp1LYv0hpcULBJhnCplhUdLxdZQ6P4dwgfPPBlp ZYHFAAiSm2ZRBpawXQfvzGVyEg/OvMaXn3/6SL6bdEoW4xiEA0Zd0ogo66RX5fre8MHn mwqA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=OqxN+lIX; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Ms56GitJ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Xriyh1TX; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-3f50aa20eb0si11858279fac.187.2025.12.09.23.51.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Dec 2025 23:51:09 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=OqxN+lIX; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Ms56GitJ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Xriyh1TX; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sR/5dSXYmGXpvJn168RsuMe4v3ALlZauNytbmUb+0Ys=; b=OqxN+lIXUgzXqEPXZYjG+VjUOS 7suPdh+Jbv6WofMSM8d/+eg+btB0R+6AfrbIYDJaU4HHF63VyW+HwJ55cuAkuBcK9loyLh3qSS31Y sfgydHhTGJMDNiohYykWzKwyXwoKq9jcL6V242O25z6YuEFHr/AlUoNklt1F4u+A9rhw=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vTEyY-0006n4-Dv; Wed, 10 Dec 2025 07:51:06 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vTEyX-0006mx-0r for openvpn-devel@lists.sourceforge.net; Wed, 10 Dec 2025 07:51:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YrdXTRKvs/kjdhwMIFJVycLpugSlwjxJ67s5nhgRmgY=; b=Ms56GitJPpKKXUWLMxydApL41y mGybzjh1HyCpOXLh/qOEr3S/JljOlgKDuCqfLHQRmC2UX4SY/in0oEQC9aM0Sdcz3LMIN9HLtMQs0 VDsR6v2MfXmJzVO6H1l8alLozmnVXK7Oz/LoImyPQCToaAlggSn7vRiYTBMgdrDgALKA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YrdXTRKvs/kjdhwMIFJVycLpugSlwjxJ67s5nhgRmgY=; b=Xriyh1TXleDqg1mm07C4vfD6vA ANahDIWBnQ66sGPc2HbbVqE400GBnoOUATdSDVUmS4on0RGfd/GSK65Mjw3qWvrpOPyb+KJpccgQl nPr+7w1mFjhpg6oOBu/Y893DvIAtkLmW3tiROMgguPHpASWD0QupKEe8kPMBY8nGdKH4=; Received: from [193.149.48.134] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vTEyV-00057r-VU for openvpn-devel@lists.sourceforge.net; Wed, 10 Dec 2025 07:51:04 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 5BA7ovH5027204 for ; Wed, 10 Dec 2025 08:50:57 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 5BA7ovFk027203 for openvpn-devel@lists.sourceforge.net; Wed, 10 Dec 2025 08:50:57 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 10 Dec 2025 08:50:50 +0100 Message-ID: <20251210075056.27185-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.51.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld It has been a long time since 2.3. So move this from the code to the documentation. Includes some minimal drive-by fixes. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vTEyV-00057r-VU Subject: [Openvpn-devel] [PATCH v1] options: Remove some verbose error messages for options deprecated in 2.4 X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1851106859808721559?= X-GMAIL-MSGID: =?utf-8?q?1851106859808721559?= From: Frank Lichtenheld It has been a long time since 2.3. So move this from the code to the documentation. Includes some minimal drive-by fixes. Change-Id: I59995bf0fd6bc48a738a94e41141ed37d8d637ba Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1427 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1427 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/doc/man-sections/unsupported-options.rst b/doc/man-sections/unsupported-options.rst index 821ac07..6e77333 100644 --- a/doc/man-sections/unsupported-options.rst +++ b/doc/man-sections/unsupported-options.rst @@ -6,9 +6,16 @@ longer supported --client-cert-not-required - Removed in OpenVPN 2.5. This should be replaxed with + Removed in OpenVPN 2.5. This should be replaced with ``--verify-client-cert none``. +--http-proxy-retry + Removed in OpenVPN 2.4. All retries are controlled by ``--max-connect-retry``. + +--http-proxy-timeout + Removed in OpenVPN 2.4. Connection timeout is controlled by + ``--connect-timeout``. + --ifconfig-pool-linear Removed in OpenVPN 2.5. This should be replaced with ``--topology p2p``. @@ -21,6 +28,9 @@ Removed in OpenVPN 2.6. The built-in packet filtering (pf) functionality has been removed. +--max-routes + Removed in OpenVPN 2.4. The limit was removed. + --ncp-disable Removed in OpenVPN 2.6. This option mainly served a role as debug option when NCP was first introduced. It should no longer be necessary. @@ -50,6 +60,9 @@ Removed in OpenVPN 2.7. This option does not make sense anymore as option strings may not match due to the introduction of parameters negotiation. +--socks-proxy-retry + Removed in OpenVPN 2.4. All retries are controlled by ``--max-connect-retry``. + --windows-driver Removed in OpenVPN 2.7. OpenVPN will always use ovpn-dco as the default driver on Windows. It will fall back to tap-windows6 if options are used diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 1be105b..bd6dc07 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -6699,19 +6699,10 @@ ho->auth_file_up = p[1]; ho->inline_creds = is_inline; } - else if (streq(p[0], "http-proxy-retry") || streq(p[0], "socks-proxy-retry")) + else if (streq(p[0], "http-proxy-retry") || streq(p[0], "socks-proxy-retry") || streq(p[0], "http-proxy-timeout")) { VERIFY_PERMISSION(OPT_P_GENERAL | OPT_P_CONNECTION); - msg(M_WARN, "DEPRECATED OPTION: http-proxy-retry and socks-proxy-retry: " - "In OpenVPN 2.4 proxy connection retries are handled like regular connections. " - "Use connect-retry-max 1 to get a similar behavior as before."); - } - else if (streq(p[0], "http-proxy-timeout") && p[1] && !p[2]) - { - VERIFY_PERMISSION(OPT_P_GENERAL | OPT_P_CONNECTION); - msg(M_WARN, - "DEPRECATED OPTION: http-proxy-timeout: In OpenVPN 2.4 the timeout until a connection to a " - "server is established is managed with a single timeout set by connect-timeout"); + msg(M_WARN, "DEPRECATED OPTION: %s option ignored.", p[0]); } else if (streq(p[0], "http-proxy-option") && p[1] && !p[4]) { @@ -6826,7 +6817,7 @@ else if (streq(p[0], "persist-key") && !p[1]) { VERIFY_PERMISSION(OPT_P_PERSIST); - msg(M_WARN, "DEPRECATED: --persist-key option ignored. " + msg(M_WARN, "DEPRECATED OPTION: --persist-key option ignored. " "Keys are now always persisted across restarts. "); } else if (streq(p[0], "persist-local-ip") && !p[1]) @@ -6875,10 +6866,7 @@ } else if (streq(p[0], "max-routes") && !p[2]) { - msg(M_WARN, "DEPRECATED OPTION: --max-routes option ignored. " - "The number of routes is unlimited as of OpenVPN 2.4. " - "This option will be removed in a future version, " - "please remove it from your configuration."); + msg(M_WARN, "DEPRECATED OPTION: --max-routes option ignored."); } else if (streq(p[0], "route-gateway") && p[1] && !p[2]) {