From patchwork Thu Jan 22 12:57:07 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 4727 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:220f:b0:80a:3855:ce6a with SMTP id q15csp386243mag; Thu, 22 Jan 2026 04:57:30 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCU8IfEL3viavJnA+k+GBi+zaCKixHWP5fTAj6kEqkO/ftbdpOJi33AR5dcew2G+xZybrU35SSGixrE=@openvpn.net X-Received: by 2002:a05:6870:1793:b0:3ff:4b26:c40f with SMTP id 586e51a60fabf-40846aa9d50mr4563250fac.4.1769086650513; Thu, 22 Jan 2026 04:57:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1769086650; cv=none; d=google.com; s=arc-20240605; b=MOighbh3AKg0yY5oCzhN85oMKPgs6u2JaHVt/8EJ6L16G1k7yPmmVOxQ2Q+g9D/IJK OPtxFBSqvzY+tT1caC9b9OOMzMQxaa7q9jY3BBP6IqW3CZVnhG8kFMyW4xzFKl+R2G13 cWq5s2yFy+NLMJvDb18pLC0mWhkpIRszCvtit+YkgTViErERD19BeBZ84ElDN8GL6poL j4QtnimD75hmlLi1yW0EZEl9q76HWDN5w+6NbesYli+t2peNRwa4jBoU90/c+1rmdo6G X9VhkxG1tPFCycuznqpiVEBX4bl7+bvqo94Q9vArEDwio0kGeuhKR1LF5uOnJAYHZ7i7 In0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=PNUpKj93UuZfp3D++5DtpsgcfFm9b5Ct6/xC88mXEz0=; fh=LGnBiFoRiMdcpHMcu9KAw9SLSXP9PjpGPYxooBMW3/A=; b=K8+jbkPi5StW0rp4FfGEVE7PhczxihFKxv5B0EqAZY2CYbqH1tUzuOhxGG5bQW2OYr F8hAGi11nVB7/06mF8rg19pdKuPd3Xw/WiTEJAQumpvyIjttAPocQ7K5KX56iZ4h2OsX 2Dh8wHxGveIfJKAs2Q3ZhIWdLW2DuOXooMLqlx/7jJZQMogcC+BHgD4ZPZA96m0P65pR KkkMxMptgv8ikQfXY0vk1e+wPATW0WDqF1bwrR1auZXKO6NArEHitcPl/zNY4h/EwqGQ 78jN+20anOCJwTHiWVgRED4RBTwxFx2jLid1jzbUOnJrpQALaCJfhaDpR6L5s7Z4gfND QECQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=HbQs+7KB; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=LXJEQCA0; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=bcSAep6n; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=UZdeQlNo; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-4044bb1a47csi13404566fac.55.2026.01.22.04.57.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jan 2026 04:57:30 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=HbQs+7KB; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=LXJEQCA0; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=bcSAep6n; dkim=neutral (body hash did not verify) header.i=@lichtenheld.com header.s=MBO0001 header.b=UZdeQlNo; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PNUpKj93UuZfp3D++5DtpsgcfFm9b5Ct6/xC88mXEz0=; b=HbQs+7KBEwMxgZx47WbizzOS+X +3palbau/m/64VSp05O6hgUnFwFJRK97qHZwfLUHMegLJekp62C9pS65v7wX3iZhckff8evsh63mp y12nrfEZbcSfHnYlV5RAMjUMt+YXyIq7hsDa8feaciVp9qpG52xw6VcT+X0wReFlRp8M=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1viuFc-0007J5-3T; Thu, 22 Jan 2026 12:57:28 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1viuFZ-0007Iv-OK for openvpn-devel@lists.sourceforge.net; Thu, 22 Jan 2026 12:57:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=atxfTtFIb+XTkU+Q+/PImemLJsm6LPjDtXsi5fg6nv8=; b=LXJEQCA0JfV6EdNDz3skYlqzBa VpfI8BZ3WoqG9YgPlvMOPr1cjTJ2FoRkvdRMhFScHvNl3+A1mRnv8uE5+PlpUr21suzJ1EKv5AnPG htjczicQKvmx58toST719Y0lh/aRATL+KrvLASVF7CpXOqJMt40ziVyiCQntnqhk/Xuo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=atxfTtFIb+XTkU+Q+/PImemLJsm6LPjDtXsi5fg6nv8=; b=bcSAep6no/+32faGHKoDgJ3S1/ Jjny5Hv7guTwuz5xXH8cu6ww3ddkxXbhvdGQkHo0sf/kUwxJKhhlOVsVI+HXyufuJhQ3zKtIm83a4 2x35taqkQ+GYxxXl7870ROpl0ttG0tteqwzsnqvWux8v3qomQ63EbhRY6SkS2kWZiBRY=; Received: from mout-p-202.mailbox.org ([80.241.56.172]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1viuFY-0007Gj-53 for openvpn-devel@lists.sourceforge.net; Thu, 22 Jan 2026 12:57:25 +0000 Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4dxh0k361wz9tln; Thu, 22 Jan 2026 13:57:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lichtenheld.com; s=MBO0001; t=1769086630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=atxfTtFIb+XTkU+Q+/PImemLJsm6LPjDtXsi5fg6nv8=; b=UZdeQlNopovhoyE2UWLp/VegX+Atxfy4hOlKM0Mw4d2zigHFtOdiwgb6tAQ/IH7Jj5wgv+ RmOP3zZVx/zIcDjvSRUsc5tuVPzJnWbTofIYMvkVQlHKUfdtH7X8DzrylCi1t4pT4fEtIn I4jkqO1+J5qCaTqVIV3HkqU6sMmw02BtX5Axkp1wg51IAMNJa9c6mNgduLOPpbRFE6/0Ux qqROMJEvKRiJSNkZY2Z5uWABryyFVCVX3lHQNUYDyrEbJ77xJcVFa5B0Wu8p78UNVwokIg HGiHPItwln70T98SiUswzj6C2cXBstVORVWwSan87H3OT0YAIVhyqVbW6i11oQ== From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Thu, 22 Jan 2026 13:57:07 +0100 Message-ID: <20260122125707.108048-1-frank@lichtenheld.com> In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: If the management interface requires authentication via password and the remote did not specify it, do not do trigger actions requested by --management-forget-disconnect and --management-signal on dis [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [80.241.56.172 listed in wl.mailspike.net] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-Headers-End: 1viuFY-0007Gj-53 Subject: [Openvpn-devel] [PATCH v1] manage: Do not trigger actions on management disconnect if not authenticated X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arne Schwabe , Joshua Rogers Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1855021803596187489?= X-GMAIL-MSGID: =?utf-8?q?1855021803596187489?= If the management interface requires authentication via password and the remote did not specify it, do not do trigger actions requested by --management-forget-disconnect and --management-signal on disconnect. Reported-By: Joshua Rogers Found-By: ZeroPath (https://zeropath.com) Github: openvpn-private-issues#5 Change-Id: I575d65912ce9065a0b0868e73998b4a9aece62af Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1484 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1484 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c index 8fa8784..37ae6b3 100644 --- a/src/openvpn/manage.c +++ b/src/openvpn/manage.c @@ -2073,13 +2073,14 @@ } if (!exiting) { - if (man->settings.flags & MF_FORGET_DISCONNECT) + if (man->settings.flags & MF_FORGET_DISCONNECT && !man_password_needed(man)) { + msg(D_MANAGEMENT, "MANAGEMENT: Reset authentication on disconnect"); ssl_purge_auth(false); (void)ssl_clean_auth_token(); } - if (man->settings.flags & MF_SIGNAL) + if (man->settings.flags & MF_SIGNAL && !man_password_needed(man)) { int mysig = man_mod_signal(man, SIGUSR1); if (mysig >= 0)