| Message ID | 20260210151639.913-1-gert@greenie.muc.de |
|---|---|
| State | New |
| Headers | show |
| Series | [Openvpn-devel,v1] Update the clang-format reference version to 21.1.8 | expand |
Indeed, this is one of the reformatting issues that occasionally bubble
up and go away again - good to hear it's been fixed for good in 21.1.8,
then.
Codewise this is all "wrap the function definition to have the return
type on the preceding line" stuff - which seemingly failed for windows
stuff, either "UINT" or "__stdcall", whatever upset clang-format here -
but all very trivial "replace a space with a newline" changes.
Your patch has been applied to the master branch.
commit 44a5b330210ef1f1fd371a178bb0b1aefdab8088
Author: Frank Lichtenheld
Date: Tue Feb 10 16:16:31 2026 +0100
Update the clang-format reference version to 21.1.8
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1514
Message-Id: <20260210151639.913-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35563.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
--
kind regards,
Gert Doering
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index c1bca47..5fd5465 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,6 +1,6 @@ repos: - repo: https://github.com/pre-commit/mirrors-clang-format - rev: 'v20.1.0' + rev: 'v21.1.8' hooks: - id: clang-format files: \.[ch]$ diff --git a/src/openvpnmsica/openvpnmsica.c b/src/openvpnmsica/openvpnmsica.c index b5d8cd2..a145b64 100644 --- a/src/openvpnmsica/openvpnmsica.c +++ b/src/openvpnmsica/openvpnmsica.c @@ -308,7 +308,8 @@ } -UINT __stdcall FindSystemInfo(_In_ MSIHANDLE hInstall) +UINT __stdcall +FindSystemInfo(_In_ MSIHANDLE hInstall) { #ifdef DLLEXP_EXPORT #pragma comment(linker, DLLEXP_EXPORT) @@ -335,7 +336,8 @@ } -UINT __stdcall CloseOpenVPNGUI(_In_ MSIHANDLE hInstall) +UINT __stdcall +CloseOpenVPNGUI(_In_ MSIHANDLE hInstall) { #ifdef DLLEXP_EXPORT #pragma comment(linker, DLLEXP_EXPORT) @@ -359,7 +361,8 @@ } -UINT __stdcall StartOpenVPNGUI(_In_ MSIHANDLE hInstall) +UINT __stdcall +StartOpenVPNGUI(_In_ MSIHANDLE hInstall) { #ifdef DLLEXP_EXPORT #pragma comment(linker, DLLEXP_EXPORT) @@ -620,7 +623,8 @@ } -UINT __stdcall EvaluateTUNTAPAdapters(_In_ MSIHANDLE hInstall) +UINT __stdcall +EvaluateTUNTAPAdapters(_In_ MSIHANDLE hInstall) { #ifdef DLLEXP_EXPORT #pragma comment(linker, DLLEXP_EXPORT) @@ -963,7 +967,8 @@ } } -UINT __stdcall ProcessDeferredAction(_In_ MSIHANDLE hInstall) +UINT __stdcall +ProcessDeferredAction(_In_ MSIHANDLE hInstall) { #ifdef DLLEXP_EXPORT #pragma comment(linker, DLLEXP_EXPORT) @@ -1166,7 +1171,8 @@ return uiResult; } -UINT __stdcall CheckAndScheduleReboot(_In_ MSIHANDLE hInstall) +UINT __stdcall +CheckAndScheduleReboot(_In_ MSIHANDLE hInstall) { #ifdef DLLEXP_EXPORT #pragma comment(linker, DLLEXP_EXPORT) diff --git a/src/tapctl/main.c b/src/tapctl/main.c index 6bb4119..1d047dd 100644 --- a/src/tapctl/main.c +++ b/src/tapctl/main.c @@ -609,7 +609,8 @@ /** * Program entry point */ -int __cdecl wmain(int argc, LPCWSTR argv[]) +int __cdecl +wmain(int argc, LPCWSTR argv[]) { int iResult; BOOL bRebootRequired = FALSE;