From patchwork Wed Feb 11 11:33:10 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4755 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:1817:b0:80a:3855:ce6a with SMTP id p23csp72538max; Wed, 11 Feb 2026 03:33:56 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCU6s+T2qP0L620kJnEJbdoCndEzBeTmzZ9UJRZGwFPT17qbAty3jziZEGPv2KF/MgEqc6y3KJFptMc=@openvpn.net X-Received: by 2002:a05:6830:4c0d:b0:7cf:e3f3:412 with SMTP id 46e09a7af769-7d4a576a122mr1151266a34.24.1770809636422; Wed, 11 Feb 2026 03:33:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1770809636; cv=none; d=google.com; s=arc-20240605; b=dsypsh/TG1SfRCHniV2j5H8iejHRPDaUCXvyK7octuxAIlIB6tIc0xevzluhAYPgmZ PWrtvqnU4IcdXFmKiGXI5J6o4H+ZVhS5S2B94+kc4OYoyrSxaFo/wus7+SeOM4dpWo2j PWqjeqP/ctPB0aWChZX31iLdcda2KddhHZp12g5R9BnbiLmCvv03cFAR1zYFCi1M5lSn +LrysOGTUAoU6T2IkqyMedS8zN0b6qoxWIxiBNVCikRLz/ppUa0tPfeRJM6epQhNYEcY aiknMSdh6MKFZ+maQouIa9t2THn09vaxA08fbtYQ+nPCtPhwM14f0Xpc8RqliZ9l6sFB 3+xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=vBzeskdhv8B8WObPLkpUkKWL8AZrMjzsTbIK16vGb9E=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=CMvIM07DqYHViq1wx4gIGuZviQuqBIyfJOhPmxNQjGEItEf9p7syQ9fpTKihUhF9XP 4k1ybgbZxvf1N+XfR+6sDErg41zXl4eakP4BhJElFP2dlX+3BaEJ5qWYn1wsN3SP4kGT Q4DaKP8f7uB/ypeKUZnydhTt7HJymCh7M+BI6xJo7raIfx2BmogBUDdU/pMYtYNy/fiP mu1YEJ9UfwUZIf8DprWNSLwyZyXLbrcDYb221ucRfqiT9+tTxMNfIqEeC3t7UPd5Vt7B BcMrWyo/Ko9GBNVmyR3CcC1j0kUVYG8YC6McjNhLgf2WW23nWcnSBTQmLBHTvssP7Xyd 9wfA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=X7UDuNgv; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=NrrO0GPJ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XItWfvWl; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7d4a75759a1si1053764a34.62.2026.02.11.03.33.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Feb 2026 03:33:56 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=X7UDuNgv; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=NrrO0GPJ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XItWfvWl; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vBzeskdhv8B8WObPLkpUkKWL8AZrMjzsTbIK16vGb9E=; b=X7UDuNgvFI6YwzkOhe77I5mll3 7iuY2n8YArXPFHZS12nSHB7e0TKQcNkBbYHaeWUZwoiWthGpLQ+SsJ5Mx+Ep3f/LP8fMHaH3XYt85 MI4St3hK/uiMEDoqug4jmLDdN47CxFQfRkQUWQe7HiaF46ikrRb7u3XRo+EpIC/02H4c=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vq8Tf-0007vS-5y; Wed, 11 Feb 2026 11:33:51 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vq8TJ-0007uN-1M for openvpn-devel@lists.sourceforge.net; Wed, 11 Feb 2026 11:33:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=l627fNq4z9fTQh0dO8ObaN6cBUGMGz4GDvmZPMNiYIU=; b=NrrO0GPJh0EUbuW01Yv88Cn4xG eD4Wc4FZIancxW0sMgG8LAW3WMB3JBBjLsxSg7J2J1gNHLmE0kT6SD8NS3xuxsgSGlV8WuxBsT8kt 0+Ry81WBPOZltfTfwnAuAoboeLKxU/bHLNPMW22+isDsRBGYRd8T9s6PdosCrnWxM7Nc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=l627fNq4z9fTQh0dO8ObaN6cBUGMGz4GDvmZPMNiYIU=; b=XItWfvWluWneKxhNRKknmgBNxI pZpfOnL9cCMwL5TYqrvUkd89DIiUbyObW9lYWx8T6TY9khP6I7kocv7CsFGpIFQMjSpByQSdZsA0H J2nnQiphsoZf58L3YASu4bI3p79yPlah6ZTTJ7f+4/WvqQ2XH5w2iByFXmNB5SRskRSw=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vq8TH-0005wk-Tk for openvpn-devel@lists.sourceforge.net; Wed, 11 Feb 2026 11:33:28 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 61BBXGJl025793 for ; Wed, 11 Feb 2026 12:33:16 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 61BBXG1A025792 for openvpn-devel@lists.sourceforge.net; Wed, 11 Feb 2026 12:33:16 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 11 Feb 2026 12:33:10 +0100 Message-ID: <20260211113315.25776-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From "day 1" the message "Non-OpenVPN client protocol detected" was logged at D_STREAM_ERRORS level (verb 1), while it is not anything erroneous in this context (it's inside an "port share" only block [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vq8TH-0005wk-Tk Subject: [Openvpn-devel] [PATCH v1] port-share: log incoming connections at verb 3 only X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1856828485250498813?= X-GMAIL-MSGID: =?utf-8?q?1856828485250498813?= From "day 1" the message "Non-OpenVPN client protocol detected" was logged at D_STREAM_ERRORS level (verb 1), while it is not anything erroneous in this context (it's inside an "port share" only block). Bump this to D_PS_PROXY (verb 3). Github: closes OpenVPN/openvpn#976 Change-Id: Ie5c9a88050de959cfb02e5f804323a8081ddb667 Signed-off-by: Gert Doering Acked-by: Arne Schwabe Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1516 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1516 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe Frank Lichtenheld diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c index 58ccda9..d97b770 100644 --- a/src/openvpn/socket.c +++ b/src/openvpn/socket.c @@ -2149,7 +2149,7 @@ { if (!is_openvpn_protocol(&sb->buf)) { - msg(D_STREAM_ERRORS, "Non-OpenVPN client protocol detected"); + msg(D_PS_PROXY, "Non-OpenVPN client protocol detected"); sb->port_share_state = PS_FOREIGN; sb->error = true; return false;