From patchwork Wed Feb 18 21:44:31 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4774 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:525e:b0:838:aef6:1aff with SMTP id e30csp392737mag; Wed, 18 Feb 2026 13:44:57 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWHleLG450Tm8r2k7I4uqCQ8wqAua6QwN/HIh2/htHPwKzRyau5UQhuKR5j2UwB5JWL7AmU/qBhVqA=@openvpn.net X-Received: by 2002:a05:6870:c0cf:b0:404:383f:56bb with SMTP id 586e51a60fabf-40f0d7585b8mr8998609fac.35.1771451097111; Wed, 18 Feb 2026 13:44:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771451097; cv=none; d=google.com; s=arc-20240605; b=eLAdBRFpH2aid2vilpiPR+Vnh0k7auzVK7svxIMLi3sRp/NfCZ0t8rskdN9ec3fS8w 36A3ZTkxpkPR4nbRkQ4sovavr8XkJOy06ozELupRkpDwa7ScjjacHxzXeVg7vPEdKVNR s/x1c7ANTZ+RDRVMbmn4Jz9g8zwHK8dqCN8etN3AG/eQ4i7juRuU0H+qIpd6pAH8bMPe FtXTg7vabpgI1IPtPVi3Bj2hxlnyBD75+220isNPlgWLNxzBc/aNUx31JVjNVr+S2jFH vmm7XmnPEBVI+0jbMz4JNXuQuYqga5iz+0Ybw6+pg08MUNK3E8d4an8M758GRIuUHzSu YO0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=Qor17iATlZOwH1YBOvZD8ZumbSnen+BTgPEI8EHqOgM=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=S3iXvAJ7vmI48GQSDXt9YLZBDD8i7L7Ur/ppLhzYXhz7LMKwGvL8cSIIfhFyeWcfPk rOTbfCJzXtyG+UfTJ3qaYveRu/NRt8+7JJYHCrc03BsOctAgqRpFI+/gLgG7XQ6qCNgJ I1rroj9fdGD/K0JwcKNPEgadL4N38OSDc9T2pzgmaex2DLqTztzSWmYF8vZgvj1Esypm l3+Ex86uStIf8Zihfpz/QniyndUlnZO7E7ScyJdgl4ZVHwO5MSu6NiHN0YVR0O5SS4ko akwYfUB1nSyQEimfhfg1iCq+hmIEsLV3tQn9ZOD1GJap0xoveirbcV0jPzXaQ9T83aBk ykVQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=dR7DIBn6; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=BgUk3oWp; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=bt5Nwp5F; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-40f3789e0e2si8372678fac.364.2026.02.18.13.44.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Feb 2026 13:44:57 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=dR7DIBn6; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=BgUk3oWp; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=bt5Nwp5F; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qor17iATlZOwH1YBOvZD8ZumbSnen+BTgPEI8EHqOgM=; b=dR7DIBn6LHgdxdFDsfQ4yD/tBi UMyX9DObU+Hn4AKE6+sHjr+661R5srqcrMwt+Zw3ASn+yCB7ArIbdx2aCUm/wJDWwgpDuTUevq8Ps REc3BsvhUNVpyBdefVEMg8r/77vhnpdkjccw9PwLkIMio8mfUPfyRrFxTVAyjQ0cpiKY=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vspLp-000575-8O; Wed, 18 Feb 2026 21:44:54 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vspLn-00056e-6f for openvpn-devel@lists.sourceforge.net; Wed, 18 Feb 2026 21:44:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=K0Tv1e3TDwDzf5eoAHAn/R20BZ9+pM1u/Bt07RX1neA=; b=BgUk3oWpmonsjflZOlliNaqUwI EoQhmTq0FPcq9lujxNlw+K0JxEr//3/tcDcGVDymiqD5nar5SdqBGvNiANAaVyCUcGZm8kSv64LYt VcGxZsCtcjNvawChHUI6KpRUdckxbZ/77VvAXkdHDg+JMONlwQ1ldynE5WD2o0/KI+1E=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=K0Tv1e3TDwDzf5eoAHAn/R20BZ9+pM1u/Bt07RX1neA=; b=bt5Nwp5FjZQ/D6eN5d+uPGQnzk +RFhY4pBJKR5S14y5eHo0C2Pt0OtdJSW9o2NDA3vtJViLu+aol3guUDT2Za5ul3u5bZdmtKTkaQF0 yJgbxhMTROWRZQnatakc4Yh1H6kpEosNBETcJjBQlZGmLvj6bk7yCJKlo8b+ZcX8t2UE=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vspLm-0008Fy-Jh for openvpn-devel@lists.sourceforge.net; Wed, 18 Feb 2026 21:44:51 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 61ILicEZ026925 for ; Wed, 18 Feb 2026 22:44:38 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 61ILicYU026924 for openvpn-devel@lists.sourceforge.net; Wed, 18 Feb 2026 22:44:38 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 18 Feb 2026 22:44:31 +0100 Message-ID: <20260218214437.26912-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Rudi Heitbaum Since glibc-2.43: For ISO C23, the functions bsearch, memchr, strchr, strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr that return pointers into their input arrays now have definitions as macros t [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vspLm-0008Fy-Jh Subject: [Openvpn-devel] [PATCH v2] ntlm: fix discards 'const' qualifier from pointer target type X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1857501106089248414?= X-GMAIL-MSGID: =?utf-8?q?1857501106089248414?= From: Rudi Heitbaum Since glibc-2.43: For ISO C23, the functions bsearch, memchr, strchr, strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr that return pointers into their input arrays now have definitions as macros that return a pointer to a const-qualified type when the input argument is a pointer to a const-qualified type. fixes: src/openvpn/ntlm.c: In function 'ntlm_phase_3': src/openvpn/ntlm.c:241:15: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 241 | separator = strchr(p->up.username, '\\'); | ^ Change-Id: I2703f15144661f9cadfc8750884db270f3a5bfc6 Signed-off-by: Rudi Heitbaum Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1546 (cherry picked from commit 720c2e97f609bf7bb7e628ddfa7d3e3783afa676) --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to release/2.6. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1546 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/ntlm.c b/src/openvpn/ntlm.c index 9191a8b..6da4359 100644 --- a/src/openvpn/ntlm.c +++ b/src/openvpn/ntlm.c @@ -230,7 +230,7 @@ char domain[128]; char username[128]; - char *separator; + const char *separator; bool ntlmv2_enabled = (p->auth_method == HTTP_AUTH_NTLM2);