| Message ID | 20260218214519.26971-1-gert@greenie.muc.de |
|---|---|
| State | New |
| Headers | show
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net>
Delivered-To: patchwork@openvpn.net
Received: by 2002:a05:7000:525e:b0:838:aef6:1aff with SMTP id e30csp392961mag;
Wed, 18 Feb 2026 13:45:30 -0800 (PST)
X-Forwarded-Encrypted: i=2;
AJvYcCUHOAQ86ov5a66ZklugrLbXiaV8VRYAA6nVU2nwMvtokP/H3NZCJpBu5ScWX3IYfVLqe5ECJwOgM/Y=@openvpn.net
X-Received: by 2002:a05:6808:1814:b0:450:bc28:c883 with SMTP id
5614622812f47-46421de8e3fmr352180b6e.58.1771451129983;
Wed, 18 Feb 2026 13:45:29 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1771451129; cv=none;
d=google.com; s=arc-20240605;
b=NxADzbH6ECpUV2riTdBY4STlNNhDIKCI6jwIYfSM7AdBoRWIdaNQThYVfpHRPyZIpN
bOL6vQfRgXQPPAuCbONRgQhVS16+NTltAiIrkxd+HrA6l1ZaUMNHDrxocw86aMVY6eIZ
22D6B8ixxwNiaNHACXUHg7+o1OeJMgpLQgFNMtrP5bCiZniy7D+HLmpymikSqiSpjHhq
TGI3Q9Qr6qZJJIHyqCHdQDfvrQYUwfFQ4F28+t/k5XyJImIiB78eejlm3dZFyBpPIXyq
UADez3K6Fk9Ni3gKs8UnbAKTn0T2JgVI5snr8cNyI6u18h0I2eaYe8B4vnGG959adMTO
uReg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20240605;
h=errors-to:content-transfer-encoding:list-subscribe:list-help
:list-post:list-archive:list-unsubscribe:list-id:precedence:subject
:mime-version:references:in-reply-to:message-id:date:to:from
:dkim-signature:dkim-signature:dkim-signature;
bh=lweRH6b3Bha1ZLsKKojttoLDObqJM+43BGZZwbJxCkM=;
fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=;
b=PQ8HOes8lWL6fg2PDP0Uep9A7/JnIWbDY5FW/Dp8Ew9rWZYqviWAZMaoib724k9kwZ
vkvzGleDMVHnSj/dPFWKQn3Y76imICoMfSAyEdVGaFWtl1bJhHyH6+Sop6GmblE9OcFh
Q7sPExKUsnOUUW8JobpSpj+eK9TOZUYubFeLFlay7aGJ65XBlhv1H3Hk6uAtMoDsNs+A
1pWMRE8g/4E/jUuOwMNKdebGd5q2l4Vjb4zkIASEPpctPaRfk5BMq0E332vCqJMVLWG1
qRd6h/mDCe1Cdjak+x85sZbhzYV8SyxMvwCyS2Rp0hfnQnWrM6ozvpcPoQanvmoCSxM1
0yEw==;
dara=google.com
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=cBdmJxeX;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=Z5t0O9dO;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=GaSuZZfX;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7])
by mx.google.com with ESMTPS id
5614622812f47-4636b1a2c01si13549645b6e.130.2026.02.18.13.45.29
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Wed, 18 Feb 2026 13:45:29 -0800 (PST)
Received-SPF: pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) client-ip=216.105.38.7;
Authentication-Results: mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=cBdmJxeX;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=Z5t0O9dO;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=GaSuZZfX;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:
List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:
Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender:
Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;
bh=lweRH6b3Bha1ZLsKKojttoLDObqJM+43BGZZwbJxCkM=; b=cBdmJxeXBlK8h1/ISqdSC/7qFo
f2L5kJzq8JP5suohfiMkoC8ohzgbcwdVagnY+cdMAAx6XXxAk9WD2RDtUKjbkfpydTDL5rrVHZqnL
w9LsEeFCmugQDX4pCpLZRHpQeHso/dAOKTc8uJtC+u07qPIDuxfhSiQWZvEKoteSxWBQ=;
Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com)
by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95)
(envelope-from <openvpn-devel-bounces@lists.sourceforge.net>)
id 1vspMO-00037w-2T;
Wed, 18 Feb 2026 21:45:28 +0000
Received: from [172.30.29.66] (helo=mx.sourceforge.net)
by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95)
(envelope-from <gert@blue4.greenie.muc.de>) id 1vspMN-00037p-49
for openvpn-devel@lists.sourceforge.net;
Wed, 18 Feb 2026 21:45:27 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References:
In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=ahJLyZyaJvWuignLko06P5OfEmCIFNQIkIj5ndEzjC8=; b=Z5t0O9dO3ULKCjR0XTY2IJg2/R
lR85j7bXh8YqCGJIyJRlA4gn1b8koDOUaZEUui6j0Vwsu3useKeLNCAMHhMUErrYlxm24aIXbxPtz
HB7B0CPhYq+r/bNVqsXkMvoXdocYCp5UgfQNVB6ReqN3P76Zv8aNTyXO2mOcz+S0bRWA=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:
Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive;
bh=ahJLyZyaJvWuignLko06P5OfEmCIFNQIkIj5ndEzjC8=; b=GaSuZZfX9dmiSBEgOBXFNcxivj
dBuJIIVS4lp0kjcwyEs6xvHHOx5ihFKu3tmI58o0/TtcStM5HAES27vV58OmhuhXH/PRZHYFXG4XT
m6S7lIO+YVfG4FYw234ObjaBkUwGyhOwk3Fa1EGwrfeUJd8r7kEK4wFAbZoCBYC2KDVg=;
Received: from [193.149.48.129] (helo=blue.greenie.muc.de)
by sfi-mx-2.v28.lw.sourceforge.com with esmtps
(TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95)
id 1vspMM-0008HJ-AK for openvpn-devel@lists.sourceforge.net;
Wed, 18 Feb 2026 21:45:27 +0000
Received: from blue.greenie.muc.de (localhost [127.0.0.1])
by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 61ILjJvW026985
for <openvpn-devel@lists.sourceforge.net>; Wed, 18 Feb 2026 22:45:19 +0100
Received: (from gert@localhost)
by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 61ILjJgh026984
for openvpn-devel@lists.sourceforge.net; Wed, 18 Feb 2026 22:45:19 +0100
From: Gert Doering <gert@greenie.muc.de>
To: openvpn-devel@lists.sourceforge.net
Date: Wed, 18 Feb 2026 22:45:13 +0100
Message-ID: <20260218214519.26971-1-gert@greenie.muc.de>
X-Mailer: git-send-email 2.52.0
In-Reply-To:
<gerrit.1771415352000.I632368451923116e0a169ddb5b6e86a8f8486afc@gerrit.openvpn.net>
References:
<gerrit.1771415352000.I632368451923116e0a169ddb5b6e86a8f8486afc@gerrit.openvpn.net>
MIME-Version: 1.0
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software,
running on the system "sfi-spamd-2.hosts.colo.sdot.me",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: From: Frank Lichtenheld <frank@lichtenheld.com> strstr now
returns const char*. Change-Id: I632368451923116e0a169ddb5b6e86a8f8486afc
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com> Acked-by: Gert
Doering
<gert@greenie.muc.de> Gerrit URL: https://gerrit.openvpn.net/c/open [...]
Content analysis details: (1.3 points, 5.0 required)
pts rule name description
---- ----------------------
--------------------------------------------------
1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Headers-End: 1vspMM-0008HJ-AK
Subject: [Openvpn-devel] [PATCH v2] auth-pam: fix discards 'const' qualifier
from pointer target type
X-BeenThere: openvpn-devel@lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <openvpn-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive:
<http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel>
List-Post: <mailto:openvpn-devel@lists.sourceforge.net>
List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: openvpn-devel-bounces@lists.sourceforge.net
X-getmail-retrieved-from-mailbox: Inbox
X-GMAIL-THRID: =?utf-8?q?1857501140137511654?=
X-GMAIL-MSGID: =?utf-8?q?1857501140137511654?=
|
| Series |
[Openvpn-devel,v2] auth-pam: fix discards 'const' qualifier from pointer target type
|
expand
|
diff --git a/src/plugins/auth-pam/utils.c b/src/plugins/auth-pam/utils.c index 97befd6..bd5c382 100644 --- a/src/plugins/auth-pam/utils.c +++ b/src/plugins/auth-pam/utils.c @@ -66,12 +66,11 @@ /* state: all parameters are valid */ const char *searching = tosearch; - char *scratch; char temp[templen+1]; temp[0] = 0; - scratch = strstr(searching, searchfor); + const char *scratch = strstr(searching, searchfor); if (!scratch) { return strdup(tosearch);