[Openvpn-devel,v2] auth-pam: fix discards 'const' qualifier from pointer target type

Message ID 20260218214519.26971-1-gert@greenie.muc.de
State New
Headers show
Series [Openvpn-devel,v2] auth-pam: fix discards 'const' qualifier from pointer target type | expand

Commit Message

Gert Doering Feb. 18, 2026, 9:45 p.m. UTC
From: Frank Lichtenheld <frank@lichtenheld.com>

strstr now returns const char*.

Change-Id: I632368451923116e0a169ddb5b6e86a8f8486afc
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1545
(cherry picked from commit 7212f49d2f773a4f0d28d1450b9ee0b369385ea5)
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to release/2.6.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1545
This mail reflects revision 2 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Patch

diff --git a/src/plugins/auth-pam/utils.c b/src/plugins/auth-pam/utils.c
index 97befd6..bd5c382 100644
--- a/src/plugins/auth-pam/utils.c
+++ b/src/plugins/auth-pam/utils.c
@@ -66,12 +66,11 @@ 
     /* state: all parameters are valid */
 
     const char *searching = tosearch;
-    char *scratch;
 
     char temp[templen+1];
     temp[0] = 0;
 
-    scratch = strstr(searching, searchfor);
+    const char *scratch = strstr(searching, searchfor);
     if (!scratch)
     {
         return strdup(tosearch);