From patchwork Wed Feb 18 21:47:06 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 4777 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:525e:b0:838:aef6:1aff with SMTP id e30csp393909mag; Wed, 18 Feb 2026 13:47:27 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWqxGH+/3g1kfrk9olHCLfc+QU8HC/od3BW0d+0FxT3MB1RuAWrUbDOy4gaDSEylUo0b5lXWiK+sKs=@openvpn.net X-Received: by 2002:a05:6830:7189:b0:7c7:5349:4e31 with SMTP id 46e09a7af769-7d505e16fc1mr1470162a34.21.1771451247159; Wed, 18 Feb 2026 13:47:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771451247; cv=none; d=google.com; s=arc-20240605; b=QJC2GbwYjQm6dKwZlKmnqX8Q3Q4jyc7n2uPKIc9tpcp4kLQ9T3ZDv/Fz6C2A+wQnhl KJHdy9v0ZlkUMXKsXKI8a4/9GX2qUQhQjTrfJuGDb8mYmYti8C/WA/Kkzu1HrzfbOnPU U2s4J6Z7u6x8CYUWXDChDXHJvBLWhgcaba8OitetlIdG8BC1lszE6I3YUhQgad0nYJ7p LsYsimDxYSqg9QRJZZX4zmSmoDyS8CGI8XdcevmOkGrOvBcG1I2T/TvbBvnydetCok5z C/OldArtnqe0vvDvgftLP0PUXe9QOz6qifIDuQq+oEerYNKZtH0ibMhwXuNQIEvecSso 91sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=TuSM7EIM26BmFLtqyf/xyp7HskPQ+owxL3RbT7Bj2og=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=DHWISSZ9NvsytX4/RhQUBGwewwpr40Tnf8cLmnEHna5mE0VKdv9SEsscCkg/RjQZG+ JRf20OrbuUpVAIQcZp7j+LgRKheJ7ceYzj/Xd2t1NFhNuTkJCizq28H77Tbv9wbSD/uy fJczYZDNhw1uvox0zj/qW7PREgbUhg/QhTBIB0YQnNu3oM3j+ZWsfDI0ZSNTEeHxcjin Pp3aQPu0as5qGjfYccEcbwMZrkG6C5DjEBczj8MHzskk0d92/xmTinsf+6UispKb+iRy /nIkufVzs+T6mJ/dEjPSse1J57POQ5y3HV+sawipA153t0z2VdJa6N9v8UsDFdBP4UUL Ey4Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=YhlX5K37; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Hf+NBTZ3; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=VAPaG8h2; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-7d4a7560cbesi14558262a34.59.2026.02.18.13.47.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Feb 2026 13:47:27 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=YhlX5K37; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Hf+NBTZ3; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=VAPaG8h2; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TuSM7EIM26BmFLtqyf/xyp7HskPQ+owxL3RbT7Bj2og=; b=YhlX5K377ztqnIBd73oa9NHj98 ikVJtKlHswiKJQ9Aq7fvSudrlShmc/BBRGcgACVd8rlqWAhUdDpnXzm22bSIRDn3bD24mnbFMiZEd HrjSCakqcx/MEdmBfoXUv3jjEqfe2iwDHwwCbJhFo3wMUOq5sgRwSV4inLfu4QPi/MPo=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vspOH-0002lR-BZ; Wed, 18 Feb 2026 21:47:25 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vspOG-0002lJ-MW for openvpn-devel@lists.sourceforge.net; Wed, 18 Feb 2026 21:47:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tsyledOmDc3zSkAt94cGUgbgBQdgf/l7LP0D9PPsQ0c=; b=Hf+NBTZ3r+FaHWp0KJ9pbMjNsY 1hnN+WQXU4fKxlqPMByI20fFKMtWMLQymmmNsul9ooQ2gpgbhbOqPHT4lbxse2ko0FKfXSltsQ5G1 znHImxcTMlEJQBgYGTjvTvCQn6eMSAWzyaUwC4Cj/cOtD3ZZ2O7kQvoJZIrFfjAIDcMI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tsyledOmDc3zSkAt94cGUgbgBQdgf/l7LP0D9PPsQ0c=; b=VAPaG8h2+u2nM9tVGHRG6j5ZyX VJG3aaIFSpNS+h6GsNr6RN8OkgXeVnyIjaVoFLQqF0iGuwaW0/2oxvpmKSv0H4oKnoG7NxpUW8PS+ Kc2IFUAe9pImp61oEHhrA3AjDJLfNPLdCcHeHVTz2t5RiPbVn5zY8n+z5xZVEBZC9ouw=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vspOF-0008LZ-RK for openvpn-devel@lists.sourceforge.net; Wed, 18 Feb 2026 21:47:24 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 61ILlClR027132 for ; Wed, 18 Feb 2026 22:47:12 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 61ILlC1G027131 for openvpn-devel@lists.sourceforge.net; Wed, 18 Feb 2026 22:47:12 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 18 Feb 2026 22:47:06 +0100 Message-ID: <20260218214712.27119-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld strstr now returns const char*. Change-Id: I632368451923116e0a169ddb5b6e86a8f8486afc Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/open [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1vspOF-0008LZ-RK Subject: [Openvpn-devel] [PATCH v1] auth-pam: fix discards 'const' qualifier from pointer target type X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1857501262893864833?= X-GMAIL-MSGID: =?utf-8?q?1857501262893864833?= From: Frank Lichtenheld strstr now returns const char*. Change-Id: I632368451923116e0a169ddb5b6e86a8f8486afc Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1543 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1543 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/plugins/auth-pam/utils.c b/src/plugins/auth-pam/utils.c index d7b544a..a4d2d0b 100644 --- a/src/plugins/auth-pam/utils.c +++ b/src/plugins/auth-pam/utils.c @@ -66,12 +66,11 @@ /* state: all parameters are valid */ const char *searching = tosearch; - char *scratch; char temp[templen + 1]; temp[0] = 0; - scratch = strstr(searching, searchfor); + const char *scratch = strstr(searching, searchfor); if (!scratch) { return strdup(tosearch);